* [PATCH 0/6] v3u: add SDHI/MMC support
@ 2020-12-27 17:41 Wolfram Sang
2020-12-27 17:41 ` [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support Wolfram Sang
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Wolfram Sang @ 2020-12-27 17:41 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, devicetree, linux-clk, linux-kernel, linux-mmc
So, this series adds SDHI/MMC support to the Renesas R-Car V3U SoC.
While SDHI is usually complicated, adding basic support to V3U was
refreshingly uncomplicated :) The crux was this time in the CPG driver.
In order to avoid code duplication, a CPG library was introduced, so we
can share the SD clock handling between generic Gen3, V3U, and hopefully
Gen4 later. The library turned out to be a quite nice solution for SDHI.
I am quite happy with it. I think we could have a similar benefit for
RPC, but we still need to see if this is enabled on V3U after all.
So much for now, looking forward to comments. The branch is here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/v3u/sdhi
Happy hacking,
Wolfram
Takeshi Saito (2):
arm64: dts: renesas: r8a779a0: Add MMC node
arm64: dts: renesas: falcon: Enable MMC
Wolfram Sang (4):
dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support
clk: renesas: rcar-gen3: remove cpg_quirks access when registering SD
clock
clk: renesas: rcar-gen3: factor out CPG library
clk: renesas: r8a779a0: add SDHI support
.../devicetree/bindings/mmc/renesas,sdhi.yaml | 1 +
.../boot/dts/renesas/r8a779a0-falcon.dts | 41 +++
arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 12 +
drivers/clk/renesas/Kconfig | 5 +
drivers/clk/renesas/Makefile | 1 +
drivers/clk/renesas/r8a779a0-cpg-mssr.c | 17 +-
drivers/clk/renesas/rcar-cpg-lib.c | 270 ++++++++++++++++++
drivers/clk/renesas/rcar-cpg-lib.h | 33 +++
drivers/clk/renesas/rcar-gen3-cpg.c | 267 +----------------
9 files changed, 387 insertions(+), 260 deletions(-)
create mode 100644 drivers/clk/renesas/rcar-cpg-lib.c
create mode 100644 drivers/clk/renesas/rcar-cpg-lib.h
--
2.28.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support
2020-12-27 17:41 [PATCH 0/6] v3u: add SDHI/MMC support Wolfram Sang
@ 2020-12-27 17:41 ` Wolfram Sang
2021-01-08 3:36 ` Rob Herring
` (2 more replies)
2020-12-27 17:41 ` [PATCH 5/6] arm64: dts: renesas: r8a779a0: Add MMC node Wolfram Sang
2020-12-27 17:42 ` [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC Wolfram Sang
2 siblings, 3 replies; 12+ messages in thread
From: Wolfram Sang @ 2020-12-27 17:41 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Ulf Hansson, Rob Herring, linux-mmc, devicetree,
linux-kernel
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index 6bbf29b5c239..5908a717d2e8 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -59,6 +59,7 @@ properties:
- renesas,sdhi-r8a77980 # R-Car V3H
- renesas,sdhi-r8a77990 # R-Car E3
- renesas,sdhi-r8a77995 # R-Car D3
+ - renesas,sdhi-r8a779a0 # R-Car V3U
- const: renesas,rcar-gen3-sdhi # R-Car Gen3 or RZ/G2
reg:
--
2.28.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/6] arm64: dts: renesas: r8a779a0: Add MMC node
2020-12-27 17:41 [PATCH 0/6] v3u: add SDHI/MMC support Wolfram Sang
2020-12-27 17:41 ` [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support Wolfram Sang
@ 2020-12-27 17:41 ` Wolfram Sang
2020-12-27 17:45 ` Wolfram Sang
2021-01-08 12:47 ` Geert Uytterhoeven
2020-12-27 17:42 ` [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC Wolfram Sang
2 siblings, 2 replies; 12+ messages in thread
From: Wolfram Sang @ 2020-12-27 17:41 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Takeshi Saito, Koji Matsuoka, Wolfram Sang, Geert Uytterhoeven,
Magnus Damm, Rob Herring, devicetree, linux-kernel
From: Takeshi Saito <takeshi.saito.xv@renesas.com>
Add a device node for MMC.
Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
[wsa: double checked & rebased]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
index 324deeed9078..68aaa49c3540 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
@@ -667,6 +667,18 @@ dmac1: dma-controller@e7350000 {
/* placeholder */
};
+ mmc0: mmc@ee140000 {
+ compatible = "renesas,sdhi-r8a779a0",
+ "renesas,rcar-gen3-sdhi";
+ reg = <0 0xee140000 0 0x2000>;
+ interrupts = <GIC_SPI 236 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 706>;
+ power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
+ resets = <&cpg 706>;
+ max-frequency = <200000000>;
+ status = "disabled";
+ };
+
gic: interrupt-controller@f1000000 {
compatible = "arm,gic-v3";
#interrupt-cells = <3>;
--
2.28.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC
2020-12-27 17:41 [PATCH 0/6] v3u: add SDHI/MMC support Wolfram Sang
2020-12-27 17:41 ` [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support Wolfram Sang
2020-12-27 17:41 ` [PATCH 5/6] arm64: dts: renesas: r8a779a0: Add MMC node Wolfram Sang
@ 2020-12-27 17:42 ` Wolfram Sang
2021-01-08 12:59 ` Geert Uytterhoeven
2021-01-12 11:47 ` Geert Uytterhoeven
2 siblings, 2 replies; 12+ messages in thread
From: Wolfram Sang @ 2020-12-27 17:42 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Takeshi Saito, Koji Matsuoka, Wolfram Sang, Geert Uytterhoeven,
Magnus Damm, Rob Herring, devicetree, linux-kernel
From: Takeshi Saito <takeshi.saito.xv@renesas.com>
Enable MMC on the Falcon board.
Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
[wsa: double checked & rebased]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
.../boot/dts/renesas/r8a779a0-falcon.dts | 41 +++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
index 48801f2bdbe5..0c44466d398f 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
@@ -20,6 +20,24 @@ aliases {
chosen {
stdout-path = "serial0:115200n8";
};
+
+ reg_1p8v: regulator0 {
+ compatible = "regulator-fixed";
+ regulator-name = "fixed-1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ reg_3p3v: regulator1 {
+ compatible = "regulator-fixed";
+ regulator-name = "fixed-3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
};
&avb0 {
@@ -169,6 +187,23 @@ &i2c6 {
clock-frequency = <100000>;
};
+&mmc0 {
+ pinctrl-0 = <&mmc_pins>;
+ pinctrl-1 = <&mmc_pins>;
+ pinctrl-names = "default", "state_uhs";
+
+ vmmc-supply = <®_3p3v>;
+ vqmmc-supply = <®_1p8v>;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+ bus-width = <8>;
+ no-sd;
+ no-sdio;
+ non-removable;
+ full-pwr-cycle-in-suspend;
+ status = "okay";
+};
+
&pfc {
avb0_pins: avb0 {
mux {
@@ -307,6 +342,12 @@ i2c6_pins: i2c6 {
groups = "i2c6";
function = "i2c6";
};
+
+ mmc_pins: mmc {
+ groups = "mmc_data8", "mmc_ctrl", "mmc_ds";
+ function = "mmc";
+ power-source = <1800>;
+ };
};
&rwdt {
--
2.28.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 5/6] arm64: dts: renesas: r8a779a0: Add MMC node
2020-12-27 17:41 ` [PATCH 5/6] arm64: dts: renesas: r8a779a0: Add MMC node Wolfram Sang
@ 2020-12-27 17:45 ` Wolfram Sang
2021-01-08 12:47 ` Geert Uytterhoeven
1 sibling, 0 replies; 12+ messages in thread
From: Wolfram Sang @ 2020-12-27 17:45 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Takeshi Saito, Koji Matsuoka, Geert Uytterhoeven, Magnus Damm,
Rob Herring, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
On Sun, Dec 27, 2020 at 06:41:59PM +0100, Wolfram Sang wrote:
> From: Takeshi Saito <takeshi.saito.xv@renesas.com>
>
> Add a device node for MMC.
>
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> [wsa: double checked & rebased]
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
I just noticed that Saito-san's SoB is missing from the DTB patches.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support
2020-12-27 17:41 ` [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support Wolfram Sang
@ 2021-01-08 3:36 ` Rob Herring
2021-01-08 12:23 ` Geert Uytterhoeven
2021-01-13 11:25 ` Ulf Hansson
2 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2021-01-08 3:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Ulf Hansson, linux-mmc, Rob Herring, devicetree,
linux-renesas-soc
On Sun, 27 Dec 2020 18:41:55 +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support
2020-12-27 17:41 ` [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support Wolfram Sang
2021-01-08 3:36 ` Rob Herring
@ 2021-01-08 12:23 ` Geert Uytterhoeven
2021-01-13 11:25 ` Ulf Hansson
2 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2021-01-08 12:23 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux-Renesas, Ulf Hansson, Rob Herring, Linux MMC List,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On Sun, Dec 27, 2020 at 6:44 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/6] arm64: dts: renesas: r8a779a0: Add MMC node
2020-12-27 17:41 ` [PATCH 5/6] arm64: dts: renesas: r8a779a0: Add MMC node Wolfram Sang
2020-12-27 17:45 ` Wolfram Sang
@ 2021-01-08 12:47 ` Geert Uytterhoeven
1 sibling, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2021-01-08 12:47 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux-Renesas, Takeshi Saito, Koji Matsuoka, Magnus Damm,
Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Wolfram,
On Sun, Dec 27, 2020 at 6:42 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> From: Takeshi Saito <takeshi.saito.xv@renesas.com>
>
> Add a device node for MMC.
>
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> [wsa: double checked & rebased]
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> @@ -667,6 +667,18 @@ dmac1: dma-controller@e7350000 {
> /* placeholder */
> };
>
> + mmc0: mmc@ee140000 {
Hmm, seems we use the mmc0 label on all V3[HMU] SoCs, but sdhiX on all
other R-Car Gen3 SoCs...
> + compatible = "renesas,sdhi-r8a779a0",
> + "renesas,rcar-gen3-sdhi";
> + reg = <0 0xee140000 0 0x2000>;
> + interrupts = <GIC_SPI 236 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 706>;
> + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> + resets = <&cpg 706>;
> + max-frequency = <200000000>;
> + status = "disabled";
> + };
> +
Anyway:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC
2020-12-27 17:42 ` [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC Wolfram Sang
@ 2021-01-08 12:59 ` Geert Uytterhoeven
2021-01-19 12:46 ` Wolfram Sang
2021-01-12 11:47 ` Geert Uytterhoeven
1 sibling, 1 reply; 12+ messages in thread
From: Geert Uytterhoeven @ 2021-01-08 12:59 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux-Renesas, Takeshi Saito, Koji Matsuoka, Magnus Damm,
Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Wolfram,
On Sun, Dec 27, 2020 at 6:42 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> From: Takeshi Saito <takeshi.saito.xv@renesas.com>
>
> Enable MMC on the Falcon board.
>
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> [wsa: double checked & rebased]
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
> @@ -20,6 +20,24 @@ aliases {
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + reg_1p8v: regulator0 {
Please use a better node name, to avoid accidental duplicates, cfr. commit
45f5d5a9e34d3fe4 ("arm64: dts: renesas: r8a77995: draak: Fix backlight
regulator name")
> + compatible = "regulator-fixed";
> + regulator-name = "fixed-1.8V";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + reg_3p3v: regulator1 {
Likewise
> + compatible = "regulator-fixed";
> + regulator-name = "fixed-3.3V";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> };
>
> &avb0 {
> @@ -169,6 +187,23 @@ &i2c6 {
> clock-frequency = <100000>;
> };
>
> +&mmc0 {
> + pinctrl-0 = <&mmc_pins>;
> + pinctrl-1 = <&mmc_pins>;
> + pinctrl-names = "default", "state_uhs";
> +
> + vmmc-supply = <®_3p3v>;
> + vqmmc-supply = <®_1p8v>;
> + mmc-hs200-1_8v;
> + mmc-hs400-1_8v;
> + bus-width = <8>;
> + no-sd;
> + no-sdio;
I'm no expert on the no-sd{,io} properties.
Just wondering if we need them on other R-Car gen3 boards with eMMC, too/
> + non-removable;
> + full-pwr-cycle-in-suspend;
> + status = "okay";
> +};
With the node names fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC
2020-12-27 17:42 ` [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC Wolfram Sang
2021-01-08 12:59 ` Geert Uytterhoeven
@ 2021-01-12 11:47 ` Geert Uytterhoeven
1 sibling, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2021-01-12 11:47 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux-Renesas, Takeshi Saito, Koji Matsuoka, Magnus Damm,
Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Wolfram,
On Sun, Dec 27, 2020 at 6:42 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> From: Takeshi Saito <takeshi.saito.xv@renesas.com>
>
> Enable MMC on the Falcon board.
>
> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> [wsa: double checked & rebased]
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> .../boot/dts/renesas/r8a779a0-falcon.dts | 41 +++++++++++++++++++
As the EMMC is part of the CPU board, it should be added to
r8a779a0-falcon-cpu.dtsi instead of r8a779a0-falcon.dts.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support
2020-12-27 17:41 ` [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support Wolfram Sang
2021-01-08 3:36 ` Rob Herring
2021-01-08 12:23 ` Geert Uytterhoeven
@ 2021-01-13 11:25 ` Ulf Hansson
2 siblings, 0 replies; 12+ messages in thread
From: Ulf Hansson @ 2021-01-13 11:25 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux-Renesas, Rob Herring, linux-mmc, DTML, Linux Kernel Mailing List
On Sun, 27 Dec 2020 at 18:42, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> index 6bbf29b5c239..5908a717d2e8 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -59,6 +59,7 @@ properties:
> - renesas,sdhi-r8a77980 # R-Car V3H
> - renesas,sdhi-r8a77990 # R-Car E3
> - renesas,sdhi-r8a77995 # R-Car D3
> + - renesas,sdhi-r8a779a0 # R-Car V3U
> - const: renesas,rcar-gen3-sdhi # R-Car Gen3 or RZ/G2
>
> reg:
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC
2021-01-08 12:59 ` Geert Uytterhoeven
@ 2021-01-19 12:46 ` Wolfram Sang
0 siblings, 0 replies; 12+ messages in thread
From: Wolfram Sang @ 2021-01-19 12:46 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux-Renesas, Takeshi Saito, Koji Matsuoka, Magnus Damm,
Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
> > + reg_1p8v: regulator0 {
>
> Please use a better node name, to avoid accidental duplicates, cfr. commit
> 45f5d5a9e34d3fe4 ("arm64: dts: renesas: r8a77995: draak: Fix backlight
> regulator name")
Done.
> > + no-sd;
> > + no-sdio;
>
> I'm no expert on the no-sd{,io} properties.
> Just wondering if we need them on other R-Car gen3 boards with eMMC, too/
Won't hurt. I'll prepare something...
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-01-19 14:57 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-27 17:41 [PATCH 0/6] v3u: add SDHI/MMC support Wolfram Sang
2020-12-27 17:41 ` [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Add r8a779a0 support Wolfram Sang
2021-01-08 3:36 ` Rob Herring
2021-01-08 12:23 ` Geert Uytterhoeven
2021-01-13 11:25 ` Ulf Hansson
2020-12-27 17:41 ` [PATCH 5/6] arm64: dts: renesas: r8a779a0: Add MMC node Wolfram Sang
2020-12-27 17:45 ` Wolfram Sang
2021-01-08 12:47 ` Geert Uytterhoeven
2020-12-27 17:42 ` [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC Wolfram Sang
2021-01-08 12:59 ` Geert Uytterhoeven
2021-01-19 12:46 ` Wolfram Sang
2021-01-12 11:47 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).