From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>,
kuninori.morimoto.gx@renesas.com, nsaenzjulienne@suse.de,
f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties
Date: Wed, 13 Jan 2021 16:09:17 +0000 [thread overview]
Message-ID: <20210113160917.GF4641@sirena.org.uk> (raw)
In-Reply-To: <20210113152225.GA2334778@robh.at.kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2464 bytes --]
On Wed, Jan 13, 2021 at 09:22:25AM -0600, Rob Herring wrote:
> I'm not sure this makes sense to be generic, but if so, we already have
> the clock binding and should use (and possibly extend) that.
> This appears to all be configuration of clocks within the codec, so
> these properties belong in the codec or cpu nodes.
Right, I think this should just be the clock binding.
> > + The PLL id and clock source id are specific to the particular component
> > + so see the relevant component driver for the ids. Typically the
This should refer to the bindings for components, not to their drivers.
> > + clock source id indicates the pin the source clock is connected to.
> > + The same phandle can appear in multiple entries so that several plls
> > + can be set in the same component.
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > + plls-clocks:
> > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> > + description: |
> > + A list of clock names giving the source clock for each setting
> > + in the plls property.
> > +
> > + sysclks:
> > + description: |
> > + A list of component sysclk settings. There are 4 cells per sysclk
> > + setting:
> > + - phandle to the node of the codec or cpu component,
> > + - component sysclk id,
> > + - component clock source id,
> > + - direction of the clock: 0 if the clock is an input to the component,
> > + 1 if it is an output.
>
> A clock provider and consumer would provide the direction.
>
> > + The sysclk id and clock source id are specific to the particular
> > + component so see the relevant component driver for the ids. Typically
> > + the clock source id indicates the pin the source clock is connected to.
> > + The same phandle can appear in multiple entries so that several sysclks
> > + can be set in the same component.
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > + sysclks-clocks:
> > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> > + description: |
> > + A list of clock names giving the source clock for each setting
> > + in the sysclks property.
> > +
> > +dependencies:
> > + plls: [ plls-clocks ]
> > + sysclks: [ sysclks-clocks ]
> > +
> > required:
> > - dais
> >
> > --
> > 2.20.1
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-13 16:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 16:04 [PATCH v4 0/6] Add support for Rpi4b + Cirrus Lochnagar2 and CS47L15 Richard Fitzgerald
2021-01-08 16:04 ` [PATCH v4 1/6] of: base: Add of_count_phandle_with_fixed_args() Richard Fitzgerald
2021-01-08 16:04 ` [PATCH v4 2/6] dt-bindings: audio-graph-card: Add plls and sysclks properties Richard Fitzgerald
2021-01-13 15:22 ` Rob Herring
2021-01-13 16:09 ` Mark Brown [this message]
2021-01-15 10:35 ` Richard Fitzgerald
2021-01-15 13:11 ` Mark Brown
2021-01-15 14:42 ` Richard Fitzgerald
2021-01-15 15:20 ` Mark Brown
2021-01-15 16:15 ` Richard Fitzgerald
2021-01-15 18:35 ` Mark Brown
2021-01-14 10:31 ` Richard Fitzgerald
2021-01-14 11:14 ` Mark Brown
2021-01-08 16:04 ` [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks Richard Fitzgerald
2021-01-12 1:35 ` Kuninori Morimoto
2021-01-12 10:22 ` Richard Fitzgerald
2021-01-13 0:00 ` Kuninori Morimoto
2021-01-13 15:51 ` Mark Brown
2021-01-08 16:04 ` [PATCH v4 4/6] ASoC: madera: Allow codecs to be selected from kernel config Richard Fitzgerald
2021-01-08 16:05 ` [PATCH v4 5/6] ASoC: madera: Export clock config defines to dt-bindings Richard Fitzgerald
2021-01-08 16:05 ` [PATCH v4 6/6] ARM: dts: Add dts for RPi4b + Cirrus Logic Lochnagar2 + CS47L15 Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113160917.GF4641@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).