* [PATCH] dt-bindings: media: ov5647: Fix filename
@ 2021-01-15 10:16 Jacopo Mondi
2021-01-15 10:20 ` Kieran Bingham
2021-01-15 15:45 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Jacopo Mondi @ 2021-01-15 10:16 UTC (permalink / raw)
To: Rob Herring, Mauro Carvalho Chehab, Sakari Ailus
Cc: Jacopo Mondi, Linux Media Mailing List, devicetree
Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
ov5647.yaml") renamed the bindings file but did not update the
Id: field there.
Fix it by using the new filename.
Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
index 280c62afae13..429566c9ee1d 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
-$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
+$id: http://devicetree.org/schemas/media/i2c/ovti,ov5647.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
title: Omnivision OV5647 raw image sensor
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: media: ov5647: Fix filename
2021-01-15 10:16 [PATCH] dt-bindings: media: ov5647: Fix filename Jacopo Mondi
@ 2021-01-15 10:20 ` Kieran Bingham
2021-01-15 11:01 ` Jacopo Mondi
2021-01-15 15:45 ` Rob Herring
1 sibling, 1 reply; 6+ messages in thread
From: Kieran Bingham @ 2021-01-15 10:20 UTC (permalink / raw)
To: Jacopo Mondi, Rob Herring, Mauro Carvalho Chehab, Sakari Ailus
Cc: Linux Media Mailing List, devicetree
Hi Jacopo,
On 15/01/2021 10:16, Jacopo Mondi wrote:
> Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> ov5647.yaml") renamed the bindings file but did not update the
> Id: field there.
>
> Fix it by using the new filename.
>
> Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
I wonder if this could be automatically validated by one of the checkers
at some point. (I assume it isn't already).
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> index 280c62afae13..429566c9ee1d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5647.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: Omnivision OV5647 raw image sensor
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: media: ov5647: Fix filename
2021-01-15 10:20 ` Kieran Bingham
@ 2021-01-15 11:01 ` Jacopo Mondi
2021-01-15 11:04 ` Sakari Ailus
2021-01-15 15:50 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Jacopo Mondi @ 2021-01-15 11:01 UTC (permalink / raw)
To: Kieran Bingham
Cc: Rob Herring, Mauro Carvalho Chehab, Sakari Ailus,
Linux Media Mailing List, devicetree
Hi Kieran
On Fri, Jan 15, 2021 at 10:20:20AM +0000, Kieran Bingham wrote:
> Hi Jacopo,
>
> On 15/01/2021 10:16, Jacopo Mondi wrote:
> > Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> > ov5647.yaml") renamed the bindings file but did not update the
> > Id: field there.
> >
> > Fix it by using the new filename.
> >
> > Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
>
> I wonder if this could be automatically validated by one of the checkers
> at some point. (I assume it isn't already).
>
The dt validation process complains
../Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml: $id: relative path/filename doesn't match actual path or filename
I can't tell if it's a newly introduced validation or it was there
already when I renamed that file ~6 months ago and I failed to run
validation :/
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> > ---
> > Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> > index 280c62afae13..429566c9ee1d 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> > @@ -1,7 +1,7 @@
> > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > %YAML 1.2
> > ---
> > -$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
> > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5647.yaml#
> > $schema: http://devicetree.org/meta-schemas/core.yaml#
> >
> > title: Omnivision OV5647 raw image sensor
> > --
> > 2.29.2
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: media: ov5647: Fix filename
2021-01-15 11:01 ` Jacopo Mondi
@ 2021-01-15 11:04 ` Sakari Ailus
2021-01-15 15:50 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Sakari Ailus @ 2021-01-15 11:04 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Kieran Bingham, Rob Herring, Mauro Carvalho Chehab,
Linux Media Mailing List, devicetree
On Fri, Jan 15, 2021 at 12:01:46PM +0100, Jacopo Mondi wrote:
> Hi Kieran
>
> On Fri, Jan 15, 2021 at 10:20:20AM +0000, Kieran Bingham wrote:
> > Hi Jacopo,
> >
> > On 15/01/2021 10:16, Jacopo Mondi wrote:
> > > Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> > > ov5647.yaml") renamed the bindings file but did not update the
> > > Id: field there.
> > >
> > > Fix it by using the new filename.
> > >
> > > Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> >
> > I wonder if this could be automatically validated by one of the checkers
> > at some point. (I assume it isn't already).
> >
>
> The dt validation process complains
>
> ../Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml: $id: relative path/filename doesn't match actual path or filename
>
> I can't tell if it's a newly introduced validation or it was there
> already when I renamed that file ~6 months ago and I failed to run
> validation :/
I do run checkpatch before merging but I haven't done DT validation
regularly.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: media: ov5647: Fix filename
2021-01-15 10:16 [PATCH] dt-bindings: media: ov5647: Fix filename Jacopo Mondi
2021-01-15 10:20 ` Kieran Bingham
@ 2021-01-15 15:45 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-01-15 15:45 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Mauro Carvalho Chehab, Sakari Ailus, Linux Media Mailing List,
devicetree
On Fri, Jan 15, 2021 at 11:16:52AM +0100, Jacopo Mondi wrote:
> Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> ov5647.yaml") renamed the bindings file but did not update the
> Id: field there.
>
> Fix it by using the new filename.
>
> Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
> Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Rob Herring <robh@kernel.org>
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> index 280c62afae13..429566c9ee1d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5647.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: Omnivision OV5647 raw image sensor
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: media: ov5647: Fix filename
2021-01-15 11:01 ` Jacopo Mondi
2021-01-15 11:04 ` Sakari Ailus
@ 2021-01-15 15:50 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-01-15 15:50 UTC (permalink / raw)
To: Jacopo Mondi
Cc: Kieran Bingham, Mauro Carvalho Chehab, Sakari Ailus,
Linux Media Mailing List, devicetree
On Fri, Jan 15, 2021 at 12:01:46PM +0100, Jacopo Mondi wrote:
> Hi Kieran
>
> On Fri, Jan 15, 2021 at 10:20:20AM +0000, Kieran Bingham wrote:
> > Hi Jacopo,
> >
> > On 15/01/2021 10:16, Jacopo Mondi wrote:
> > > Commit 1b5071af8240 ("media: dt-bindings: media: i2c: Rename
> > > ov5647.yaml") renamed the bindings file but did not update the
> > > Id: field there.
> > >
> > > Fix it by using the new filename.
> > >
> > > Fixes: 1b5071af8240 ("media: dt-bindings: media: i2c: Rename ov5647.yaml")
> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> >
> > I wonder if this could be automatically validated by one of the checkers
> > at some point. (I assume it isn't already).
> >
>
> The dt validation process complains
>
> ../Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml: $id: relative path/filename doesn't match actual path or filename
>
> I can't tell if it's a newly introduced validation or it was there
> already when I renamed that file ~6 months ago and I failed to run
> validation :/
It's been there since Aug 2019.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-15 15:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 10:16 [PATCH] dt-bindings: media: ov5647: Fix filename Jacopo Mondi
2021-01-15 10:20 ` Kieran Bingham
2021-01-15 11:01 ` Jacopo Mondi
2021-01-15 11:04 ` Sakari Ailus
2021-01-15 15:50 ` Rob Herring
2021-01-15 15:45 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).