* [PATCH v2 0/3] gpio: pca953x: Add support for pca9506
@ 2021-01-15 16:46 Uwe Kleine-König
2021-01-15 16:46 ` [PATCH v2 1/3] " Uwe Kleine-König
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Uwe Kleine-König @ 2021-01-15 16:46 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring, Andy Shevchenko
Cc: linux-gpio, kernel, devicetree
Hello,
compared to (implicit) v1 (Message-Id:
20210113194952.104734-1-u.kleine-koenig@pengutronix.de) I split the
patch #1 into driver adaption and dt documenation (i.e. patches #1 and
#2 here).
For patch #3 I did s/chips/lines/ in the commit log and capitalized
"Increase" in the summary line.
Best regards
Uwe
Uwe Kleine-König (3):
gpio: pca953x: Add support for pca9506
dt-bindings: gpio: pca953x: Document new supported chip pca9506
dt-bindings: gpio: pca953x: Increase allowed length for
gpio-line-names
Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 3 ++-
drivers/gpio/gpio-pca953x.c | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e
--
2.29.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/3] gpio: pca953x: Add support for pca9506
2021-01-15 16:46 [PATCH v2 0/3] gpio: pca953x: Add support for pca9506 Uwe Kleine-König
@ 2021-01-15 16:46 ` Uwe Kleine-König
2021-01-15 16:46 ` [PATCH v2 2/3] dt-bindings: gpio: pca953x: Document new supported chip pca9506 Uwe Kleine-König
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Uwe Kleine-König @ 2021-01-15 16:46 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring, Andy Shevchenko
Cc: linux-gpio, kernel, devicetree
According to the reference manual "The PCA9505 is identical to the
PCA9506 except that it includes 100 kΩ internal pull-up resistors on all
the I/Os." So the pca9506 device can be considered identical to the
pca9505 for the gpio driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/gpio/gpio-pca953x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 825b362eb4b7..5ea09fd01544 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -73,6 +73,7 @@
static const struct i2c_device_id pca953x_id[] = {
{ "pca6416", 16 | PCA953X_TYPE | PCA_INT, },
{ "pca9505", 40 | PCA953X_TYPE | PCA_INT, },
+ { "pca9506", 40 | PCA953X_TYPE | PCA_INT, },
{ "pca9534", 8 | PCA953X_TYPE | PCA_INT, },
{ "pca9535", 16 | PCA953X_TYPE | PCA_INT, },
{ "pca9536", 4 | PCA953X_TYPE, },
@@ -1236,6 +1237,7 @@ static int pca953x_resume(struct device *dev)
static const struct of_device_id pca953x_dt_ids[] = {
{ .compatible = "nxp,pca6416", .data = OF_953X(16, PCA_INT), },
{ .compatible = "nxp,pca9505", .data = OF_953X(40, PCA_INT), },
+ { .compatible = "nxp,pca9506", .data = OF_953X(40, PCA_INT), },
{ .compatible = "nxp,pca9534", .data = OF_953X( 8, PCA_INT), },
{ .compatible = "nxp,pca9535", .data = OF_953X(16, PCA_INT), },
{ .compatible = "nxp,pca9536", .data = OF_953X( 4, 0), },
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/3] dt-bindings: gpio: pca953x: Document new supported chip pca9506
2021-01-15 16:46 [PATCH v2 0/3] gpio: pca953x: Add support for pca9506 Uwe Kleine-König
2021-01-15 16:46 ` [PATCH v2 1/3] " Uwe Kleine-König
@ 2021-01-15 16:46 ` Uwe Kleine-König
2021-01-18 15:17 ` Linus Walleij
2021-01-15 16:46 ` [PATCH v2 3/3] dt-bindings: gpio: pca953x: Increase allowed length for gpio-line-names Uwe Kleine-König
2021-01-19 12:45 ` [PATCH v2 0/3] gpio: pca953x: Add support for pca9506 Bartosz Golaszewski
3 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2021-01-15 16:46 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring, Andy Shevchenko
Cc: linux-gpio, kernel, devicetree
The previous patch added support for this chip. Add its name to the list
of allowed compatibles.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index f5ee23c2df60..cdd7744b8723 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -32,6 +32,7 @@ properties:
- maxim,max7327
- nxp,pca6416
- nxp,pca9505
+ - nxp,pca9506
- nxp,pca9534
- nxp,pca9535
- nxp,pca9536
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/3] dt-bindings: gpio: pca953x: Increase allowed length for gpio-line-names
2021-01-15 16:46 [PATCH v2 0/3] gpio: pca953x: Add support for pca9506 Uwe Kleine-König
2021-01-15 16:46 ` [PATCH v2 1/3] " Uwe Kleine-König
2021-01-15 16:46 ` [PATCH v2 2/3] dt-bindings: gpio: pca953x: Document new supported chip pca9506 Uwe Kleine-König
@ 2021-01-15 16:46 ` Uwe Kleine-König
2021-01-18 15:17 ` Linus Walleij
2021-01-19 12:45 ` [PATCH v2 0/3] gpio: pca953x: Add support for pca9506 Bartosz Golaszewski
3 siblings, 1 reply; 7+ messages in thread
From: Uwe Kleine-König @ 2021-01-15 16:46 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring, Andy Shevchenko
Cc: linux-gpio, kernel, devicetree
Some supported chips (e.g. pca9505) support 40 lines. To be able to give
each line a name the length of the gpio-line-names property must be
allowed to contain up to 40 entries.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index cdd7744b8723..246bae53be8b 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -71,7 +71,7 @@ properties:
gpio-line-names:
minItems: 1
- maxItems: 32
+ maxItems: 40
interrupts:
maxItems: 1
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: gpio: pca953x: Document new supported chip pca9506
2021-01-15 16:46 ` [PATCH v2 2/3] dt-bindings: gpio: pca953x: Document new supported chip pca9506 Uwe Kleine-König
@ 2021-01-18 15:17 ` Linus Walleij
0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-01-18 15:17 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Bartosz Golaszewski, Rob Herring, Andy Shevchenko,
open list:GPIO SUBSYSTEM, Sascha Hauer,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Fri, Jan 15, 2021 at 5:47 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> The previous patch added support for this chip. Add its name to the list
> of allowed compatibles.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: gpio: pca953x: Increase allowed length for gpio-line-names
2021-01-15 16:46 ` [PATCH v2 3/3] dt-bindings: gpio: pca953x: Increase allowed length for gpio-line-names Uwe Kleine-König
@ 2021-01-18 15:17 ` Linus Walleij
0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-01-18 15:17 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Bartosz Golaszewski, Rob Herring, Andy Shevchenko,
open list:GPIO SUBSYSTEM, Sascha Hauer,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Fri, Jan 15, 2021 at 5:47 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Some supported chips (e.g. pca9505) support 40 lines. To be able to give
> each line a name the length of the gpio-line-names property must be
> allowed to contain up to 40 entries.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/3] gpio: pca953x: Add support for pca9506
2021-01-15 16:46 [PATCH v2 0/3] gpio: pca953x: Add support for pca9506 Uwe Kleine-König
` (2 preceding siblings ...)
2021-01-15 16:46 ` [PATCH v2 3/3] dt-bindings: gpio: pca953x: Increase allowed length for gpio-line-names Uwe Kleine-König
@ 2021-01-19 12:45 ` Bartosz Golaszewski
3 siblings, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2021-01-19 12:45 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Linus Walleij, Rob Herring, Andy Shevchenko, linux-gpio,
Sascha Hauer, linux-devicetree
On Fri, Jan 15, 2021 at 5:47 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> Hello,
>
> compared to (implicit) v1 (Message-Id:
> 20210113194952.104734-1-u.kleine-koenig@pengutronix.de) I split the
> patch #1 into driver adaption and dt documenation (i.e. patches #1 and
> #2 here).
>
> For patch #3 I did s/chips/lines/ in the commit log and capitalized
> "Increase" in the summary line.
>
> Best regards
> Uwe
>
> Uwe Kleine-König (3):
> gpio: pca953x: Add support for pca9506
> dt-bindings: gpio: pca953x: Document new supported chip pca9506
> dt-bindings: gpio: pca953x: Increase allowed length for
> gpio-line-names
>
> Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 3 ++-
> drivers/gpio/gpio-pca953x.c | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
>
> base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e
> --
> 2.29.2
>
Applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-19 14:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 16:46 [PATCH v2 0/3] gpio: pca953x: Add support for pca9506 Uwe Kleine-König
2021-01-15 16:46 ` [PATCH v2 1/3] " Uwe Kleine-König
2021-01-15 16:46 ` [PATCH v2 2/3] dt-bindings: gpio: pca953x: Document new supported chip pca9506 Uwe Kleine-König
2021-01-18 15:17 ` Linus Walleij
2021-01-15 16:46 ` [PATCH v2 3/3] dt-bindings: gpio: pca953x: Increase allowed length for gpio-line-names Uwe Kleine-König
2021-01-18 15:17 ` Linus Walleij
2021-01-19 12:45 ` [PATCH v2 0/3] gpio: pca953x: Add support for pca9506 Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).