* [PATCH] arm64: dts: broadcom: bcm4908: describe PMB block
@ 2021-01-12 19:27 Rafał Miłecki
2021-01-13 4:49 ` Florian Fainelli
2021-01-13 11:15 ` [PATCH V2] " Rafał Miłecki
0 siblings, 2 replies; 4+ messages in thread
From: Rafał Miłecki @ 2021-01-12 19:27 UTC (permalink / raw)
To: Florian Fainelli
Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
devicetree, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
PMB (Power Management Bus) controls powering connected devices (e.g.
PCIe, USB, SATA). In BCM4908 it's a part of the PROCMON block.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
Florian: this patch is based on top of the
[PATCH] arm64: dts: broadcom: bcm4908: describe internal switch
one. Both modify "ranges".
---
.../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index 0b44f32fdef1..882953885bfc 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -108,7 +108,7 @@ soc {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
- ranges = <0x00 0x00 0x80000000 0xd0000>;
+ ranges = <0x00 0x00 0x80000000 0x281000>;
usb@c300 {
compatible = "generic-ehci";
@@ -213,6 +213,21 @@ phy12: phy@c {
};
};
};
+
+ procmon: syscon@280000 {
+ compatible = "simple-mfd";
+ reg = <0x280000 0x1000>;
+ ranges;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ power-controller@2800c0 {
+ compatible = "brcm,bcm4908-pmb";
+ reg = <0x2800c0 0x40>;
+ #power-domain-cells = <1>;
+ };
+ };
};
bus@ff800000 {
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: broadcom: bcm4908: describe PMB block
2021-01-12 19:27 [PATCH] arm64: dts: broadcom: bcm4908: describe PMB block Rafał Miłecki
@ 2021-01-13 4:49 ` Florian Fainelli
2021-01-13 11:15 ` [PATCH V2] " Rafał Miłecki
1 sibling, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-01-13 4:49 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli
Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
devicetree, Rafał Miłecki
On 1/12/2021 11:27 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> PMB (Power Management Bus) controls powering connected devices (e.g.
> PCIe, USB, SATA). In BCM4908 it's a part of the PROCMON block.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> Florian: this patch is based on top of the
> [PATCH] arm64: dts: broadcom: bcm4908: describe internal switch
> one. Both modify "ranges".
> ---
> .../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> index 0b44f32fdef1..882953885bfc 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> @@ -108,7 +108,7 @@ soc {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges = <0x00 0x00 0x80000000 0xd0000>;
> + ranges = <0x00 0x00 0x80000000 0x281000>;
>
> usb@c300 {
> compatible = "generic-ehci";
> @@ -213,6 +213,21 @@ phy12: phy@c {
> };
> };
> };
> +
> + procmon: syscon@280000 {
> + compatible = "simple-mfd";
Likewise, I would use "simple-bus" here instead of "simple-mfd" even if
this does not create a functional difference.
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH V2] arm64: dts: broadcom: bcm4908: describe PMB block
2021-01-12 19:27 [PATCH] arm64: dts: broadcom: bcm4908: describe PMB block Rafał Miłecki
2021-01-13 4:49 ` Florian Fainelli
@ 2021-01-13 11:15 ` Rafał Miłecki
2021-01-20 18:58 ` Florian Fainelli
1 sibling, 1 reply; 4+ messages in thread
From: Rafał Miłecki @ 2021-01-13 11:15 UTC (permalink / raw)
To: Florian Fainelli
Cc: bcm-kernel-feedback-list, Rob Herring, linux-arm-kernel,
devicetree, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
PMB (Power Management Bus) controls powering connected devices (e.g.
PCIe, USB, SATA). In BCM4908 it's a part of the PROCMON block.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
Florian: this patch is based on top of the
[PATCH] arm64: dts: broadcom: bcm4908: describe internal switch
one. Both modify "ranges".
V2: Use simple-bus
---
.../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index d30dd2042786..65e186da81d9 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -108,7 +108,7 @@ soc {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
- ranges = <0x00 0x00 0x80000000 0xd0000>;
+ ranges = <0x00 0x00 0x80000000 0x281000>;
usb@c300 {
compatible = "generic-ehci";
@@ -213,6 +213,21 @@ phy12: phy@c {
};
};
};
+
+ procmon: syscon@280000 {
+ compatible = "simple-bus";
+ reg = <0x280000 0x1000>;
+ ranges;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ power-controller@2800c0 {
+ compatible = "brcm,bcm4908-pmb";
+ reg = <0x2800c0 0x40>;
+ #power-domain-cells = <1>;
+ };
+ };
};
bus@ff800000 {
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V2] arm64: dts: broadcom: bcm4908: describe PMB block
2021-01-13 11:15 ` [PATCH V2] " Rafał Miłecki
@ 2021-01-20 18:58 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-01-20 18:58 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki
Cc: Rob Herring, linux-arm-kernel, devicetree, Rafał Miłecki
On Wed, 13 Jan 2021 12:15:47 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> PMB (Power Management Bus) controls powering connected devices (e.g.
> PCIe, USB, SATA). In BCM4908 it's a part of the PROCMON block.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to devicetree-arm64/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-20 19:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 19:27 [PATCH] arm64: dts: broadcom: bcm4908: describe PMB block Rafał Miłecki
2021-01-13 4:49 ` Florian Fainelli
2021-01-13 11:15 ` [PATCH V2] " Rafał Miłecki
2021-01-20 18:58 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).