* [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY
@ 2021-02-19 5:50 Rafał Miłecki
2021-02-19 5:50 ` [PATCH V2 2/5] arm64: dts: broadcom: bcm4908: describe Ethernet controller Rafał Miłecki
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Rafał Miłecki @ 2021-02-19 5:50 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM4908 uses slightly modified STB family USB PHY. It handles OHCI/EHCI
and XHCI. It requires powering up using the PMB.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../bcm4908/bcm4906-netgear-r8000p.dts | 17 +++++++++++++
.../bcm4908/bcm4908-asus-gt-ac5300.dts | 17 +++++++++++++
.../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 25 ++++++++++++++++---
3 files changed, 55 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
index ee3ed612274c..bf0d534ace2e 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
@@ -26,6 +26,23 @@ wps {
};
};
+&usb_phy {
+ brcm,ioc = <1>;
+ status = "okay";
+};
+
+&ehci {
+ status = "okay";
+};
+
+&ohci {
+ status = "okay";
+};
+
+&xhci {
+ status = "okay";
+};
+
&nandcs {
nand-ecc-strength = <4>;
nand-ecc-step-size = <512>;
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
index 6e4ad66ff536..bb06683d6acf 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
@@ -44,6 +44,23 @@ brightness {
};
};
+&usb_phy {
+ brcm,ioc = <1>;
+ status = "okay";
+};
+
+&ehci {
+ status = "okay";
+};
+
+&ohci {
+ status = "okay";
+};
+
+&xhci {
+ status = "okay";
+};
+
&ports {
port@0 {
label = "lan2";
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index 9354077f74cd..358958105337 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -2,6 +2,8 @@
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/phy/phy.h>
+#include <dt-bindings/soc/bcm-pmb.h>
/dts-v1/;
@@ -110,24 +112,39 @@ soc {
#size-cells = <1>;
ranges = <0x00 0x00 0x80000000 0x281000>;
- usb@c300 {
+ usb_phy: usb-phy@c200 {
+ compatible = "brcm,bcm4908-usb-phy";
+ reg = <0xc200 0x100>;
+ reg-names = "crtl";
+ power-domains = <&pmb BCM_PMB_HOST_USB>;
+ dr_mode = "host";
+ brcm,has-xhci;
+ brcm,has-eohci;
+ #phy-cells = <1>;
+ status = "disabled";
+ };
+
+ ehci: usb@c300 {
compatible = "generic-ehci";
reg = <0xc300 0x100>;
interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
+ phys = <&usb_phy PHY_TYPE_USB2>;
status = "disabled";
};
- usb@c400 {
+ ohci: usb@c400 {
compatible = "generic-ohci";
reg = <0xc400 0x100>;
interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
+ phys = <&usb_phy PHY_TYPE_USB2>;
status = "disabled";
};
- usb@d000 {
+ xhci: usb@d000 {
compatible = "generic-xhci";
reg = <0xd000 0x8c8>;
interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+ phys = <&usb_phy PHY_TYPE_USB3>;
status = "disabled";
};
@@ -222,7 +239,7 @@ procmon: syscon@280000 {
#address-cells = <1>;
#size-cells = <1>;
- power-controller@2800c0 {
+ pmb: power-controller@2800c0 {
compatible = "brcm,bcm4908-pmb";
reg = <0x2800c0 0x40>;
#power-domain-cells = <1>;
--
2.26.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 2/5] arm64: dts: broadcom: bcm4908: describe Ethernet controller
2021-02-19 5:50 [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY Rafał Miłecki
@ 2021-02-19 5:50 ` Rafał Miłecki
2021-03-08 22:11 ` Florian Fainelli
2021-02-19 5:50 ` [PATCH V2 3/5] arm64: dts: broadcom: bcm4908: describe Netgear R8000P switch Rafał Miłecki
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Rafał Miłecki @ 2021-02-19 5:50 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM4908 SoCs have an integrated Ethernet controller.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
V2: Drop redundant brcm,use-bcm-hdr
---
.../boot/dts/broadcom/bcm4908/bcm4908.dtsi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index 358958105337..bdbf94f3348a 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -112,6 +112,14 @@ soc {
#size-cells = <1>;
ranges = <0x00 0x00 0x80000000 0x281000>;
+ enet: ethernet@2000 {
+ compatible = "brcm,bcm4908-enet";
+ reg = <0x2000 0x1000>;
+
+ interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "rx";
+ };
+
usb_phy: usb-phy@c200 {
compatible = "brcm,bcm4908-usb-phy";
reg = <0xc200 0x100>;
@@ -199,6 +207,17 @@ port@3 {
phy-mode = "internal";
phy-handle = <&phy11>;
};
+
+ port@8 {
+ reg = <8>;
+ phy-mode = "internal";
+ ethernet = <&enet>;
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
};
};
--
2.26.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 3/5] arm64: dts: broadcom: bcm4908: describe Netgear R8000P switch
2021-02-19 5:50 [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY Rafał Miłecki
2021-02-19 5:50 ` [PATCH V2 2/5] arm64: dts: broadcom: bcm4908: describe Ethernet controller Rafał Miłecki
@ 2021-02-19 5:50 ` Rafał Miłecki
2021-03-08 22:12 ` Florian Fainelli
2021-02-19 5:50 ` [PATCH V2 4/5] arm64: dts: broadcom: bcm4908: add remaining Netgear R8000P LEDs Rafał Miłecki
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Rafał Miłecki @ 2021-02-19 5:50 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
R8000P model has 4 LAN ports and 1 WAN port.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../bcm4908/bcm4906-netgear-r8000p.dts | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
index bf0d534ace2e..af2616e82e83 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
@@ -43,6 +43,31 @@ &xhci {
status = "okay";
};
+&ports {
+ port@0 {
+ label = "lan4";
+ };
+
+ port@1 {
+ label = "lan3";
+ };
+
+ port@2 {
+ label = "lan2";
+ };
+
+ port@3 {
+ label = "lan1";
+ };
+
+ port@7 {
+ reg = <7>;
+ phy-mode = "internal";
+ phy-handle = <&phy12>;
+ label = "wan";
+ };
+};
+
&nandcs {
nand-ecc-strength = <4>;
nand-ecc-step-size = <512>;
--
2.26.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 4/5] arm64: dts: broadcom: bcm4908: add remaining Netgear R8000P LEDs
2021-02-19 5:50 [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY Rafał Miłecki
2021-02-19 5:50 ` [PATCH V2 2/5] arm64: dts: broadcom: bcm4908: describe Ethernet controller Rafał Miłecki
2021-02-19 5:50 ` [PATCH V2 3/5] arm64: dts: broadcom: bcm4908: describe Netgear R8000P switch Rafał Miłecki
@ 2021-02-19 5:50 ` Rafał Miłecki
2021-03-08 22:12 ` Florian Fainelli
2021-03-09 22:54 ` Florian Fainelli
2021-02-19 5:50 ` [PATCH V2 5/5] arm64: dts: broadcom: bcm4908: describe firmware partitions Rafał Miłecki
2021-03-08 22:11 ` [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY Florian Fainelli
4 siblings, 2 replies; 11+ messages in thread
From: Rafał Miłecki @ 2021-02-19 5:50 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
There are a few more GPIO connected LEDs there didn't get described
initially.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../bcm4908/bcm4906-netgear-r8000p.dts | 48 +++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
index af2616e82e83..0d02986c80ab 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
@@ -18,11 +18,59 @@ memory@0 {
leds {
compatible = "gpio-leds";
+ power-white {
+ function = LED_FUNCTION_POWER;
+ color = <LED_COLOR_ID_WHITE>;
+ gpios = <&gpio0 8 GPIO_ACTIVE_LOW>;
+ };
+
+ power-amber {
+ function = LED_FUNCTION_POWER;
+ color = <LED_COLOR_ID_AMBER>;
+ gpios = <&gpio0 9 GPIO_ACTIVE_LOW>;
+ };
+
wps {
function = LED_FUNCTION_WPS;
color = <LED_COLOR_ID_WHITE>;
gpios = <&gpio0 10 GPIO_ACTIVE_LOW>;
};
+
+ 2ghz {
+ function = "2ghz";
+ color = <LED_COLOR_ID_WHITE>;
+ gpios = <&gpio0 14 GPIO_ACTIVE_LOW>;
+ };
+
+ 5ghz-1 {
+ function = "5ghz-1";
+ color = <LED_COLOR_ID_WHITE>;
+ gpios = <&gpio0 15 GPIO_ACTIVE_LOW>;
+ };
+
+ 5ghz-2 {
+ function = "5ghz-2";
+ color = <LED_COLOR_ID_WHITE>;
+ gpios = <&gpio0 16 GPIO_ACTIVE_LOW>;
+ };
+
+ usb2 {
+ function = "usb2";
+ color = <LED_COLOR_ID_WHITE>;
+ gpios = <&gpio0 17 GPIO_ACTIVE_LOW>;
+ };
+
+ usb3 {
+ function = "usb3";
+ color = <LED_COLOR_ID_WHITE>;
+ gpios = <&gpio0 18 GPIO_ACTIVE_LOW>;
+ };
+
+ wifi {
+ function = "wifi";
+ color = <LED_COLOR_ID_WHITE>;
+ gpios = <&gpio0 56 GPIO_ACTIVE_LOW>;
+ };
};
};
--
2.26.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH V2 5/5] arm64: dts: broadcom: bcm4908: describe firmware partitions
2021-02-19 5:50 [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY Rafał Miłecki
` (2 preceding siblings ...)
2021-02-19 5:50 ` [PATCH V2 4/5] arm64: dts: broadcom: bcm4908: add remaining Netgear R8000P LEDs Rafał Miłecki
@ 2021-02-19 5:50 ` Rafał Miłecki
2021-03-08 22:12 ` Florian Fainelli
2021-03-08 22:11 ` [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY Florian Fainelli
4 siblings, 1 reply; 11+ messages in thread
From: Rafał Miłecki @ 2021-02-19 5:50 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM4908 bootloader supports multiple firmware partitions and has its own
bindings defined for them.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts | 1 +
.../dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts | 12 +++++++++++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
index 0d02986c80ab..7b24ad365a3c 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
@@ -135,6 +135,7 @@ partition@0 {
};
partition@100000 {
+ compatible = "brcm,bcm4908-firmware";
label = "firmware";
reg = <0x100000 0x4400000>;
};
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
index bb06683d6acf..7240a9ee9812 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
@@ -122,7 +122,7 @@ &nandcs {
#size-cells = <0>;
partitions {
- compatible = "fixed-partitions";
+ compatible = "brcm,bcm4908-partitions";
#address-cells = <1>;
#size-cells = <1>;
@@ -130,5 +130,15 @@ partition@0 {
label = "cferom";
reg = <0x0 0x100000>;
};
+
+ partition@100000 {
+ compatible = "brcm,bcm4908-firmware";
+ reg = <0x100000 0x5700000>;
+ };
+
+ partition@5800000 {
+ compatible = "brcm,bcm4908-firmware";
+ reg = <0x5800000 0x5700000>;
+ };
};
};
--
2.26.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY
2021-02-19 5:50 [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY Rafał Miłecki
` (3 preceding siblings ...)
2021-02-19 5:50 ` [PATCH V2 5/5] arm64: dts: broadcom: bcm4908: describe firmware partitions Rafał Miłecki
@ 2021-03-08 22:11 ` Florian Fainelli
4 siblings, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2021-03-08 22:11 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki
Cc: Rob Herring, linux-arm-kernel, devicetree, Rafał Miłecki
On Fri, 19 Feb 2021 06:50:26 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM4908 uses slightly modified STB family USB PHY. It handles OHCI/EHCI
> and XHCI. It requires powering up using the PMB.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to devicetree-arm64/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 2/5] arm64: dts: broadcom: bcm4908: describe Ethernet controller
2021-02-19 5:50 ` [PATCH V2 2/5] arm64: dts: broadcom: bcm4908: describe Ethernet controller Rafał Miłecki
@ 2021-03-08 22:11 ` Florian Fainelli
0 siblings, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2021-03-08 22:11 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki
Cc: Rob Herring, linux-arm-kernel, devicetree, Rafał Miłecki
On Fri, 19 Feb 2021 06:50:27 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM4908 SoCs have an integrated Ethernet controller.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to devicetree-arm64/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 3/5] arm64: dts: broadcom: bcm4908: describe Netgear R8000P switch
2021-02-19 5:50 ` [PATCH V2 3/5] arm64: dts: broadcom: bcm4908: describe Netgear R8000P switch Rafał Miłecki
@ 2021-03-08 22:12 ` Florian Fainelli
0 siblings, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2021-03-08 22:12 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki
Cc: Rob Herring, linux-arm-kernel, devicetree, Rafał Miłecki
On Fri, 19 Feb 2021 06:50:28 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> R8000P model has 4 LAN ports and 1 WAN port.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to devicetree-arm64/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 4/5] arm64: dts: broadcom: bcm4908: add remaining Netgear R8000P LEDs
2021-02-19 5:50 ` [PATCH V2 4/5] arm64: dts: broadcom: bcm4908: add remaining Netgear R8000P LEDs Rafał Miłecki
@ 2021-03-08 22:12 ` Florian Fainelli
2021-03-09 22:54 ` Florian Fainelli
1 sibling, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2021-03-08 22:12 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki
Cc: Rob Herring, linux-arm-kernel, devicetree, Rafał Miłecki
On Fri, 19 Feb 2021 06:50:29 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> There are a few more GPIO connected LEDs there didn't get described
> initially.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to devicetree-arm64/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 5/5] arm64: dts: broadcom: bcm4908: describe firmware partitions
2021-02-19 5:50 ` [PATCH V2 5/5] arm64: dts: broadcom: bcm4908: describe firmware partitions Rafał Miłecki
@ 2021-03-08 22:12 ` Florian Fainelli
0 siblings, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2021-03-08 22:12 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki
Cc: Rob Herring, linux-arm-kernel, devicetree, Rafał Miłecki
On Fri, 19 Feb 2021 06:50:30 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM4908 bootloader supports multiple firmware partitions and has its own
> bindings defined for them.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to devicetree-arm64/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 4/5] arm64: dts: broadcom: bcm4908: add remaining Netgear R8000P LEDs
2021-02-19 5:50 ` [PATCH V2 4/5] arm64: dts: broadcom: bcm4908: add remaining Netgear R8000P LEDs Rafał Miłecki
2021-03-08 22:12 ` Florian Fainelli
@ 2021-03-09 22:54 ` Florian Fainelli
1 sibling, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2021-03-09 22:54 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli
Cc: Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list, Rafał Miłecki
On 2/18/21 9:50 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> There are a few more GPIO connected LEDs there didn't get described
> initially.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bcm4908/bcm4906-netgear-r8000p.dts | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> index af2616e82e83..0d02986c80ab 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
Can you send me a fixup patch to fix the following warnings:
+arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dt.yaml:
leds: '2ghz', '5ghz-1', '5ghz-2' do not match any of the regexes:
'.*-names$', '.*-supply$', '^#.*-cells$', '^#[a-zA-Z0-9,+\\-._]{0,63}$',
'^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}$',
'^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+(,[0-9a-fA-F]+)*$',
'^__.*__$', 'pinctrl-[0-9]+'
+arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dt.yaml:
leds: '2ghz', '5ghz-1', '5ghz-2', 'power-amber', 'power-white', 'usb2',
'usb3', 'wifi', 'wps' do not match any of the regexes:
'(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
-arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dt.yaml:
leds: 'wps' does not match any of the regexes: '(^led-[0-9a-f]$|led)',
'pinctrl-[0-9]+'
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-03-09 22:55 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 5:50 [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY Rafał Miłecki
2021-02-19 5:50 ` [PATCH V2 2/5] arm64: dts: broadcom: bcm4908: describe Ethernet controller Rafał Miłecki
2021-03-08 22:11 ` Florian Fainelli
2021-02-19 5:50 ` [PATCH V2 3/5] arm64: dts: broadcom: bcm4908: describe Netgear R8000P switch Rafał Miłecki
2021-03-08 22:12 ` Florian Fainelli
2021-02-19 5:50 ` [PATCH V2 4/5] arm64: dts: broadcom: bcm4908: add remaining Netgear R8000P LEDs Rafał Miłecki
2021-03-08 22:12 ` Florian Fainelli
2021-03-09 22:54 ` Florian Fainelli
2021-02-19 5:50 ` [PATCH V2 5/5] arm64: dts: broadcom: bcm4908: describe firmware partitions Rafał Miłecki
2021-03-08 22:12 ` Florian Fainelli
2021-03-08 22:11 ` [PATCH V2 1/5] arm64: dts: broadcom: bcm4908: describe USB PHY Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).