From: Rob Herring <robh@kernel.org>
To: mgross@linux.intel.com
Cc: markgross@kernel.org, arnd@arndb.de, bp@suse.de,
damien.lemoal@wdc.com, dragan.cvetic@xilinx.com,
gregkh@linuxfoundation.org, corbet@lwn.net,
palmerdabbelt@google.com, paul.walmsley@sifive.com,
peng.fan@nxp.com, shawnguo@kernel.org, jassisinghbrar@gmail.com,
linux-kernel@vger.kernel.org,
Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 04/34] dt-bindings: Add bindings for Keem Bay IPC driver
Date: Fri, 5 Mar 2021 15:01:40 -0600 [thread overview]
Message-ID: <20210305210140.GA622142@robh.at.kernel.org> (raw)
In-Reply-To: <20210212222304.110194-5-mgross@linux.intel.com>
On Fri, Feb 12, 2021 at 02:22:34PM -0800, mgross@linux.intel.com wrote:
> From: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
>
> Add DT binding documentation for the Intel Keem Bay IPC driver, which
Bindings are for h/w blocks, not drivers. From a binding perspective, I
don't really care what the driver architecture for some OS looks like. I
continue to not understand what this h/w looks like. A block diagram
would help as would understanding what blocks have multiple clients
(mailboxes and xlink in particular).
> enables communication between the Computing Sub-System (CSS) and the
> Multimedia Sub-System (MSS) of the Intel Movidius SoC code named Keem
> Bay.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Reviewed-by: Mark Gross <mgross@linux.intel.com>
> Signed-off-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
> Signed-off-by: Mark Gross <mgross@linux.intel.com>
> ---
> .../bindings/soc/intel/intel,keembay-ipc.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/intel/intel,keembay-ipc.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/intel/intel,keembay-ipc.yaml b/Documentation/devicetree/bindings/soc/intel/intel,keembay-ipc.yaml
> new file mode 100644
> index 000000000000..586fe73f4cd4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/intel/intel,keembay-ipc.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2020 Intel Corporation
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/intel/intel,keembay-ipc.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Keem Bay IPC
> +
> +maintainers:
> + - Daniele Alessandrelli <daniele.alessandrelli@intel.com>
> +
> +description:
> + The Keem Bay IPC driver enables Inter-Processor Communication (IPC) with the
> + Visual Processor Unit (VPU) embedded in the Intel Movidius SoC code named
> + Keem Bay.
> +
> +properties:
> + compatible:
> + const: intel,keembay-ipc
> +
> + memory-region:
> + items:
> + - description:
> + Reserved memory region used by the CPU to allocate IPC packets.
> + - description:
> + Reserved memory region used by the VPU to allocate IPC packets.
> +
> + mboxes:
> + description: VPU IPC Mailbox.
> +
> +required:
> + - compatible
> + - memory-region
> + - mboxes
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + ipc {
> + compatible = "intel,keembay-ipc";
> + memory-region = <&ipc_cpu_reserved>, <&ipc_vpu_reserved>;
> + mboxes = <&vpu_ipc_mbox 0>;
> + };
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-03-05 21:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210212222304.110194-1-mgross@linux.intel.com>
2021-02-12 22:22 ` [PATCH v6 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox bindings mgross
2021-03-05 20:50 ` Rob Herring
2021-02-12 22:22 ` [PATCH v6 04/34] dt-bindings: Add bindings for Keem Bay IPC driver mgross
2021-03-05 21:01 ` Rob Herring [this message]
2021-03-08 20:20 ` mark gross
2021-04-12 21:24 ` Jassi Brar
2021-04-20 22:14 ` mark gross
2021-04-21 13:55 ` mark gross
2021-04-21 14:05 ` Jassi Brar
2021-04-21 15:29 ` Alessandrelli, Daniele
2021-02-12 22:22 ` [PATCH v6 06/34] dt-bindings: Add bindings for Keem Bay VPU " mgross
2021-02-12 22:22 ` [PATCH v6 17/34] xlink-ipc: Add xlink ipc device tree bindings mgross
2021-03-05 21:11 ` Rob Herring
2021-02-12 22:22 ` [PATCH v6 19/34] xlink-core: Add xlink core " mgross
2021-03-05 21:03 ` Rob Herring
2021-03-08 20:31 ` mark gross
2021-04-12 21:32 ` Dave Hansen
2021-04-20 22:08 ` Gross, Mark
2021-02-12 22:22 ` [PATCH v6 24/34] dt-bindings: misc: Add Keem Bay vpumgr mgross
2021-02-12 22:23 ` [PATCH v6 32/34] dt-bindings: misc: hddl_dev: Add hddl device management documentation mgross
2021-03-05 21:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305210140.GA622142@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=damien.lemoal@wdc.com \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mgross@linux.intel.com \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=peng.fan@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).