From: mark gross <mgross@linux.intel.com>
To: Rob Herring <robh@kernel.org>
Cc: mgross@linux.intel.com, markgross@kernel.org, arnd@arndb.de,
bp@suse.de, damien.lemoal@wdc.com, dragan.cvetic@xilinx.com,
gregkh@linuxfoundation.org, corbet@lwn.net,
palmerdabbelt@google.com, paul.walmsley@sifive.com,
peng.fan@nxp.com, shawnguo@kernel.org, jassisinghbrar@gmail.com,
linux-kernel@vger.kernel.org,
Seamus Kelly <seamus.kelly@intel.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 19/34] xlink-core: Add xlink core device tree bindings
Date: Mon, 8 Mar 2021 12:31:19 -0800 [thread overview]
Message-ID: <20210308203119.GB138795@linux.intel.com> (raw)
In-Reply-To: <20210305210300.GB622142@robh.at.kernel.org>
On Fri, Mar 05, 2021 at 03:03:00PM -0600, Rob Herring wrote:
> On Fri, Feb 12, 2021 at 02:22:49PM -0800, mgross@linux.intel.com wrote:
> > From: Seamus Kelly <seamus.kelly@intel.com>
> >
> > Add device tree bindings for keembay-xlink.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Reviewed-by: Mark Gross <mgross@linux.intel.com>
> > Signed-off-by: Mark Gross <mgross@linux.intel.com>
> > Signed-off-by: Seamus Kelly <seamus.kelly@intel.com>
> > ---
> > .../bindings/misc/intel,keembay-xlink.yaml | 29 +++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> > new file mode 100644
> > index 000000000000..5ac2e7fa5b5e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright (c) Intel Corporation. All rights reserved.
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Intel Keem Bay xlink
> > +
> > +maintainers:
> > + - Seamus Kelly <seamus.kelly@intel.com>
> > +
> > +description: |
> > + The Keem Bay xlink driver enables the communication/control sub-system
> > + for internal and external communications to the Intel Keem Bay SoC.
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - const: intel,keembay-xlink
> > +
> > +additionalProperties: False
> > +
> > +examples:
> > + - |
> > + xlink {
> > + compatible = "intel,keembay-xlink";
>
> A node with only a compatible is almost always abusing DT just to
> instantiate your driver.
Is it normal to make drivers that want to abuse DT in this way platform
devices?
Any advice would be welcome and helful.
thanks!
--mark
next prev parent reply other threads:[~2021-03-08 20:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210212222304.110194-1-mgross@linux.intel.com>
2021-02-12 22:22 ` [PATCH v6 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox bindings mgross
2021-03-05 20:50 ` Rob Herring
2021-02-12 22:22 ` [PATCH v6 04/34] dt-bindings: Add bindings for Keem Bay IPC driver mgross
2021-03-05 21:01 ` Rob Herring
2021-03-08 20:20 ` mark gross
2021-04-12 21:24 ` Jassi Brar
2021-04-20 22:14 ` mark gross
2021-04-21 13:55 ` mark gross
2021-04-21 14:05 ` Jassi Brar
2021-04-21 15:29 ` Alessandrelli, Daniele
2021-02-12 22:22 ` [PATCH v6 06/34] dt-bindings: Add bindings for Keem Bay VPU " mgross
2021-02-12 22:22 ` [PATCH v6 17/34] xlink-ipc: Add xlink ipc device tree bindings mgross
2021-03-05 21:11 ` Rob Herring
2021-02-12 22:22 ` [PATCH v6 19/34] xlink-core: Add xlink core " mgross
2021-03-05 21:03 ` Rob Herring
2021-03-08 20:31 ` mark gross [this message]
2021-04-12 21:32 ` Dave Hansen
2021-04-20 22:08 ` Gross, Mark
2021-02-12 22:22 ` [PATCH v6 24/34] dt-bindings: misc: Add Keem Bay vpumgr mgross
2021-02-12 22:23 ` [PATCH v6 32/34] dt-bindings: misc: hddl_dev: Add hddl device management documentation mgross
2021-03-05 21:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308203119.GB138795@linux.intel.com \
--to=mgross@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=damien.lemoal@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=seamus.kelly@intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).