devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: media: renesas,drif: Use graph schema
@ 2021-05-10 20:35 Rob Herring
  2021-05-11  8:51 ` Fabrizio Castro
  2021-05-17 21:18 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2021-05-10 20:35 UTC (permalink / raw)
  To: Fabrizio Castro, Laurent Pinchart
  Cc: devicetree, linux-kernel, Mauro Carvalho Chehab,
	Ramesh Shanmugasundaram, linux-media, linux-renesas-soc

Convert the renesas,drif binding schema to use the graph schema. The
binding referred to video-interfaces.txt, but it doesn't actually use any
properties from it as 'sync-active' is a custom property. As 'sync-active'
is custom, it needs a type definition.

Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Ramesh Shanmugasundaram <rashanmu@gmail.com>
Cc: linux-media@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/media/renesas,drif.yaml          | 20 +++++++------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml
index f1bdaeab4053..ce505a7c006a 100644
--- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
@@ -99,32 +99,26 @@ properties:
       Indicates that the channel acts as primary among the bonded channels.
 
   port:
-    type: object
+    $ref: /schemas/graph.yaml#/properties/port
+    unevaluatedProperties: false
     description:
-      Child port node corresponding to the data input, in accordance with the
-      video interface bindings defined in
-      Documentation/devicetree/bindings/media/video-interfaces.txt.
-      The port node must contain at least one endpoint.
+      Child port node corresponding to the data input. The port node must
+      contain at least one endpoint.
 
     properties:
       endpoint:
-        type: object
+        $ref: /schemas/graph.yaml#/$defs/endpoint-base
+        unevaluatedProperties: false
 
         properties:
-          remote-endpoint:
-            description:
-              A phandle to the remote tuner endpoint subnode in remote node
-              port.
-
           sync-active:
+            $ref: /schemas/types.yaml#/definitions/uint32
             enum: [0, 1]
             description:
               Indicates sync signal polarity, 0/1 for low/high respectively.
               This property maps to SYNCAC bit in the hardware manual. The
               default is 1 (active high).
 
-        additionalProperties: false
-
 required:
   - compatible
   - reg
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] dt-bindings: media: renesas,drif: Use graph schema
  2021-05-10 20:35 [PATCH] dt-bindings: media: renesas,drif: Use graph schema Rob Herring
@ 2021-05-11  8:51 ` Fabrizio Castro
  2021-05-17 21:18 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Fabrizio Castro @ 2021-05-11  8:51 UTC (permalink / raw)
  To: Rob Herring, Laurent Pinchart
  Cc: devicetree, linux-kernel, Mauro Carvalho Chehab,
	Ramesh Shanmugasundaram, linux-media, linux-renesas-soc

Hi Rob,

thank you for your patch.

> From: Rob Herring <robh@kernel.org>
> Sent: 10 May 2021 21:35
> Subject: [PATCH] dt-bindings: media: renesas,drif: Use graph schema
> 
> Convert the renesas,drif binding schema to use the graph schema. The
> binding referred to video-interfaces.txt, but it doesn't actually use any
> properties from it as 'sync-active' is a custom property. As 'sync-active'
> is custom, it needs a type definition.
> 
> Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Ramesh Shanmugasundaram <rashanmu@gmail.com>
> Cc: linux-media@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

Best regards,
Fab

> ---
>  .../bindings/media/renesas,drif.yaml          | 20 +++++++------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> index f1bdaeab4053..ce505a7c006a 100644
> --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> @@ -99,32 +99,26 @@ properties:
>        Indicates that the channel acts as primary among the bonded
> channels.
> 
>    port:
> -    type: object
> +    $ref: /schemas/graph.yaml#/properties/port
> +    unevaluatedProperties: false
>      description:
> -      Child port node corresponding to the data input, in accordance with
> the
> -      video interface bindings defined in
> -      Documentation/devicetree/bindings/media/video-interfaces.txt.
> -      The port node must contain at least one endpoint.
> +      Child port node corresponding to the data input. The port node must
> +      contain at least one endpoint.
> 
>      properties:
>        endpoint:
> -        type: object
> +        $ref: /schemas/graph.yaml#/$defs/endpoint-base
> +        unevaluatedProperties: false
> 
>          properties:
> -          remote-endpoint:
> -            description:
> -              A phandle to the remote tuner endpoint subnode in remote
> node
> -              port.
> -
>            sync-active:
> +            $ref: /schemas/types.yaml#/definitions/uint32
>              enum: [0, 1]
>              description:
>                Indicates sync signal polarity, 0/1 for low/high
> respectively.
>                This property maps to SYNCAC bit in the hardware manual.
> The
>                default is 1 (active high).
> 
> -        additionalProperties: false
> -
>  required:
>    - compatible
>    - reg
> --
> 2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: media: renesas,drif: Use graph schema
  2021-05-10 20:35 [PATCH] dt-bindings: media: renesas,drif: Use graph schema Rob Herring
  2021-05-11  8:51 ` Fabrizio Castro
@ 2021-05-17 21:18 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-05-17 21:18 UTC (permalink / raw)
  To: Rob Herring
  Cc: Laurent Pinchart, linux-renesas-soc, linux-kernel,
	Mauro Carvalho Chehab, Ramesh Shanmugasundaram, devicetree,
	Fabrizio Castro, linux-media

On Mon, 10 May 2021 15:35:14 -0500, Rob Herring wrote:
> Convert the renesas,drif binding schema to use the graph schema. The
> binding referred to video-interfaces.txt, but it doesn't actually use any
> properties from it as 'sync-active' is a custom property. As 'sync-active'
> is custom, it needs a type definition.
> 
> Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Ramesh Shanmugasundaram <rashanmu@gmail.com>
> Cc: linux-media@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/media/renesas,drif.yaml          | 20 +++++++------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-17 21:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 20:35 [PATCH] dt-bindings: media: renesas,drif: Use graph schema Rob Herring
2021-05-11  8:51 ` Fabrizio Castro
2021-05-17 21:18 ` Rob Herring

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox