From: Sean Anderson <sean.anderson@seco.com>
To: linux-clk@vger.kernel.org, Luca Ceresoli <luca@lucaceresoli.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Michael Turquette <mturquette@baylibre.com>,
Adam Ford <aford173@gmail.com>, Stephen Boyd <sboyd@kernel.org>,
Sean Anderson <sean.anderson@seco.com>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org
Subject: [PATCH v4 1/3] dt-bindings: clk: vc5: Add properties for configuring the SD/OE pin
Date: Thu, 1 Jul 2021 14:20:10 -0400 [thread overview]
Message-ID: <20210701182012.3421679-1-sean.anderson@seco.com> (raw)
These properties allow configuring the SD/OE pin as described in the
datasheet.
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---
Changes in v4:
- Specify that bindings should specify these properties, but don't make
any guarantees about the driver's behavior when they are not present.
- Clarify description of idt,(en|dis)able-shutdown properties.
- Make opposing properties mutually exclusive.
- Add these properties to the example.
Changes in v3:
- Add idt,disable-shutdown and idt,output-enable-active-low to allow for
a default of not changing the SP/SH bits at all.
Changes in v2:
- Rename idt,sd-active-high to idt,output-enable-active-high
- Add idt,enable-shutdown
.../bindings/clock/idt,versaclock5.yaml | 63 +++++++++++++++++++
1 file changed, 63 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
index 28675b0b80f1..2631a175612b 100644
--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
+++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
@@ -30,6 +30,21 @@ description: |
3 -- OUT3
4 -- OUT4
+ The idt,(en|dis)able-shutdown and idt,output-enable-active-(high|low)
+ properties control the SH (en_global_shutdown) and SP bits of the
+ Primary Source and Shutdown Register, respectively. Their behavior is
+ summarized by the following table:
+
+ SH SP Output when the SD/OE pin is Low/High
+ == == =====================================
+ 0 0 Active/Inactive
+ 0 1 Inactive/Active
+ 1 0 Active/Shutdown
+ 1 1 Inactive/Shutdown
+
+ One of idt,(en|dis)able-shutdown and one of
+ idt,output-enable-active-(high|low) should be specified.
+
maintainers:
- Luca Ceresoli <luca@lucaceresoli.net>
@@ -64,6 +79,34 @@ properties:
maximum: 22760
description: Optional load capacitor for XTAL1 and XTAL2
+ idt,enable-shutdown:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: |
+ Enable the shutdown functionality. The chip will be shut down if
+ the SD/OE pin is driven high. This corresponds to setting the SH
+ bit of the Primary Source and Shutdown Register.
+
+ idt,disable-shutdown:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: |
+ Disable the shutdown functionality. The chip will never be shut
+ down based on the value of the SD/OE pin. This corresponds to
+ clearing the SH bit of the Primary Source and Shutdown Register.
+
+ idt,output-enable-active-high:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: |
+ This enables output when the SD/OE pin is high, and disables
+ output when the SD/OE pin is low. This corresponds to setting the
+ SP bit of the Primary Source and Shutdown Register.
+
+ idt,output-enable-active-low:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: |
+ This disables output when the SD/OE pin is high, and enables
+ output when the SD/OE pin is low. This corresponds to clearing the
+ SP bit of the Primary Source and Shutdown Register.
+
patternProperties:
"^OUT[1-4]$":
type: object
@@ -109,6 +152,22 @@ allOf:
required:
- clock-names
- clocks
+ - if:
+ true
+ then:
+ oneOf:
+ - required:
+ - idt,enable-shutdown
+ - required:
+ - idt,disable-shutdown
+ - if:
+ true
+ then:
+ oneOf:
+ - required:
+ - idt,output-enable-active-high
+ - required:
+ - idt,output-enable-active-low
additionalProperties: false
@@ -138,6 +197,10 @@ examples:
clocks = <&ref25m>;
clock-names = "xin";
+ /* Set the SD/OE pin's settings */
+ idt,disable-shutdown;
+ idt,output-enable-active-low;
+
OUT1 {
idt,drive-mode = <VC5_CMOSD>;
idt,voltage-microvolts = <1800000>;
--
2.25.1
next reply other threads:[~2021-07-01 18:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 18:20 Sean Anderson [this message]
2021-07-02 7:14 ` [PATCH v4 1/3] dt-bindings: clk: vc5: Add properties for configuring the SD/OE pin Geert Uytterhoeven
2021-07-02 15:07 ` Sean Anderson
2021-07-02 15:18 ` Rob Herring
2021-07-02 21:15 ` Rob Herring
2021-07-15 15:04 ` Sean Anderson
2021-07-02 14:12 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210701182012.3421679-1-sean.anderson@seco.com \
--to=sean.anderson@seco.com \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-clk@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).