devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Anderson <sean.anderson@seco.com>
To: Rob Herring <robh@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	Luca Ceresoli <luca@lucaceresoli.net>,
	Michael Turquette <mturquette@baylibre.com>,
	Adam Ford <aford173@gmail.com>, Stephen Boyd <sboyd@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: clk: vc5: Add properties for configuring the SD/OE pin
Date: Thu, 15 Jul 2021 11:04:54 -0400	[thread overview]
Message-ID: <be1439d0-7dbd-3b79-f437-865dc2d91016@seco.com> (raw)
In-Reply-To: <CAL_Jsq+akWGskGUxLp38cMRgr5uXiRbdhuZwxYEkouQhWNyL2g@mail.gmail.com>



On 7/2/21 5:15 PM, Rob Herring wrote:
> On Fri, Jul 2, 2021 at 9:18 AM Rob Herring <robh@kernel.org> wrote:
>>
>> On Fri, Jul 02, 2021 at 11:07:57AM -0400, Sean Anderson wrote:
>> >
>> >
>> > On 7/2/21 3:14 AM, Geert Uytterhoeven wrote:
>> > > Hi Sean,
>> > >
>> > > On Thu, Jul 1, 2021 at 8:20 PM Sean Anderson <sean.anderson@seco.com> wrote:
>> > >> These properties allow configuring the SD/OE pin as described in the
>> > >> datasheet.
>> > >>
>> > >> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> > >> ---
>> > >>
>> > >> Changes in v4:
>> > >> - Specify that bindings should specify these properties, but don't make
>> > >>   any guarantees about the driver's behavior when they are not present.
>> > >> - Clarify description of idt,(en|dis)able-shutdown properties.
>> > >> - Make opposing properties mutually exclusive.
>> > >> - Add these properties to the example.
>> > >
>> > > Thanks for the update!
>> > >
>> > >> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>> > >> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>> > >
>> > >> @@ -109,6 +152,22 @@ allOf:
>> > >>        required:
>> > >>          - clock-names
>> > >>          - clocks
>> > >> +  - if:
>> > >> +      true
>> > >> +    then:
>> > >> +      oneOf:
>> > >> +        - required:
>> > >> +            - idt,enable-shutdown
>> > >> +        - required:
>> > >> +            - idt,disable-shutdown
>> > >> +  - if:
>> > >> +      true
>> > >> +    then:
>> > >> +      oneOf:
>> > >> +        - required:
>> > >> +            - idt,output-enable-active-high
>> > >> +        - required:
>> > >> +            - idt,output-enable-active-low
>> > >
>> > > Do you really need the "if: true then:"?
>> > > Just the "oneOf: ..." worked fine for me in another binding, but then I
>> > > didn't have a surrounding "allOf" to interfere...
>> >
>> > Yes. If you want to have multiple oneOfs, they have to go under an
>> > allOf. And allOf *only* allows if statements. This is a pretty big
>> > deficiency, IMO, but not something I can address here.
>>
>> Humm, we should relax that, not work around it.
> 
> I've now relaxed this restriction in dt-schema master.
> 
> Rob
> 
> P.S. I probably broke something because it's Friday afternoon before
> going on holiday for a week (so I'll do a tagged release when back).

Will you be doing a release? I'm waiting on that before I send v5.

--Sean

  reply	other threads:[~2021-07-15 15:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01 18:20 [PATCH v4 1/3] dt-bindings: clk: vc5: Add properties for configuring the SD/OE pin Sean Anderson
2021-07-02  7:14 ` Geert Uytterhoeven
2021-07-02 15:07   ` Sean Anderson
2021-07-02 15:18     ` Rob Herring
2021-07-02 21:15       ` Rob Herring
2021-07-15 15:04         ` Sean Anderson [this message]
2021-07-02 14:12 ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be1439d0-7dbd-3b79-f437-865dc2d91016@seco.com \
    --to=sean.anderson@seco.com \
    --cc=aford173@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=luca@lucaceresoli.net \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).