* [PATCH 1/2] ARM: dts: versatile: Fix up interrupt controller node names
@ 2021-06-17 21:08 Sudeep Holla
2021-06-17 21:08 ` [PATCH 2/2] ARM: dts: nomadik: " Sudeep Holla
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Sudeep Holla @ 2021-06-17 21:08 UTC (permalink / raw)
To: Linus Walleij; +Cc: Sudeep Holla, Rob Herring, devicetree
Once the new schema interrupt-controller/arm,vic.yaml is added, we get
the below warnings:
arch/arm/boot/dts/versatile-ab.dt.yaml:
intc@10140000: $nodename:0: 'intc@10140000' does not match
'^interrupt-controller(@[0-9a-f,]+)*$'
arch/arm/boot/dts/versatile-ab.dt.yaml:
intc@10140000: 'clear-mask' does not match any of the regexes
Fix the node names for the interrupt controller to conform
to the standard node name interrupt-controller@.. Also drop invalid
clear-mask property.
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/arm/boot/dts/versatile-ab.dts | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/versatile-ab.dts b/arch/arm/boot/dts/versatile-ab.dts
index 37bd41ff8dff..151c0220047d 100644
--- a/arch/arm/boot/dts/versatile-ab.dts
+++ b/arch/arm/boot/dts/versatile-ab.dts
@@ -195,16 +195,15 @@ amba {
#size-cells = <1>;
ranges;
- vic: intc@10140000 {
+ vic: interrupt-controller@10140000 {
compatible = "arm,versatile-vic";
interrupt-controller;
#interrupt-cells = <1>;
reg = <0x10140000 0x1000>;
- clear-mask = <0xffffffff>;
valid-mask = <0xffffffff>;
};
- sic: intc@10003000 {
+ sic: interrupt-controller@10003000 {
compatible = "arm,versatile-sic";
interrupt-controller;
#interrupt-cells = <1>;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: dts: nomadik: Fix up interrupt controller node names
2021-06-17 21:08 [PATCH 1/2] ARM: dts: versatile: Fix up interrupt controller node names Sudeep Holla
@ 2021-06-17 21:08 ` Sudeep Holla
2021-06-26 0:01 ` Linus Walleij
2021-06-26 0:00 ` [PATCH 1/2] ARM: dts: versatile: " Linus Walleij
2021-07-01 10:53 ` kernel test robot
2 siblings, 1 reply; 6+ messages in thread
From: Sudeep Holla @ 2021-06-17 21:08 UTC (permalink / raw)
To: Linus Walleij; +Cc: Sudeep Holla, Rob Herring, devicetree
Once the new schema interrupt-controller/arm,vic.yaml is added, we get
the below warnings:
arch/arm/boot/dts/ste-nomadik-nhk15.dt.yaml:
intc@10140000: $nodename:0: 'intc@10140000' does not match
'^interrupt-controller(@[0-9a-f,]+)*$'
Fix the node names for the interrupt controller to conform
to the standard node name interrupt-controller@..
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
index c9b906432341..1815361fe73c 100644
--- a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
+++ b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
@@ -755,14 +755,14 @@ clcd@10120000 {
status = "disabled";
};
- vica: intc@10140000 {
+ vica: interrupt-controller@10140000 {
compatible = "arm,versatile-vic";
interrupt-controller;
#interrupt-cells = <1>;
reg = <0x10140000 0x20>;
};
- vicb: intc@10140020 {
+ vicb: interrupt-controller@10140020 {
compatible = "arm,versatile-vic";
interrupt-controller;
#interrupt-cells = <1>;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] ARM: dts: nomadik: Fix up interrupt controller node names
2021-06-17 21:08 ` [PATCH 2/2] ARM: dts: nomadik: " Sudeep Holla
@ 2021-06-26 0:01 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2021-06-26 0:01 UTC (permalink / raw)
To: Sudeep Holla
Cc: Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Thu, Jun 17, 2021 at 11:08 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
> Once the new schema interrupt-controller/arm,vic.yaml is added, we get
> the below warnings:
>
> arch/arm/boot/dts/ste-nomadik-nhk15.dt.yaml:
> intc@10140000: $nodename:0: 'intc@10140000' does not match
> '^interrupt-controller(@[0-9a-f,]+)*$'
>
> Fix the node names for the interrupt controller to conform
> to the standard node name interrupt-controller@..
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Thanks Sudeep, I relayed this patch to the SoC tree!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: versatile: Fix up interrupt controller node names
2021-06-17 21:08 [PATCH 1/2] ARM: dts: versatile: Fix up interrupt controller node names Sudeep Holla
2021-06-17 21:08 ` [PATCH 2/2] ARM: dts: nomadik: " Sudeep Holla
@ 2021-06-26 0:00 ` Linus Walleij
2021-07-01 10:53 ` kernel test robot
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2021-06-26 0:00 UTC (permalink / raw)
To: Sudeep Holla
Cc: Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Thu, Jun 17, 2021 at 11:08 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
> Once the new schema interrupt-controller/arm,vic.yaml is added, we get
> the below warnings:
>
> arch/arm/boot/dts/versatile-ab.dt.yaml:
> intc@10140000: $nodename:0: 'intc@10140000' does not match
> '^interrupt-controller(@[0-9a-f,]+)*$'
>
> arch/arm/boot/dts/versatile-ab.dt.yaml:
> intc@10140000: 'clear-mask' does not match any of the regexes
>
> Fix the node names for the interrupt controller to conform
> to the standard node name interrupt-controller@.. Also drop invalid
> clear-mask property.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Thanks Sudeep, I relayed the patch to the SoC tree!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ARM: dts: versatile: Fix up interrupt controller node names
2021-06-17 21:08 [PATCH 1/2] ARM: dts: versatile: Fix up interrupt controller node names Sudeep Holla
2021-06-17 21:08 ` [PATCH 2/2] ARM: dts: nomadik: " Sudeep Holla
2021-06-26 0:00 ` [PATCH 1/2] ARM: dts: versatile: " Linus Walleij
@ 2021-07-01 10:53 ` kernel test robot
2021-07-01 13:05 ` Sudeep Holla
2 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2021-07-01 10:53 UTC (permalink / raw)
To: Sudeep Holla, Linus Walleij
Cc: kbuild-all, Sudeep Holla, Rob Herring, devicetree
[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]
Hi Sudeep,
I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on pinctrl/devel v5.13 next-20210630]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sudeep-Holla/ARM-dts-versatile-Fix-up-interrupt-controller-node-names/20210618-050956
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/39c2a1b84ddd856b2a8015abc7952b9ca79a5c4c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sudeep-Holla/ARM-dts-versatile-Fix-up-interrupt-controller-node-names/20210618-050956
git checkout 39c2a1b84ddd856b2a8015abc7952b9ca79a5c4c
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/arm/boot/dts/versatile-pb.dts:10.22-17.5: ERROR (duplicate_label): /amba/intc@10003000: Duplicate label 'sic' on /amba/intc@10003000 and /amba/interrupt-controller@10003000
>> ERROR: Input tree has errors, aborting (use -f to force output)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 79104 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] ARM: dts: versatile: Fix up interrupt controller node names
2021-07-01 10:53 ` kernel test robot
@ 2021-07-01 13:05 ` Sudeep Holla
0 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2021-07-01 13:05 UTC (permalink / raw)
To: Linus Walleij
Cc: kernel test robot, kbuild-all, Sudeep Holla, Rob Herring, devicetree
Hi Linus,
Sorry for this. For some reason I had assumed versatile is in
multi_v5_defconfig, but it is not and I missed to see that.
I will post v2 to SoC team directly with your ack instead.
On Thu, Jul 01, 2021 at 06:53:53PM +0800, kernel test robot wrote:
> Hi Sudeep,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on robh/for-next]
> [also build test ERROR on pinctrl/devel v5.13 next-20210630]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Sudeep-Holla/ARM-dts-versatile-Fix-up-interrupt-controller-node-names/20210618-050956
> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/39c2a1b84ddd856b2a8015abc7952b9ca79a5c4c
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Sudeep-Holla/ARM-dts-versatile-Fix-up-interrupt-controller-node-names/20210618-050956
> git checkout 39c2a1b84ddd856b2a8015abc7952b9ca79a5c4c
> # save the attached .config to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> arch/arm/boot/dts/versatile-pb.dts:10.22-17.5: ERROR (duplicate_label): /amba/intc@10003000: Duplicate label 'sic' on /amba/intc@10003000 and /amba/interrupt-controller@10003000
> >> ERROR: Input tree has errors, aborting (use -f to force output)
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-01 13:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 21:08 [PATCH 1/2] ARM: dts: versatile: Fix up interrupt controller node names Sudeep Holla
2021-06-17 21:08 ` [PATCH 2/2] ARM: dts: nomadik: " Sudeep Holla
2021-06-26 0:01 ` Linus Walleij
2021-06-26 0:00 ` [PATCH 1/2] ARM: dts: versatile: " Linus Walleij
2021-07-01 10:53 ` kernel test robot
2021-07-01 13:05 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).