* [PATCH 4/5 v2] pata: ixp4xx: Add DT bindings
[not found] <20210731213555.2965356-1-linus.walleij@linaro.org>
@ 2021-07-31 21:35 ` Linus Walleij
2021-08-02 13:39 ` Rob Herring
2021-08-02 16:30 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2021-07-31 21:35 UTC (permalink / raw)
To: Jens Axboe, linux-ide
Cc: linux-arm-kernel, Imre Kaloz, Krzysztof Halasa, Linus Walleij,
devicetree
This adds device tree bindings for the Intel IXP4xx compact flash card
interface.
Cc: devicetree@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- Itemize the registers
- Drop the epansion bus set-up to alleviate warnings
---
.../ata/intel,ixp4xx-compact-flash.yaml | 61 +++++++++++++++++++
1 file changed, 61 insertions(+)
create mode 100644 Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml
diff --git a/Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml b/Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml
new file mode 100644
index 000000000000..52e18600ecff
--- /dev/null
+++ b/Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ata/intel,ixp4xx-compact-flash.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Intel IXP4xx CompactFlash Card Controller
+
+maintainers:
+ - Linus Walleij <linus.walleij@linaro.org>
+
+description: |
+ The IXP4xx network processors have a CompactFlash interface that presents
+ a CompactFlash card to the system as a true IDE (parallel ATA) device. The
+ device is always connected to the expansion bus of the IXP4xx SoCs using one
+ or two chip select areas and address translating logic on the board. The
+ node must be placed inside a chip select node on the IXP4xx expansion bus.
+
+properties:
+ compatible:
+ const: intel,ixp4xx-compact-flash
+
+ reg:
+ items:
+ - description: Command interface registers
+ - description: Control interface registers
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+allOf:
+ - $ref: pata-common.yaml#
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ bus@c4000000 {
+ compatible = "intel,ixp43x-expansion-bus-controller", "syscon";
+ reg = <0xc4000000 0x1000>;
+ native-endian;
+ #address-cells = <2>;
+ #size-cells = <1>;
+ ranges = <0 0x0 0x50000000 0x01000000>, <1 0x0 0x51000000 0x01000000>;
+ dma-ranges = <0 0x0 0x50000000 0x01000000>, <1 0x0 0x51000000 0x01000000>;
+ ide@1,0 {
+ compatible = "intel,ixp4xx-compact-flash";
+ reg = <1 0x00000000 0x1000>, <1 0x00040000 0x1000>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <12 IRQ_TYPE_EDGE_RISING>;
+ };
+ };
+
+...
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 4/5 v2] pata: ixp4xx: Add DT bindings
2021-07-31 21:35 ` [PATCH 4/5 v2] pata: ixp4xx: Add DT bindings Linus Walleij
@ 2021-08-02 13:39 ` Rob Herring
2021-08-02 16:30 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-08-02 13:39 UTC (permalink / raw)
To: Linus Walleij
Cc: Jens Axboe, Krzysztof Halasa, linux-arm-kernel, devicetree,
Imre Kaloz, linux-ide
On Sat, 31 Jul 2021 23:35:54 +0200, Linus Walleij wrote:
> This adds device tree bindings for the Intel IXP4xx compact flash card
> interface.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Itemize the registers
> - Drop the epansion bus set-up to alleviate warnings
> ---
> .../ata/intel,ixp4xx-compact-flash.yaml | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.example.dt.yaml:0:0: /example-0/bus@c4000000: failed to match any schema with compatible: ['intel,ixp43x-expansion-bus-controller', 'syscon']
\ndoc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1511976
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 4/5 v2] pata: ixp4xx: Add DT bindings
2021-07-31 21:35 ` [PATCH 4/5 v2] pata: ixp4xx: Add DT bindings Linus Walleij
2021-08-02 13:39 ` Rob Herring
@ 2021-08-02 16:30 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-08-02 16:30 UTC (permalink / raw)
To: Linus Walleij
Cc: Jens Axboe,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
linux-arm-kernel, Imre Kaloz, Krzysztof Halasa, devicetree
On Sat, Jul 31, 2021 at 3:38 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> This adds device tree bindings for the Intel IXP4xx compact flash card
> interface.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Itemize the registers
> - Drop the epansion bus set-up to alleviate warnings
> ---
> .../ata/intel,ixp4xx-compact-flash.yaml | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml
I'll assume this passes with the
'intel,ixp43x-expansion-bus-controller' schema present.
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-02 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210731213555.2965356-1-linus.walleij@linaro.org>
2021-07-31 21:35 ` [PATCH 4/5 v2] pata: ixp4xx: Add DT bindings Linus Walleij
2021-08-02 13:39 ` Rob Herring
2021-08-02 16:30 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).