Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support

* Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support
       [not found] <20210914193732.3047668-1-danct12@disroot.org>
@ 2021-09-14 20:26 ` Jernej Škrabec
       [not found]   ` <4816863.IXWdtHWlKd@melttower>
  2021-09-16 13:52 ` Maxime Ripard
  1 sibling, 1 reply; 3+ messages in thread
From: Jernej Škrabec @ 2021-09-14 20:26 UTC (permalink / raw)
  To: Dang Huynh
  Cc: danct12, Rob Herring, Maxime Ripard, Chen-Yu Tsai, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

Hi!

Dne torek, 14. september 2021 ob 21:37:32 CEST je Dang Huynh napisal(a):
> This patch enables HDMI display on PINE64 PineTab.
> 
> The PineTab has a HDMI Type C (mini) port.
> 
> Signed-off-by: Dang Huynh <danct12@disroot.org>
> ---
>  .../boot/dts/allwinner/sun50i-a64-pinetab.dts | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts b/arch/
arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> index 6a4af14718f5..adb0b28b06d8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
> @@ -35,6 +35,17 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	hdmi-connector {
> +		compatible = "hdmi-connector";
> +		type = "c";
> +
> +		port {
> +			hdmi_con_in: endpoint {
> +				remote-endpoint = <&hdmi_out_con>;
> +			};
> +		};
> +	};
> +
>  	i2c-csi {
>  		compatible = "i2c-gpio";
>  		sda-gpios = <&pio 4 13 GPIO_ACTIVE_HIGH>; /* PE13 */
> @@ -410,6 +421,21 @@ &reg_rtc_ldo {
>  	regulator-name = "vcc-rtc";
>  };
>  
> +&simplefb_hdmi {
> +	vcc-hdmi-supply = <&reg_dldo1>;

You have to set status to okay here.

With that fixed, you can add:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> +};
> +
> +&hdmi {
> +	hvcc-supply = <&reg_dldo1>;
> +	status = "okay";
> +};
> +
> +&hdmi_out {
> +	hdmi_out_con: endpoint {
> +		remote-endpoint = <&hdmi_con_in>;
> +	};
> +};
> +
>  &sound {
>  	status = "okay";
>  	simple-audio-card,aux-devs = <&codec_analog>, <&speaker_amp>;
> -- 
> 2.33.0
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread