devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND v2 1/4] dt-bindings: bluetooth: broadcom: Fix clocks check
@ 2021-09-24  7:27 Maxime Ripard
  2021-09-24  7:27 ` [RESEND v2 2/4] dt-bindings: bluetooth: realtek: Add missing max-speed Maxime Ripard
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Maxime Ripard @ 2021-09-24  7:27 UTC (permalink / raw)
  To: Chen-Yu Tsai, Maxime Ripard, Jernej Škrabec, Rob Herring,
	Frank Rowand
  Cc: linux-arm-kernel, devicetree, linux-sunxi, David S. Miller,
	Jakub Kicinski, netdev, Linus Walleij, Rob Herring

The original binding was mentioning that valid values for the clocks and
clock-names property were one or two clocks from extclk, txco and lpo,
with extclk being deprecated in favor of txco.

However, the current binding lists a valid array as extclk, txco and
lpo, with either one or two items.

While this looks similar, it actually enforces that all the device trees
use either ["extclk"], or ["extclk", "txco"]. That doesn't make much
sense, since the two clocks are said to be equivalent, with one
superseeding the other.

lpo is also not a valid clock anymore, and would be as the third clock
of the list, while we could have only this clock in the previous binding
(and in DTs).

Let's rework the clock clause to allow to have either:

 - extclk, and mark it a deprecated
 - txco alone
 - lpo alone
 - txco, lpo

While ["extclk", "lpo"] wouldn't be valid, it wasn't found in any device
tree so it's not an issue in practice.

Similarly, ["lpo", "txco"] is still considered invalid, but it's
generally considered as a best practice to fix the order of clocks.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 .../bindings/net/broadcom-bluetooth.yaml        | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
index fbdc2083bec4..5aac094fd217 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
@@ -50,16 +50,29 @@ properties:
       by interrupts and "host-wakeup" interrupt-names
 
   clocks:
+    minItems: 1
     maxItems: 2
     description: 1 or 2 clocks as defined in clock-names below,
       in that order
 
   clock-names:
     description: Names of the 1 to 2 supplied clocks
-    items:
+    oneOf:
+      - const: extclk
+        deprecated: true
+        description: Deprecated in favor of txco
+
       - const: txco
+        description: >
+          external reference clock (not a standalone crystal)
+
       - const: lpo
-      - const: extclk
+        description: >
+          external low power 32.768 kHz clock
+
+      - items:
+          - const: txco
+          - const: lpo
 
   vbat-supply:
     description: phandle to regulator supply for VBAT
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-12 14:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24  7:27 [RESEND v2 1/4] dt-bindings: bluetooth: broadcom: Fix clocks check Maxime Ripard
2021-09-24  7:27 ` [RESEND v2 2/4] dt-bindings: bluetooth: realtek: Add missing max-speed Maxime Ripard
2021-09-24  7:27 ` [RESEND v2 3/4] dt-bindings: net: dwmac: Fix typo in the R40 compatible Maxime Ripard
2021-09-24  7:27 ` [RESEND v2 4/4] dt-bindings: net: wireless: Convert ESP ESP8089 binding to a schema Maxime Ripard
2021-10-12 14:08 ` [RESEND v2 1/4] dt-bindings: bluetooth: broadcom: Fix clocks check Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).