devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] dt-bindings: net: Reintroduce PHY no lane swap binding
@ 2021-11-30  8:27 Alexander Stein
  2021-11-30 13:54 ` Andrew Lunn
  2021-12-06 20:15 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2021-11-30  8:27 UTC (permalink / raw)
  To: Andrew Lunn, Heiner Kallweit, Russell King, David S . Miller,
	Rob Herring, Jakub Kicinski
  Cc: Alexander Stein, devicetree

This binding was already documented in phy.txt, commit 252ae5330daa
("Documentation: devicetree: Add PHY no lane swap binding"), but got
accidently removed during YAML conversion in commit d8704342c109
("dt-bindings: net: Add a YAML schemas for the generic PHY options").

Note: 'enet-phy-lane-no-swap' and the absence of 'enet-phy-lane-swap' are
not identical, as the former one disable this feature, while the latter
one doesn't change anything.

Fixes: d8704342c109 ("dt-bindings: net: Add a YAML schemas for the generic PHY options")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/net/ethernet-phy.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
index 2766fe45bb98..ee42328a109d 100644
--- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
@@ -91,6 +91,14 @@ properties:
       compensate for the board being designed with the lanes
       swapped.
 
+  enet-phy-lane-no-swap:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      If set, indicates that PHY will disable swap of the
+      TX/RX lanes. This property allows the PHY to work correcly after
+      e.g. wrong bootstrap configuration caused by issues in PCB
+      layout design.
+
   eee-broken-100tx:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] dt-bindings: net: Reintroduce PHY no lane swap binding
  2021-11-30  8:27 [PATCH 1/1] dt-bindings: net: Reintroduce PHY no lane swap binding Alexander Stein
@ 2021-11-30 13:54 ` Andrew Lunn
  2021-12-06 20:15 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2021-11-30 13:54 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Heiner Kallweit, Russell King, David S . Miller, Rob Herring,
	Jakub Kicinski, devicetree

On Tue, Nov 30, 2021 at 09:27:56AM +0100, Alexander Stein wrote:
> This binding was already documented in phy.txt, commit 252ae5330daa
> ("Documentation: devicetree: Add PHY no lane swap binding"), but got
> accidently removed during YAML conversion in commit d8704342c109
> ("dt-bindings: net: Add a YAML schemas for the generic PHY options").
> 
> Note: 'enet-phy-lane-no-swap' and the absence of 'enet-phy-lane-swap' are
> not identical, as the former one disable this feature, while the latter
> one doesn't change anything.
> 
> Fixes: d8704342c109 ("dt-bindings: net: Add a YAML schemas for the generic PHY options")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] dt-bindings: net: Reintroduce PHY no lane swap binding
  2021-11-30  8:27 [PATCH 1/1] dt-bindings: net: Reintroduce PHY no lane swap binding Alexander Stein
  2021-11-30 13:54 ` Andrew Lunn
@ 2021-12-06 20:15 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-06 20:15 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Jakub Kicinski, devicetree, Heiner Kallweit, Russell King,
	David S . Miller, Andrew Lunn, Rob Herring

On Tue, 30 Nov 2021 09:27:56 +0100, Alexander Stein wrote:
> This binding was already documented in phy.txt, commit 252ae5330daa
> ("Documentation: devicetree: Add PHY no lane swap binding"), but got
> accidently removed during YAML conversion in commit d8704342c109
> ("dt-bindings: net: Add a YAML schemas for the generic PHY options").
> 
> Note: 'enet-phy-lane-no-swap' and the absence of 'enet-phy-lane-swap' are
> not identical, as the former one disable this feature, while the latter
> one doesn't change anything.
> 
> Fixes: d8704342c109 ("dt-bindings: net: Add a YAML schemas for the generic PHY options")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/net/ethernet-phy.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-06 20:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30  8:27 [PATCH 1/1] dt-bindings: net: Reintroduce PHY no lane swap binding Alexander Stein
2021-11-30 13:54 ` Andrew Lunn
2021-12-06 20:15 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).