From: Maxime Ripard <maxime@cerno.tech>
To: nicolas saenz julienne <nsaenz@kernel.org>
Cc: Scott Branden <sbranden@broadcom.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-rpi-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dom Cobley <dom@raspberrypi.com>,
devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline
Date: Fri, 3 Dec 2021 14:50:23 +0100 [thread overview]
Message-ID: <20211203135023.sbj4uxwsaoeakfjj@houat> (raw)
In-Reply-To: <cad0e66b5cb88f224bbbe54e7ed8552275864733.camel@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]
Hi Nicolas,
On Tue, Nov 30, 2021 at 12:45:49PM +0100, nicolas saenz julienne wrote:
> On Wed, 2021-11-17 at 15:50 +0100, Maxime Ripard wrote:
> > The VC4 driver has had limited support to disable the HDMI controllers and
> > pixelvalves at boot if the firmware has enabled them.
> >
> > However, this proved to be limited, and a bit unreliable so a new firmware
> > command has been introduced some time ago to make it free all its resources and
> > disable any display output it might have enabled.
> >
> > This series takes advantage of that command to call it once the transition from
> > simplefb to the KMS driver has been done.
>
> I think it would make sense to integrate this funtionality into
> 'reset/reset-raspberrypi.c' and pass it to VC4 as a reset controller. It fits
> the same startup situation as the one we have with the USB controller. Also, it
> would contain the firmware weirdness in a single spot.
I don't really think it makes sense. It's not really made for that
purpose, affects multiple devices (basically, all of the devices from
the display pipeline), and can even have some side effects on clocks and
memory. Plus, it can only be done once iirc, so a later call to reset
the pipeline will be ineffective, even if we changed its state.
So yeah, it doesn't really fit into the reset abstraction.
> Otherwise, please use 'devm_rpi_firmware_get()'.
Will do, thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2021-12-03 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:50 [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline Maxime Ripard
2021-11-17 14:50 ` [PATCH 1/5] dt-bindings: display: vc4: Add optional phandle to firmware Maxime Ripard
2021-11-29 22:49 ` Rob Herring
2021-11-17 14:50 ` [PATCH 2/5] firmware: raspberrypi: Add RPI_FIRMWARE_NOTIFY_DISPLAY_DONE Maxime Ripard
2021-11-17 14:50 ` [PATCH 3/5] drm/vc4: Remove conflicting framebuffers before callind bind_all Maxime Ripard
2021-11-17 14:50 ` [PATCH 4/5] drm/vc4: Notify the firmware when DRM is in charge Maxime Ripard
2021-11-17 14:50 ` [PATCH 5/5] ARM: dts: rpi: Add the firmware node to vc4 Maxime Ripard
2021-11-30 11:45 ` [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline nicolas saenz julienne
2021-12-03 13:50 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203135023.sbj4uxwsaoeakfjj@houat \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).