* [PATCH 0/2] Enable Thermal support for RZ/G2L
@ 2021-12-08 14:27 Biju Das
2021-12-08 14:27 ` [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add TSU node Biju Das
2021-12-08 14:27 ` [PATCH 2/2] arm64: dts: renesas: r9a07g044: Create thermal zone to support IPA Biju Das
0 siblings, 2 replies; 5+ messages in thread
From: Biju Das @ 2021-12-08 14:27 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
devicetree, Chris Paterson, Biju Das, Prabhakar Mahadev Lad
This patch series aims to enable TSU support for RZ/G2L.
it depend upon [1] and [2]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20211208&id=9460347192add5644236d492f79ecab6d83504d4
[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20211208&id=673c68bd48390dad01f7d17670de3e33b60860ac
Biju Das (2):
arm64: dts: renesas: r9a07g044: Add TSU node
arm64: dts: renesas: r9a07g044: Create thermal zone to support IPA
arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 42 ++++++++++++++++++++++
1 file changed, 42 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add TSU node
2021-12-08 14:27 [PATCH 0/2] Enable Thermal support for RZ/G2L Biju Das
@ 2021-12-08 14:27 ` Biju Das
2021-12-14 11:11 ` Geert Uytterhoeven
2021-12-08 14:27 ` [PATCH 2/2] arm64: dts: renesas: r9a07g044: Create thermal zone to support IPA Biju Das
1 sibling, 1 reply; 5+ messages in thread
From: Biju Das @ 2021-12-08 14:27 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
devicetree, Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Add TSU node to RZ/G2L SoC DTSI.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 26 ++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
index 439870930fb3..ea528580f306 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
@@ -539,6 +539,16 @@
};
};
+ tsu: thermal@10059400 {
+ compatible = "renesas,r9a07g044-tsu",
+ "renesas,rzg2l-tsu";
+ reg = <0 0x10059400 0 0x400>;
+ clocks = <&cpg CPG_MOD R9A07G044_TSU_PCLK>;
+ resets = <&cpg R9A07G044_TSU_PRESETN>;
+ power-domains = <&cpg>;
+ #thermal-sensor-cells = <1>;
+ };
+
sbc: spi@10060000 {
compatible = "renesas,r9a07g044-rpc-if",
"renesas,rzg2l-rpc-if";
@@ -902,6 +912,22 @@
};
};
+ thermal-zones {
+ cpu-thermal {
+ polling-delay-passive = <250>;
+ polling-delay = <1000>;
+ thermal-sensors = <&tsu 0>;
+
+ trips {
+ sensor_crit: sensor-crit {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "critical";
+ };
+ };
+ };
+ };
+
timer {
compatible = "arm,armv8-timer";
interrupts-extended = <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: r9a07g044: Create thermal zone to support IPA
2021-12-08 14:27 [PATCH 0/2] Enable Thermal support for RZ/G2L Biju Das
2021-12-08 14:27 ` [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add TSU node Biju Das
@ 2021-12-08 14:27 ` Biju Das
2021-12-14 11:13 ` Geert Uytterhoeven
1 sibling, 1 reply; 5+ messages in thread
From: Biju Das @ 2021-12-08 14:27 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
devicetree, Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Setup a thermal zone driven by SoC temperature sensor.
Create passive trip points and bind them to CPUFreq cooling
device that supports power extension.
Based on the work done by Dien Pham <dien.pham.ry@renesas.com>
and others for r8a77990 SoC.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
index ea528580f306..2639fd383010 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
@@ -88,6 +88,7 @@
compatible = "arm,cortex-a55";
reg = <0>;
device_type = "cpu";
+ #cooling-cells = <2>;
next-level-cache = <&L3_CA55>;
enable-method = "psci";
clocks = <&cpg CPG_CORE R9A07G044_CLK_I>;
@@ -917,6 +918,15 @@
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsu 0>;
+ sustainable-power = <717>;
+
+ cooling-maps {
+ map0 {
+ trip = <&target>;
+ cooling-device = <&cpu0 0 2>;
+ contribution = <1024>;
+ };
+ };
trips {
sensor_crit: sensor-crit {
@@ -924,6 +934,12 @@
hysteresis = <1000>;
type = "critical";
};
+
+ target: trip-point {
+ temperature = <100000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
};
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add TSU node
2021-12-08 14:27 ` [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add TSU node Biju Das
@ 2021-12-14 11:11 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2021-12-14 11:11 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Magnus Damm, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad,
Niklas Söderlund
Hi Biju,
On Wed, Dec 8, 2021 at 3:27 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add TSU node to RZ/G2L SoC DTSI.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> @@ -539,6 +539,16 @@
> };
> };
>
> + tsu: thermal@10059400 {
> + compatible = "renesas,r9a07g044-tsu",
> + "renesas,rzg2l-tsu";
> + reg = <0 0x10059400 0 0x400>;
> + clocks = <&cpg CPG_MOD R9A07G044_TSU_PCLK>;
> + resets = <&cpg R9A07G044_TSU_PRESETN>;
> + power-domains = <&cpg>;
> + #thermal-sensor-cells = <1>;
> + };
> +
OK.
> sbc: spi@10060000 {
> compatible = "renesas,r9a07g044-rpc-if",
> "renesas,rzg2l-rpc-if";
> @@ -902,6 +912,22 @@
> };
> };
>
> + thermal-zones {
> + cpu-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> + thermal-sensors = <&tsu 0>;
> +
> + trips {
> + sensor_crit: sensor-crit {
> + temperature = <125000>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> + };
> +
LGTM (I'm no thermal expert, so an additional pair of eyes wouldn't hurt), so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.17.
> timer {
> compatible = "arm,armv8-timer";
> interrupts-extended = <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: r9a07g044: Create thermal zone to support IPA
2021-12-08 14:27 ` [PATCH 2/2] arm64: dts: renesas: r9a07g044: Create thermal zone to support IPA Biju Das
@ 2021-12-14 11:13 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2021-12-14 11:13 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Magnus Damm, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad,
Niklas Söderlund
On Wed, Dec 8, 2021 at 3:27 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Setup a thermal zone driven by SoC temperature sensor.
> Create passive trip points and bind them to CPUFreq cooling
> device that supports power extension.
>
> Based on the work done by Dien Pham <dien.pham.ry@renesas.com>
> and others for r8a77990 SoC.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
LGTM (I'm no thermal expert, so an additional pair of eyes wouldn't hurt), so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.17.
> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> @@ -88,6 +88,7 @@
> compatible = "arm,cortex-a55";
> reg = <0>;
> device_type = "cpu";
> + #cooling-cells = <2>;
> next-level-cache = <&L3_CA55>;
> enable-method = "psci";
> clocks = <&cpg CPG_CORE R9A07G044_CLK_I>;
> @@ -917,6 +918,15 @@
> polling-delay-passive = <250>;
> polling-delay = <1000>;
> thermal-sensors = <&tsu 0>;
> + sustainable-power = <717>;
> +
> + cooling-maps {
> + map0 {
> + trip = <&target>;
> + cooling-device = <&cpu0 0 2>;
> + contribution = <1024>;
> + };
> + };
>
> trips {
> sensor_crit: sensor-crit {
> @@ -924,6 +934,12 @@
> hysteresis = <1000>;
> type = "critical";
> };
> +
> + target: trip-point {
> + temperature = <100000>;
> + hysteresis = <1000>;
> + type = "passive";
> + };
> };
> };
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-14 11:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08 14:27 [PATCH 0/2] Enable Thermal support for RZ/G2L Biju Das
2021-12-08 14:27 ` [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add TSU node Biju Das
2021-12-14 11:11 ` Geert Uytterhoeven
2021-12-08 14:27 ` [PATCH 2/2] arm64: dts: renesas: r9a07g044: Create thermal zone to support IPA Biju Das
2021-12-14 11:13 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).