* [PATCH] ARM: dts: at91: sama5d2: Name the qspi clock
@ 2021-12-09 10:25 Tudor Ambarus
2021-12-13 13:47 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Tudor Ambarus @ 2021-12-09 10:25 UTC (permalink / raw)
To: nicolas.ferre
Cc: alexandre.belloni, ludovic.desroches, robh+dt, linux-arm-kernel,
devicetree, linux-kernel, Tudor Ambarus
Naming clocks is a good practice. The atmel-quadspi driver supports
an unnamed clock for the peripheral clock in order to be backward
compatible with old DTs, but it is recommended to name the clocks
on new DTs. The driver's bindings file requires the clock-names
property, so name the clock.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
arch/arm/boot/dts/sama5d2.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index 801969c113d6..09c741e8ecb8 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi
@@ -288,6 +288,7 @@ qspi0: spi@f0020000 {
reg-names = "qspi_base", "qspi_mmap";
interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>;
clocks = <&pmc PMC_TYPE_PERIPHERAL 52>;
+ clock-names = "pclk";
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";
@@ -299,6 +300,7 @@ qspi1: spi@f0024000 {
reg-names = "qspi_base", "qspi_mmap";
interrupts = <53 IRQ_TYPE_LEVEL_HIGH 7>;
clocks = <&pmc PMC_TYPE_PERIPHERAL 53>;
+ clock-names = "pclk";
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: at91: sama5d2: Name the qspi clock
2021-12-09 10:25 [PATCH] ARM: dts: at91: sama5d2: Name the qspi clock Tudor Ambarus
@ 2021-12-13 13:47 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2021-12-13 13:47 UTC (permalink / raw)
To: Tudor Ambarus
Cc: alexandre.belloni, ludovic.desroches, robh+dt, linux-arm-kernel,
devicetree, linux-kernel
On 09/12/2021 at 11:25, Tudor Ambarus wrote:
> Naming clocks is a good practice. The atmel-quadspi driver supports
> an unnamed clock for the peripheral clock in order to be backward
> compatible with old DTs, but it is recommended to name the clocks
> on new DTs. The driver's bindings file requires the clock-names
> property, so name the clock.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Queued in at91-dt branch for 5.17.
Best regards,
Nicolas
> ---
> arch/arm/boot/dts/sama5d2.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 801969c113d6..09c741e8ecb8 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -288,6 +288,7 @@ qspi0: spi@f0020000 {
> reg-names = "qspi_base", "qspi_mmap";
> interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 52>;
> + clock-names = "pclk";
> #address-cells = <1>;
> #size-cells = <0>;
> status = "disabled";
> @@ -299,6 +300,7 @@ qspi1: spi@f0024000 {
> reg-names = "qspi_base", "qspi_mmap";
> interrupts = <53 IRQ_TYPE_LEVEL_HIGH 7>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 53>;
> + clock-names = "pclk";
> #address-cells = <1>;
> #size-cells = <0>;
> status = "disabled";
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-13 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 10:25 [PATCH] ARM: dts: at91: sama5d2: Name the qspi clock Tudor Ambarus
2021-12-13 13:47 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).