From: Pratyush Yadav <p.yadav@ti.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: "Pratyush Yadav" <p.yadav@ti.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Nikhil Devshatwar" <nikhil.nd@ti.com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Benoit Parrot" <bparrot@ti.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: [PATCH v5 09/14] media: cadence: csi2rx: Add link validation
Date: Fri, 24 Dec 2021 00:46:10 +0530 [thread overview]
Message-ID: <20211223191615.17803-10-p.yadav@ti.com> (raw)
In-Reply-To: <20211223191615.17803-1-p.yadav@ti.com>
Add media link validation to make sure incorrectly configured pipelines
are caught. Since there is no support for transcoding, rely on the
default link validation function to make sure formats across source and
sink pads are the same.
Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
---
Changes in v5:
- New in v5.
drivers/media/platform/cadence/cdns-csi2rx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c
index 53659776a906..119c7540c75a 100644
--- a/drivers/media/platform/cadence/cdns-csi2rx.c
+++ b/drivers/media/platform/cadence/cdns-csi2rx.c
@@ -492,6 +492,10 @@ static const struct v4l2_subdev_ops csi2rx_subdev_ops = {
.pad = &csi2rx_pad_ops,
};
+static struct media_entity_operations csi2rx_media_ops = {
+ .link_validate = v4l2_subdev_link_validate,
+};
+
static int csi2rx_async_bound(struct v4l2_async_notifier *notifier,
struct v4l2_subdev *s_subdev,
struct v4l2_async_subdev *asd)
@@ -691,6 +695,7 @@ static int csi2rx_probe(struct platform_device *pdev)
for (i = CSI2RX_PAD_SOURCE_STREAM0; i < CSI2RX_PAD_MAX; i++)
csi2rx->pads[i].flags = MEDIA_PAD_FL_SOURCE;
csi2rx->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
+ csi2rx->subdev.entity.ops = &csi2rx_media_ops;
ret = media_entity_pads_init(&csi2rx->subdev.entity, CSI2RX_PAD_MAX,
csi2rx->pads);
--
2.33.1.835.ge9e5ba39a7
next prev parent reply other threads:[~2021-12-23 19:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 19:16 [PATCH v5 00/14] CSI2RX support on J721E Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 01/14] media: cadence: csi2rx: Unregister v4l2 async notifier Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 02/14] media: cadence: csi2rx: Cleanup media entity properly Pratyush Yadav
2021-12-30 4:23 ` Laurent Pinchart
2021-12-23 19:16 ` [PATCH v5 03/14] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops Pratyush Yadav
2021-12-30 4:32 ` Laurent Pinchart
2022-01-04 6:21 ` Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 04/14] media: cadence: csi2rx: Add external DPHY support Pratyush Yadav
2021-12-30 4:43 ` Laurent Pinchart
2021-12-23 19:16 ` [PATCH v5 05/14] media: cadence: csi2rx: Soft reset the streams before starting capture Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 06/14] media: cadence: csi2rx: Set the STOP bit when stopping a stream Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 07/14] media: cadence: csi2rx: Fix stream data configuration Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 08/14] media: cadence: csi2rx: Populate subdev devnode Pratyush Yadav
2021-12-23 19:16 ` Pratyush Yadav [this message]
2021-12-30 4:47 ` [PATCH v5 09/14] media: cadence: csi2rx: Add link validation Laurent Pinchart
2021-12-23 19:16 ` [PATCH v5 10/14] media: Re-structure TI platform drivers Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 11/14] media: ti: Add CSI2RX support for J721E Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 12/14] media: dt-bindings: Make sure items in data-lanes are unique Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 13/14] media: dt-bindings: Add DT bindings for TI J721E CSI2RX driver Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 14/14] media: dt-bindings: Convert Cadence CSI2RX binding to YAML Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223191615.17803-10-p.yadav@ti.com \
--to=p.yadav@ti.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=nikhil.nd@ti.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).