From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Nikhil Devshatwar" <nikhil.nd@ti.com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Benoit Parrot" <bparrot@ti.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v5 02/14] media: cadence: csi2rx: Cleanup media entity properly
Date: Thu, 30 Dec 2021 06:23:04 +0200 [thread overview]
Message-ID: <Yc00KA6zwnfvdp6C@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20211223191615.17803-3-p.yadav@ti.com>
Hi Pratyush,
Thank you for the patch.
On Fri, Dec 24, 2021 at 12:46:03AM +0530, Pratyush Yadav wrote:
> Call media_entity_cleanup() in probe error path and remove to make sure
> the media entity is cleaned up properly.
>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> Changes in v5:
> - New in v5.
>
> drivers/media/platform/cadence/cdns-csi2rx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c
> index 2a23da6a0b8e..2547903f2e8e 100644
> --- a/drivers/media/platform/cadence/cdns-csi2rx.c
> +++ b/drivers/media/platform/cadence/cdns-csi2rx.c
> @@ -471,6 +471,7 @@ static int csi2rx_probe(struct platform_device *pdev)
> err_cleanup:
> v4l2_async_nf_unregister(&csi2rx->notifier);
> v4l2_async_nf_cleanup(&csi2rx->notifier);
> + media_entity_cleanup(&csi2rx->subdev.entity);
> err_free_priv:
> kfree(csi2rx);
> return ret;
> @@ -483,6 +484,7 @@ static int csi2rx_remove(struct platform_device *pdev)
> v4l2_async_nf_unregister(&csi2rx->notifier);
> v4l2_async_nf_cleanup(&csi2rx->notifier);
> v4l2_async_unregister_subdev(&csi2rx->subdev);
> + media_entity_cleanup(&csi2rx->subdev.entity);
> kfree(csi2rx);
>
> return 0;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-12-30 4:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 19:16 [PATCH v5 00/14] CSI2RX support on J721E Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 01/14] media: cadence: csi2rx: Unregister v4l2 async notifier Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 02/14] media: cadence: csi2rx: Cleanup media entity properly Pratyush Yadav
2021-12-30 4:23 ` Laurent Pinchart [this message]
2021-12-23 19:16 ` [PATCH v5 03/14] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops Pratyush Yadav
2021-12-30 4:32 ` Laurent Pinchart
2022-01-04 6:21 ` Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 04/14] media: cadence: csi2rx: Add external DPHY support Pratyush Yadav
2021-12-30 4:43 ` Laurent Pinchart
2021-12-23 19:16 ` [PATCH v5 05/14] media: cadence: csi2rx: Soft reset the streams before starting capture Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 06/14] media: cadence: csi2rx: Set the STOP bit when stopping a stream Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 07/14] media: cadence: csi2rx: Fix stream data configuration Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 08/14] media: cadence: csi2rx: Populate subdev devnode Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 09/14] media: cadence: csi2rx: Add link validation Pratyush Yadav
2021-12-30 4:47 ` Laurent Pinchart
2021-12-23 19:16 ` [PATCH v5 10/14] media: Re-structure TI platform drivers Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 11/14] media: ti: Add CSI2RX support for J721E Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 12/14] media: dt-bindings: Make sure items in data-lanes are unique Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 13/14] media: dt-bindings: Add DT bindings for TI J721E CSI2RX driver Pratyush Yadav
2021-12-23 19:16 ` [PATCH v5 14/14] media: dt-bindings: Convert Cadence CSI2RX binding to YAML Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc00KA6zwnfvdp6C@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=nikhil.nd@ti.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).