devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] ARM: dts: imx6qdl-phytec: add missing pmic MFD subdevices
@ 2022-01-28  7:27 Andrej Picej
  2022-01-28  7:27 ` [PATCH v2 2/2] ARM: dts: imx6qdl-phytec: handle unneeded MFD-subdevices correctly Andrej Picej
  2022-02-11  4:43 ` [PATCH v2 1/2] ARM: dts: imx6qdl-phytec: add missing pmic MFD subdevices Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Andrej Picej @ 2022-01-28  7:27 UTC (permalink / raw)
  To: shawnguo, robh+dt, s.hauer, devicetree
  Cc: festevam, kernel, linux-kernel, y.bas

phyFLEX PMIC DA9063 has also RTC and watchdog support. Add both
MFD subdevices so they can be used.

Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
Changes in v2:
 - fix subject to follow ARM: dts: imx6qdl-phytec: ... style
 - use MFD (capital letters) in subject and commit message
 - change rtc and watchdog lebel/node name to follow more standard
   naming scheme
---
 arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
index f3236204cb5a..c6ec71f6f034 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
@@ -205,6 +205,14 @@ vdd_mx6_high_reg: ldo11 {
 				regulator-always-on;
 			};
 		};
+
+		da9063_rtc: rtc {
+			compatible = "dlg,da9063-rtc";
+		};
+
+		da9063_wdog: watchdog {
+			compatible = "dlg,da9063-watchdog";
+		};
 	};
 };
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2 2/2] ARM: dts: imx6qdl-phytec: handle unneeded MFD-subdevices correctly
  2022-01-28  7:27 [PATCH v2 1/2] ARM: dts: imx6qdl-phytec: add missing pmic MFD subdevices Andrej Picej
@ 2022-01-28  7:27 ` Andrej Picej
  2022-02-11  4:43 ` [PATCH v2 1/2] ARM: dts: imx6qdl-phytec: add missing pmic MFD subdevices Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Andrej Picej @ 2022-01-28  7:27 UTC (permalink / raw)
  To: shawnguo, robh+dt, s.hauer, devicetree
  Cc: festevam, kernel, linux-kernel, y.bas

From: Yunus Bas <y.bas@phytec.de>

The proper way to handle partly used MFD devices are to describe all MFD
subdevices in the devicetree and disable the not used ones. This
suppresses any warnings that may arise as a result.

Signed-off-by: Yunus Bas <y.bas@phytec.de>
Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
Changes in v2:
 - use ARM: dts: imx6qdl-phytec: ... as subject prefix
---
 arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi      |  5 +++++
 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 10 ++++++++++
 2 files changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
index c6ec71f6f034..1f2ba6f6254e 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
@@ -213,6 +213,11 @@ da9063_rtc: rtc {
 		da9063_wdog: watchdog {
 			compatible = "dlg,da9063-watchdog";
 		};
+
+		onkey {
+			compatible = "dlg,da9063-onkey";
+			status = "disabled";
+		};
 	};
 };
 
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
index 94b254bfd054..28a805384668 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
@@ -116,6 +116,16 @@ watchdog {
 			dlg,use-sw-pm;
 		};
 
+		thermal {
+			compatible = "dlg,da9062-thermal";
+			status = "disabled";
+		};
+
+		gpio {
+			compatible = "dlg,da9062-gpio";
+			status = "disabled";
+		};
+
 		regulators {
 			vdd_arm: buck1 {
 				regulator-name = "vdd_arm";
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/2] ARM: dts: imx6qdl-phytec: add missing pmic MFD subdevices
  2022-01-28  7:27 [PATCH v2 1/2] ARM: dts: imx6qdl-phytec: add missing pmic MFD subdevices Andrej Picej
  2022-01-28  7:27 ` [PATCH v2 2/2] ARM: dts: imx6qdl-phytec: handle unneeded MFD-subdevices correctly Andrej Picej
@ 2022-02-11  4:43 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-02-11  4:43 UTC (permalink / raw)
  To: Andrej Picej
  Cc: robh+dt, s.hauer, devicetree, festevam, kernel, linux-kernel, y.bas

On Fri, Jan 28, 2022 at 08:27:37AM +0100, Andrej Picej wrote:
> phyFLEX PMIC DA9063 has also RTC and watchdog support. Add both
> MFD subdevices so they can be used.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>

Applied both, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-11  4:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-28  7:27 [PATCH v2 1/2] ARM: dts: imx6qdl-phytec: add missing pmic MFD subdevices Andrej Picej
2022-01-28  7:27 ` [PATCH v2 2/2] ARM: dts: imx6qdl-phytec: handle unneeded MFD-subdevices correctly Andrej Picej
2022-02-11  4:43 ` [PATCH v2 1/2] ARM: dts: imx6qdl-phytec: add missing pmic MFD subdevices Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).