Re: [PATCH v2 00/15] pwm: dt-bindings: Include generic pwm schema - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
	devicetree@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>,
	Sagar Kadam <sagar.kadam@sifive.com>,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Fabio Estevam <festevam@gmail.com>,
	linux-riscv@lists.infradead.org, Vignesh R <vigneshr@ti.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Lee Jones <lee.jones@linaro.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	linux-rockchip@lists.infradead.org,
	Rahul Tanwar <rtanwar@maxlinear.com>,
	bcm-kernel-feedback-list@broadcom.com,
	NXP Linux Team <linux-imx@nxp.com>,
	Jeff LaBundy <jeff@labundy.com>,
	linux-sunxi@lists.linux.dev, linux-pwm@vger.kernel.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Maxime Ripard <mripard@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-arm-kernel@lists.infradead.org,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v2 00/15] pwm: dt-bindings: Include generic pwm schema
Date: Tue, 15 Feb 2022 10:41:06 +0100	[thread overview]
Message-ID: <20220215094106.k35pmoxt2nk44dsj@pengutronix.de> (raw)
In-Reply-To: <7df71f8d-cdc3-4b2e-cf0a-7112eff28142@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 2844 bytes --]

On Tue, Feb 15, 2022 at 09:02:25AM +0100, Krzysztof Kozlowski wrote:
> On 15/02/2022 08:59, Krzysztof Kozlowski wrote:
> > On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König
> > <u.kleine-koenig@pengutronix.de> wrote:
> >>
> >> Hello,
> >>
> >> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for
> >> my last mail]
> >>
> >> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
> >>> Hi,
> >>>
> >>> Changes since v1:
> >>> 1. Add tags.
> >>> 2. Adjust subject (Uwe).
> >>
> >> However you only took a part of my suggestion ...
> >>
> >>> Krzysztof Kozlowski (15):
> >>>   dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
> >>>   dt-bindings: pwm: imx: Include generic pwm schema
> >>>   dt-bindings: pwm: intel,lgm: Include generic pwm schema
> >>>   dt-bindings: pwm: iqs620a: Include generic pwm schema
> >>>   dt-bindings: pwm: mxs: Include generic pwm schema
> >>>   dt-bindings: pwm: rockchip: Include generic pwm schema
> >>>   dt-bindings: pwm: sifive: Include generic pwm schema
> >>>   dt-bindings: pwm: renesas,pwm: Include generic pwm schema
> >>>   dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
> >>>   dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
> >>>   dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
> >>
> >> ... The actual patch has a space after the comma, I like this variant
> >> without comma better as this is a compatible string.
> > 
> > I am confused. My patch does not have comma after space. Your reply
> > had such in the subject, but not in the proposed new subject you wrote
> > in msg, so I left it as is. Without comma. If you still see comma, it
> > is something with your mail client.
> > 
> > See:
> > https://lore.kernel.org/linux-devicetree/20220214212154.8853-12-krzysztof.kozlowski@canonical.com/T/#u
> > 
> > Also reply from Vijayakannan does not have comma:
> > https://lore.kernel.org/linux-devicetree/20220214081605.161394-11-krzysztof.kozlowski@canonical.com/T/#m80af695f2c751341bc971114aefa00ccc929a3ec

Strange: I have this mail four times in my mailboxes (via
linux-arm-kernel, linux-pwm, kernel@pengutronix.de and directly). In the
two latter the Subject line is broken in two:

	Subject: [PATCH v2 08/15] dt-bindings: pwm: renesas,
	 pwm: Include generic pwm schema

So this is indeed a problem near my side.

> Just one more clarification - you proposed also to remove "pwm:"
> middle-prefix. Shall I remove it from every patch and use instead full
> file name?

I did that to save some vertical space in the Subject line. I don't feel
strong here.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]