From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Krishna Kurapati <quic_kriskura@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
"Matthias Kaehlcke" <mka@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
<devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
<quic_ppratap@quicinc.com>, <quic_vpulyala@quicinc.com>,
Sandeep Maheswaram <quic_c_sanm@quicinc.com>
Subject: Re: [PATCH v20 5/5] usb: dwc3: qcom: Keep power domain on to retain controller status
Date: Thu, 2 Jun 2022 18:37:47 +0530 [thread overview]
Message-ID: <20220602130747.GB2521@hu-pkondeti-hyd.qualcomm.com> (raw)
In-Reply-To: <1654158277-12921-6-git-send-email-quic_kriskura@quicinc.com>
On Thu, Jun 02, 2022 at 01:54:37PM +0530, Krishna Kurapati wrote:
> From: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>
> If dwc3 is wakeup capable, keep the power domain always ON so that
> wakeup from system suspend can be supported. Otherwise, keep the
> power domain ON only during runtime suspend to support wakeup from
> runtime suspend.
>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 28 +++++++++++++++++++++-------
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 9395d79..7b6eff5 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -17,6 +17,7 @@
> #include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/phy/phy.h>
> +#include <linux/pm_domain.h>
> #include <linux/usb/of.h>
> #include <linux/reset.h>
> #include <linux/iopoll.h>
> @@ -756,12 +757,13 @@ dwc3_qcom_create_urs_usb_platdev(struct device *dev)
>
> static int dwc3_qcom_probe(struct platform_device *pdev)
> {
> - struct device_node *np = pdev->dev.of_node;
> - struct device *dev = &pdev->dev;
> - struct dwc3_qcom *qcom;
> - struct resource *res, *parent_res = NULL;
> - int ret, i;
> - bool ignore_pipe_clk;
> + struct device_node *np = pdev->dev.of_node;
> + struct device *dev = &pdev->dev;
> + struct dwc3_qcom *qcom;
> + struct resource *res, *parent_res = NULL;
> + int ret, i;
> + bool ignore_pipe_clk;
> + struct generic_pm_domain *genpd;
>
> qcom = devm_kzalloc(&pdev->dev, sizeof(*qcom), GFP_KERNEL);
> if (!qcom)
> @@ -770,6 +772,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, qcom);
> qcom->dev = &pdev->dev;
>
> + genpd = pd_to_genpd(qcom->dev->pm_domain);
> +
> if (has_acpi_companion(dev)) {
> qcom->acpi_pdata = acpi_device_get_match_data(dev);
> if (!qcom->acpi_pdata) {
> @@ -877,7 +881,17 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
> if (ret)
> goto interconnect_exit;
>
> - device_init_wakeup(&pdev->dev, 1);
> + if (device_can_wakeup(&qcom->dwc3->dev)) {
> + /*
> + * Setting GENPD_FLAG_ALWAYS_ON flag takes care of keeping
> + * genpd on in both runtime suspend and system suspend cases.
> + */
> + genpd->flags |= GENPD_FLAG_ALWAYS_ON;
> + device_init_wakeup(&pdev->dev, true);
> + } else {
> + genpd->flags |= GENPD_FLAG_RPM_ALWAYS_ON;
> + }
> +
> qcom->is_suspended = false;
> pm_runtime_set_active(dev);
> pm_runtime_enable(dev);
Looks good to me.
Reviewed-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com>
next prev parent reply other threads:[~2022-06-02 13:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 8:24 [PATCH v20 0/5] USB DWC3 host wake up support from system suspend Krishna Kurapati
2022-06-02 8:24 ` [PATCH v20 1/5] dt-bindings: usb: dwc3: Add wakeup-source property support Krishna Kurapati
2022-06-02 8:24 ` [PATCH v20 2/5] usb: dwc3: core: Host wake up support from system suspend Krishna Kurapati
2022-06-02 19:35 ` Matthias Kaehlcke
2022-06-06 20:45 ` Matthias Kaehlcke
2022-06-13 18:08 ` Matthias Kaehlcke
2022-06-14 17:53 ` Matthias Kaehlcke
2022-06-14 19:37 ` Krishna Kurapati PSSNV
2022-06-16 9:11 ` Pavan Kondeti
2022-06-16 17:15 ` Matthias Kaehlcke
2022-06-20 8:54 ` Pavan Kondeti
2022-06-23 18:38 ` Matthias Kaehlcke
2022-06-24 8:58 ` Pavan Kondeti
2022-06-27 20:02 ` Stephen Boyd
2022-06-28 5:31 ` Pavan Kondeti
2022-06-29 22:15 ` Stephen Boyd
2022-06-30 18:13 ` Krishna Kurapati PSSNV
2022-07-01 1:10 ` Matthias Kaehlcke
2022-07-01 10:15 ` Pavan Kondeti
2022-07-01 15:52 ` Matthias Kaehlcke
[not found] ` <09f6a717-2bbb-6bd3-f7a8-5ac9e3db51f3@quicinc.com>
[not found] ` <9f9f9abc-9b37-8bfb-3efa-6c860b5dba8d@quicinc.com>
2022-07-13 1:34 ` Matthias Kaehlcke
2022-06-02 8:24 ` [PATCH v20 3/5] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Krishna Kurapati
2022-06-02 8:24 ` [PATCH v20 4/5] usb: dwc3: qcom: Configure wakeup interrupts during suspend Krishna Kurapati
2022-06-02 13:07 ` Pavan Kondeti
2022-06-02 8:24 ` [PATCH v20 5/5] usb: dwc3: qcom: Keep power domain on to retain controller status Krishna Kurapati
2022-06-02 13:07 ` Pavan Kondeti [this message]
2022-06-02 13:09 ` [PATCH v20 0/5] USB DWC3 host wake up support from system suspend Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602130747.GB2521@hu-pkondeti-hyd.qualcomm.com \
--to=quic_pkondeti@quicinc.com \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mka@chromium.org \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_vpulyala@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).