From: Matthias Kaehlcke <mka@chromium.org>
To: Krishna Kurapati <quic_kriskura@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, quic_pkondeti@quicinc.com,
quic_ppratap@quicinc.com, quic_vpulyala@quicinc.com,
Sandeep Maheswaram <quic_c_sanm@quicinc.com>
Subject: Re: [PATCH v20 2/5] usb: dwc3: core: Host wake up support from system suspend
Date: Mon, 13 Jun 2022 11:08:32 -0700 [thread overview]
Message-ID: <Yqd9IHQEj3Ex+FcF@google.com> (raw)
In-Reply-To: <Yp5nf2w8uVZ38/XZ@google.com>
On Mon, Jun 06, 2022 at 01:45:51PM -0700, Matthias Kaehlcke wrote:
> On Thu, Jun 02, 2022 at 12:35:42PM -0700, Matthias Kaehlcke wrote:
> > Hi Krishna,
> >
> > with this version I see xHCI errors on my SC7180 based system, like
> > these:
> >
> > [ 65.352605] xhci-hcd xhci-hcd.13.auto: xHC error in resume, USBSTS 0x401, Reinit
> >
> > [ 101.307155] xhci-hcd xhci-hcd.13.auto: WARN: xHC CMD_RUN timeout
> >
> > After resume a downstream hub isn't enumerated again.
> >
> > So far I didn't see those with v13, but I aso saw the first error with
> > v16.
>
> It also happens with v13, but only when a wakeup capable vUSB <= 2
> device is plugged in. Initially I used a wakeup capable USB3 to
> Ethernet adapter to trigger the wakeup case, however older versions
> of this series that use usb_wakeup_enabled_descendants() to check
> for wakeup capable devices didn't actually check for vUSB > 2
> devices.
>
> So the case were the controller/PHYs is powered down works, but
> the controller is unhappy when the runtime PM path is used during
> system suspend.
The issue isn't seen on all systems using dwc3-qcom and the problem starts
during probe(). The expected probe sequence is something like this:
dwc3_qcom_probe
dwc3_qcom_of_register_core
dwc3_probe
if (device_can_wakeup(&qcom->dwc3->dev))
...
The important part is that device_can_wakeup() is called after dwc3_probe()
has completed. That's what I see on a QC SC7280 system, where wakeup is
generally working with these patches.
However on a QC SC7180 system dwc3_probe() is deferred and only executed after
dwc3_qcom_probe(). As a result the device_can_wakeup() call returns false.
With that the controller/driver ends up in an unhappy state after system
suspend.
Probing is deferred on SC7180 because device_links_check_suppliers() finds
that '88e3000.phy' isn't ready yet.
next prev parent reply other threads:[~2022-06-13 19:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 8:24 [PATCH v20 0/5] USB DWC3 host wake up support from system suspend Krishna Kurapati
2022-06-02 8:24 ` [PATCH v20 1/5] dt-bindings: usb: dwc3: Add wakeup-source property support Krishna Kurapati
2022-06-02 8:24 ` [PATCH v20 2/5] usb: dwc3: core: Host wake up support from system suspend Krishna Kurapati
2022-06-02 19:35 ` Matthias Kaehlcke
2022-06-06 20:45 ` Matthias Kaehlcke
2022-06-13 18:08 ` Matthias Kaehlcke [this message]
2022-06-14 17:53 ` Matthias Kaehlcke
2022-06-14 19:37 ` Krishna Kurapati PSSNV
2022-06-16 9:11 ` Pavan Kondeti
2022-06-16 17:15 ` Matthias Kaehlcke
2022-06-20 8:54 ` Pavan Kondeti
2022-06-23 18:38 ` Matthias Kaehlcke
2022-06-24 8:58 ` Pavan Kondeti
2022-06-27 20:02 ` Stephen Boyd
2022-06-28 5:31 ` Pavan Kondeti
2022-06-29 22:15 ` Stephen Boyd
2022-06-30 18:13 ` Krishna Kurapati PSSNV
2022-07-01 1:10 ` Matthias Kaehlcke
2022-07-01 10:15 ` Pavan Kondeti
2022-07-01 15:52 ` Matthias Kaehlcke
[not found] ` <09f6a717-2bbb-6bd3-f7a8-5ac9e3db51f3@quicinc.com>
[not found] ` <9f9f9abc-9b37-8bfb-3efa-6c860b5dba8d@quicinc.com>
2022-07-13 1:34 ` Matthias Kaehlcke
2022-06-02 8:24 ` [PATCH v20 3/5] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Krishna Kurapati
2022-06-02 8:24 ` [PATCH v20 4/5] usb: dwc3: qcom: Configure wakeup interrupts during suspend Krishna Kurapati
2022-06-02 13:07 ` Pavan Kondeti
2022-06-02 8:24 ` [PATCH v20 5/5] usb: dwc3: qcom: Keep power domain on to retain controller status Krishna Kurapati
2022-06-02 13:07 ` Pavan Kondeti
2022-06-02 13:09 ` [PATCH v20 0/5] USB DWC3 host wake up support from system suspend Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqd9IHQEj3Ex+FcF@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_vpulyala@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).