From: Vidya Sagar <vidyas@nvidia.com>
To: <bhelgaas@google.com>, <lorenzo.pieralisi@arm.com>,
<robh+dt@kernel.org>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>
Cc: <kishon@ti.com>, <vkoul@kernel.org>, <kw@linux.com>,
<krzk@kernel.org>, <p.zabel@pengutronix.de>,
<mperttunen@nvidia.com>, <linux-pci@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<kthota@nvidia.com>, <mmaddireddy@nvidia.com>,
<vidyas@nvidia.com>, <sagar.tv@gmail.com>
Subject: [PATCH V3 09/11] PCI: Disable MSI for Tegra234 root ports
Date: Wed, 29 Jun 2022 11:34:33 +0530 [thread overview]
Message-ID: <20220629060435.25297-10-vidyas@nvidia.com> (raw)
In-Reply-To: <20220629060435.25297-1-vidyas@nvidia.com>
Tegra234 PCIe rootports don't generate MSI interrupts for PME and AER
events. Since PCIe spec (Ref: r4.0 sec 6.1.4.3) doesn't support using
a mix of INTx and MSI/MSI-X, MSI needs to be disabled to avoid root
ports service drivers registering their respective ISRs with MSI interrupt
and to let only INTx be used for all events.
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
V3:
* None
V2:
* Addressed review comments from Bjorn i.e. changed the PCIe spec reference
to a more relevant section and modified commit message accordingly
drivers/pci/quirks.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 2e68f50bc7ae..5b532449ac4f 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2709,8 +2709,8 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA,
nvenet_msi_disable);
/*
- * PCIe spec r4.0 sec 7.7.1.2 and sec 7.7.2.2 say that if MSI/MSI-X is enabled,
- * then the device can't use INTx interrupts. Tegra's PCIe root ports don't
+ * PCIe spec r4.0 sec 6.1.4.3 says that if MSI/MSI-X is enabled,then the
+ * device can't use INTx interrupts. Tegra's PCIe root ports don't
* generate MSI interrupts for PME and AER events instead only INTx interrupts
* are generated. Though Tegra's PCIe root ports can generate MSI interrupts
* for other events, since PCIe specification doesn't support using a mix of
@@ -2760,6 +2760,15 @@ DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_NVIDIA, 0x10e5,
DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_NVIDIA, 0x10e6,
PCI_CLASS_BRIDGE_PCI, 8,
pci_quirk_nvidia_tegra_disable_rp_msi);
+DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_NVIDIA, 0x229a,
+ PCI_CLASS_BRIDGE_PCI, 8,
+ pci_quirk_nvidia_tegra_disable_rp_msi);
+DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_NVIDIA, 0x229c,
+ PCI_CLASS_BRIDGE_PCI, 8,
+ pci_quirk_nvidia_tegra_disable_rp_msi);
+DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_NVIDIA, 0x229e,
+ PCI_CLASS_BRIDGE_PCI, 8,
+ pci_quirk_nvidia_tegra_disable_rp_msi);
/*
* Some versions of the MCP55 bridge from Nvidia have a legacy IRQ routing
--
2.17.1
next prev parent reply other threads:[~2022-06-29 6:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 6:04 [PATCH V3 00/11] PCI: tegra: Add Tegra234 PCIe support Vidya Sagar
2022-06-29 6:04 ` [PATCH V3 01/11] dt-bindings: PHY: P2U: Add support for Tegra234 P2U block Vidya Sagar
2022-07-05 6:14 ` Vinod Koul
2022-06-29 6:04 ` [PATCH V3 02/11] dt-bindings: pci: tegra: Convert to json-schema Vidya Sagar
2022-06-29 6:29 ` Krzysztof Kozlowski
2022-07-06 9:51 ` Vidya Sagar
2022-07-06 9:58 ` Krzysztof Kozlowski
2022-06-30 21:04 ` Rob Herring
2022-07-06 9:53 ` Vidya Sagar
2022-07-06 10:06 ` Krzysztof Kozlowski
2022-07-06 10:46 ` Vidya Sagar
2022-07-06 15:06 ` Krzysztof Kozlowski
2022-07-06 18:11 ` Rob Herring
2022-06-29 6:04 ` [PATCH V3 03/11] dt-bindings: PCI: tegra234: Add schema for tegra234 rootport mode Vidya Sagar
2022-06-29 6:32 ` Krzysztof Kozlowski
2022-06-29 6:04 ` [PATCH V3 04/11] dt-bindings: PCI: tegra234: Add schema for tegra234 endpoint mode Vidya Sagar
2022-06-29 6:33 ` Krzysztof Kozlowski
2022-06-29 6:04 ` [PATCH V3 05/11] arm64: tegra: Add regulators required for PCIe Vidya Sagar
2022-06-29 6:34 ` Krzysztof Kozlowski
2022-06-29 6:04 ` [PATCH V3 06/11] arm64: tegra: Add P2U and PCIe controller nodes to Tegra234 DT Vidya Sagar
2022-06-29 6:35 ` Krzysztof Kozlowski
2022-06-29 6:04 ` [PATCH V3 07/11] arm64: tegra: Enable PCIe slots in P3737-0000 board Vidya Sagar
2022-06-29 6:04 ` [PATCH V3 08/11] phy: tegra: Add PCIe PIPE2UPHY support for Tegra234 Vidya Sagar
2022-07-05 6:15 ` Vinod Koul
2022-06-29 6:04 ` Vidya Sagar [this message]
2022-06-29 6:04 ` [PATCH V3 10/11] Revert "PCI: tegra194: Rename tegra_pcie_dw to tegra194_pcie" Vidya Sagar
2022-06-29 6:04 ` [PATCH V3 11/11] PCI: tegra: Add Tegra234 PCIe support Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629060435.25297-10-vidyas@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).