* [PATCH v2 42/55] dt-bindings: media: rkisp1: Add port for parallel interface
[not found] <20220630230713.10580-1-laurent.pinchart@ideasonboard.com>
@ 2022-06-30 23:07 ` Laurent Pinchart
2022-07-01 20:17 ` Rob Herring
2022-06-30 23:07 ` [PATCH v2 47/55] dt-bindings: media: rkisp1: Add i.MX8MP ISP to compatible Laurent Pinchart
1 sibling, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2022-06-30 23:07 UTC (permalink / raw)
To: linux-media
Cc: linux-rockchip, Dafna Hirschfeld, Heiko Stuebner, Helen Koike,
Paul Elder, Rob Herring, Krzysztof Kozlowski, devicetree
From: Paul Elder <paul.elder@ideasonboard.com>
The rkisp1 can take an input on the parallel interface. Add a port for
it, and update the required field. At least one port is required, and
both may be specified.
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
.../bindings/media/rockchip-isp1.yaml | 23 +++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
index d1489b177331..b3661d7d4357 100644
--- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
@@ -84,8 +84,27 @@ properties:
minItems: 1
maxItems: 4
- required:
- - port@0
+ port@1:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: connection point for input on the parallel interface
+
+ properties:
+ bus-type:
+ enum: [5, 6]
+
+ endpoint:
+ $ref: video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ required:
+ - bus-type
+
+ anyOf:
+ - required:
+ - port@0
+ - required:
+ - port@1
required:
- compatible
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 47/55] dt-bindings: media: rkisp1: Add i.MX8MP ISP to compatible
[not found] <20220630230713.10580-1-laurent.pinchart@ideasonboard.com>
2022-06-30 23:07 ` [PATCH v2 42/55] dt-bindings: media: rkisp1: Add port for parallel interface Laurent Pinchart
@ 2022-06-30 23:07 ` Laurent Pinchart
2022-07-01 20:18 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2022-06-30 23:07 UTC (permalink / raw)
To: linux-media
Cc: linux-rockchip, Dafna Hirschfeld, Heiko Stuebner, Helen Koike,
Paul Elder, Rob Herring, Krzysztof Kozlowski, devicetree
From: Paul Elder <paul.elder@ideasonboard.com>
The i.MX8MP ISP is compatbile with the rkisp1 driver. Add it to the list
of compatible strings. While at it, expand on the description of the
clocks to make it clear which clock in the i.MX8MP ISP they map to,
based on the names from the datasheet (which are confusing).
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Documentation/devicetree/bindings/media/rockchip-isp1.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
index b3661d7d4357..95cf945f7ac5 100644
--- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
@@ -16,6 +16,7 @@ description: |
properties:
compatible:
enum:
+ - fsl,imx8mp-isp
- rockchip,px30-cif-isp
- rockchip,rk3399-cif-isp
@@ -36,9 +37,9 @@ properties:
minItems: 3
items:
# isp0 and isp1
- - description: ISP clock
- - description: ISP AXI clock
- - description: ISP AHB clock
+ - description: ISP clock (for imx8mp, clk)
+ - description: ISP AXI clock (for imx8mp, m_hclk)
+ - description: ISP AHB clock (for imx8mp, hclk)
# only for isp1
- description: ISP Pixel clock
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 4+ messages in thread