* [PATCH v3 0/2] *** IT6505 driver read dt properties ***
@ 2022-10-06 2:04 allen
2022-10-06 2:04 ` [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen
0 siblings, 1 reply; 7+ messages in thread
From: allen @ 2022-10-06 2:04 UTC (permalink / raw)
Cc: Allen Chen, Jau-Chih Tseng, Kenneth Hung, Hermes Wu, Pin-yen Lin,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:DRM DRIVERS, Jernej Skrabec, Jonas Karlman,
Laurent Pinchart, open list
From: allen chen <allen.chen@ite.com.tw>
This series let driver can read properties from dt to restrict dp output
bandwidth.
Changes in v3:
-Rename property name.
allen chen (2):
dt-bindings: it6505: add properties to restrict output bandwidth
drm/bridge: add it6505 driver to read data-lanes and
max-pixel-clock-mhz from dt
.../bindings/display/bridge/ite,it6505.yaml | 12 +++++++
drivers/gpu/drm/bridge/ite-it6505.c | 36 +++++++++++++++++--
2 files changed, 45 insertions(+), 3 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
2022-10-06 2:04 [PATCH v3 0/2] *** IT6505 driver read dt properties *** allen
@ 2022-10-06 2:04 ` allen
2022-10-06 8:16 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: allen @ 2022-10-06 2:04 UTC (permalink / raw)
Cc: Allen Chen, Jau-Chih Tseng, Kenneth Hung, Hermes Wu, Pin-yen Lin,
Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, open list:DRM DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
From: allen chen <allen.chen@ite.com.tw>
Add properties to restrict dp output data-lanes and clock.
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
---
.../bindings/display/bridge/ite,it6505.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
index 833d11b2303a..f5482a614d05 100644
--- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
@@ -52,6 +52,16 @@ properties:
maxItems: 1
description: extcon specifier for the Power Delivery
+ ite,dp-output-data-lane-count:
+ description: restrict the dp output data-lanes with value of 1-4
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [ 1, 2, 4 ]
+
+ ite,dp-output-max-pixel-clock-mhz:
+ description: restrict max pixel clock
+ $ref: /schemas/types.yaml#/definitions/uint32
+ default: 150
+
port:
$ref: /schemas/graph.yaml#/properties/port
description: A port node pointing to DPI host port node
@@ -84,6 +94,8 @@ examples:
pwr18-supply = <&it6505_pp18_reg>;
reset-gpios = <&pio 179 1>;
extcon = <&usbc_extcon>;
+ ite,dp-output-data-lane-count = <2>;
+ ite,dp-output-max-pixel-clock-mhz = <150>;
port {
it6505_in: endpoint {
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
2022-10-06 2:04 ` [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen
@ 2022-10-06 8:16 ` Krzysztof Kozlowski
2022-10-07 3:18 ` allen.chen
2022-10-06 12:27 ` Rob Herring
2022-10-06 12:54 ` Rob Herring
2 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-06 8:16 UTC (permalink / raw)
To: allen
Cc: Jau-Chih Tseng, Kenneth Hung, Hermes Wu, Pin-yen Lin,
Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, open list:DRM DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 06/10/2022 04:04, allen wrote:
> From: allen chen <allen.chen@ite.com.tw>
>
> Add properties to restrict dp output data-lanes and clock.
>
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> ---
> .../bindings/display/bridge/ite,it6505.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 833d11b2303a..f5482a614d05 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,6 +52,16 @@ properties:
> maxItems: 1
> description: extcon specifier for the Power Delivery
>
> + ite,dp-output-data-lane-count:
> + description: restrict the dp output data-lanes with value of 1-4
Drop "with value of 1-4" because it is redundant, but instead explain
what this property is about. "Restrict output" is not yet enough.
Restrict the number? Or choose specific lanes? Why it cannot be
data-lanes from video-interfaces?
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [ 1, 2, 4 ]
> +
> + ite,dp-output-max-pixel-clock-mhz:
Test your patches before sending.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
2022-10-06 2:04 ` [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen
2022-10-06 8:16 ` Krzysztof Kozlowski
@ 2022-10-06 12:27 ` Rob Herring
2022-10-06 12:54 ` Rob Herring
2 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-10-06 12:27 UTC (permalink / raw)
To: allen
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Pin-yen Lin, Krzysztof Kozlowski, Laurent Pinchart, Kenneth Hung,
Jonas Karlman, Robert Foss, David Airlie, Daniel Vetter,
Neil Armstrong, open list, Andrzej Hajda, Hermes Wu,
Jernej Skrabec, open list:DRM DRIVERS, Rob Herring,
Jau-Chih Tseng
On Thu, 06 Oct 2022 10:04:43 +0800, allen wrote:
> From: allen chen <allen.chen@ite.com.tw>
>
> Add properties to restrict dp output data-lanes and clock.
>
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> ---
> .../bindings/display/bridge/ite,it6505.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml: properties:ite,dp-output-max-pixel-clock-mhz: '$ref' should not be valid under {'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
2022-10-06 2:04 ` [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen
2022-10-06 8:16 ` Krzysztof Kozlowski
2022-10-06 12:27 ` Rob Herring
@ 2022-10-06 12:54 ` Rob Herring
2 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-10-06 12:54 UTC (permalink / raw)
To: allen
Cc: Jau-Chih Tseng, Kenneth Hung, Hermes Wu, Pin-yen Lin,
Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Krzysztof Kozlowski, open list:DRM DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Wed, Oct 5, 2022 at 9:05 PM allen <allen.chen@ite.com.tw> wrote:
>
> From: allen chen <allen.chen@ite.com.tw>
>
> Add properties to restrict dp output data-lanes and clock.
>
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> ---
> .../bindings/display/bridge/ite,it6505.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 833d11b2303a..f5482a614d05 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,6 +52,16 @@ properties:
> maxItems: 1
> description: extcon specifier for the Power Delivery
>
> + ite,dp-output-data-lane-count:
> + description: restrict the dp output data-lanes with value of 1-4
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [ 1, 2, 4 ]
We have a standard property for lanes: data-lanes
It goes in the endpoint.
> +
> + ite,dp-output-max-pixel-clock-mhz:
> + description: restrict max pixel clock
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 150
Also have a common property for this: 'link-frequencies'
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
2022-10-06 8:16 ` Krzysztof Kozlowski
@ 2022-10-07 3:18 ` allen.chen
2022-10-07 6:58 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: allen.chen @ 2022-10-07 3:18 UTC (permalink / raw)
To: krzysztof.kozlowski
Cc: Jau-Chih.Tseng, Kenneth.Hung, Hermes.Wu, treapking,
andrzej.hajda, narmstrong, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, robh+dt, krzysztof.kozlowski+dt,
dri-devel, devicetree, linux-kernel
hi
-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sent: Thursday, October 6, 2022 4:17 PM
To: Allen Chen (陳柏宇) <allen.chen@ite.com.tw>
Cc: Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng@ite.com.tw>; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw>; Pin-yen Lin <treapking@chromium.org>; Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong <narmstrong@baylibre.com>; Robert Foss <robert.foss@linaro.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; open list:DRM DRIVERS <dri-devel@lists.freedesktop.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
On 06/10/2022 04:04, allen wrote:
> From: allen chen <allen.chen@ite.com.tw>
>
> Add properties to restrict dp output data-lanes and clock.
>
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> ---
> .../bindings/display/bridge/ite,it6505.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 833d11b2303a..f5482a614d05 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,6 +52,16 @@ properties:
> maxItems: 1
> description: extcon specifier for the Power Delivery
>
> + ite,dp-output-data-lane-count:
> + description: restrict the dp output data-lanes with value of 1-4
Drop "with value of 1-4" because it is redundant, but instead explain what this property is about. "Restrict output" is not yet enough.
Restrict the number? Or choose specific lanes? Why it cannot be data-lanes from video-interfaces?
==> DP output bandwidth depends on data-lane-count, so the number of output data-lane-count will restrict output bandwidth.
In this dt-binding we don't have output endpoint, so use another property name to configure.
If need to use data-lanes, where can we put in this dt-binding?
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [ 1, 2, 4 ]
> +
> + ite,dp-output-max-pixel-clock-mhz:
Test your patches before sending.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
2022-10-07 3:18 ` allen.chen
@ 2022-10-07 6:58 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-07 6:58 UTC (permalink / raw)
To: allen.chen
Cc: Jau-Chih.Tseng, Kenneth.Hung, Hermes.Wu, treapking,
andrzej.hajda, narmstrong, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, robh+dt, krzysztof.kozlowski+dt,
dri-devel, devicetree, linux-kernel
On 07/10/2022 05:18, allen.chen@ite.com.tw wrote:
> hi
>
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Thursday, October 6, 2022 4:17 PM
> To: Allen Chen (陳柏宇) <allen.chen@ite.com.tw>
> Cc: Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng@ite.com.tw>; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw>; Pin-yen Lin <treapking@chromium.org>; Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong <narmstrong@baylibre.com>; Robert Foss <robert.foss@linaro.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; open list:DRM DRIVERS <dri-devel@lists.freedesktop.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
>
> On 06/10/2022 04:04, allen wrote:
>> From: allen chen <allen.chen@ite.com.tw>
>>
>> Add properties to restrict dp output data-lanes and clock.
>>
>> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
>> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
>> ---
>> .../bindings/display/bridge/ite,it6505.yaml | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
>> b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
>> index 833d11b2303a..f5482a614d05 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
>> @@ -52,6 +52,16 @@ properties:
>> maxItems: 1
>> description: extcon specifier for the Power Delivery
>>
>> + ite,dp-output-data-lane-count:
>> + description: restrict the dp output data-lanes with value of 1-4
>
> Drop "with value of 1-4" because it is redundant, but instead explain what this property is about. "Restrict output" is not yet enough.
> Restrict the number? Or choose specific lanes? Why it cannot be data-lanes from video-interfaces?
>
> ==> DP output bandwidth depends on data-lane-count, so the number of output data-lane-count will restrict output bandwidth.
> In this dt-binding we don't have output endpoint, so use another property name to configure.
> If need to use data-lanes, where can we put in this dt-binding?
I see you got review in v2 to rename it, but it still should be the same
property, if it has similar/same meaning. It can be put here. You just
need to define its type or reference other schema (e.g. video-interfaces
if applicable) which defines it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-10-07 6:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 2:04 [PATCH v3 0/2] *** IT6505 driver read dt properties *** allen
2022-10-06 2:04 ` [PATCH v3 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen
2022-10-06 8:16 ` Krzysztof Kozlowski
2022-10-07 3:18 ` allen.chen
2022-10-07 6:58 ` Krzysztof Kozlowski
2022-10-06 12:27 ` Rob Herring
2022-10-06 12:54 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).