* [PATCH] of: fdt: add stub for early_init_dt_scan()
@ 2022-10-06 3:11 Randy Dunlap
2022-10-06 19:38 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2022-10-06 3:11 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Rob Herring, Frank Rowand, devicetree, Rich Felker,
Arnd Bergmann
When CONFIG_OF_EARLY_FLATTREE and CONFIG_SH_DEVICE_TREE are not set,
SH3 build fails with a call to early_init_dt_scan(), so add a stub for
this function.
../arch/sh/kernel/setup.c: In function 'sh_fdt_init':
../arch/sh/kernel/setup.c:262:26: error: implicit declaration of function 'early_init_dt_scan' [-Werror=implicit-function-declaration]
262 | if (!dt_virt || !early_init_dt_scan(dt_virt)) {
Fixes: 7480e0aabd5f ("sh: add device tree support and generic board using device tree")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: devicetree@vger.kernel.org
Cc: Rich Felker <dalias@libc.org>
Cc: Arnd Bergmann <arnd@arndb.de>
---
include/linux/of_fdt.h | 1 +
1 file changed, 1 insertion(+)
--- a/include/linux/of_fdt.h
+++ b/include/linux/of_fdt.h
@@ -85,6 +85,7 @@ extern void early_init_devtree(void *);
extern void early_get_first_memblock_info(void *, phys_addr_t *);
#else /* CONFIG_OF_EARLY_FLATTREE */
static inline void early_init_dt_check_for_usable_mem_range(void) {}
+static inline bool early_init_dt_scan(void *params) { return false; }
static inline int early_init_dt_scan_chosen_stdout(void) { return -ENODEV; }
static inline void early_init_fdt_scan_reserved_mem(void) {}
static inline void early_init_fdt_reserve_self(void) {}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: fdt: add stub for early_init_dt_scan()
2022-10-06 3:11 [PATCH] of: fdt: add stub for early_init_dt_scan() Randy Dunlap
@ 2022-10-06 19:38 ` Rob Herring
2022-10-06 19:43 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-10-06 19:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Frank Rowand, devicetree, Rich Felker, Arnd Bergmann
On Wed, Oct 05, 2022 at 08:11:16PM -0700, Randy Dunlap wrote:
> When CONFIG_OF_EARLY_FLATTREE and CONFIG_SH_DEVICE_TREE are not set,
> SH3 build fails with a call to early_init_dt_scan(), so add a stub for
> this function.
>
> ../arch/sh/kernel/setup.c: In function 'sh_fdt_init':
> ../arch/sh/kernel/setup.c:262:26: error: implicit declaration of function 'early_init_dt_scan' [-Werror=implicit-function-declaration]
> 262 | if (!dt_virt || !early_init_dt_scan(dt_virt)) {
I think that sh_fdt_init() needs to be enclosed in
CONFIG_OF_EARLY_FLATTREE instead of CONFIG_OF_FLATTREE.
>
> Fixes: 7480e0aabd5f ("sh: add device tree support and generic board using device tree")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: Rich Felker <dalias@libc.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
> include/linux/of_fdt.h | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -85,6 +85,7 @@ extern void early_init_devtree(void *);
> extern void early_get_first_memblock_info(void *, phys_addr_t *);
> #else /* CONFIG_OF_EARLY_FLATTREE */
> static inline void early_init_dt_check_for_usable_mem_range(void) {}
> +static inline bool early_init_dt_scan(void *params) { return false; }
> static inline int early_init_dt_scan_chosen_stdout(void) { return -ENODEV; }
> static inline void early_init_fdt_scan_reserved_mem(void) {}
> static inline void early_init_fdt_reserve_self(void) {}
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: fdt: add stub for early_init_dt_scan()
2022-10-06 19:38 ` Rob Herring
@ 2022-10-06 19:43 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-10-06 19:43 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, Frank Rowand, devicetree, Rich Felker, Arnd Bergmann
On 10/6/22 12:38, Rob Herring wrote:
> On Wed, Oct 05, 2022 at 08:11:16PM -0700, Randy Dunlap wrote:
>> When CONFIG_OF_EARLY_FLATTREE and CONFIG_SH_DEVICE_TREE are not set,
>> SH3 build fails with a call to early_init_dt_scan(), so add a stub for
>> this function.
>>
>> ../arch/sh/kernel/setup.c: In function 'sh_fdt_init':
>> ../arch/sh/kernel/setup.c:262:26: error: implicit declaration of function 'early_init_dt_scan' [-Werror=implicit-function-declaration]
>> 262 | if (!dt_virt || !early_init_dt_scan(dt_virt)) {
>
> I think that sh_fdt_init() needs to be enclosed in
> CONFIG_OF_EARLY_FLATTREE instead of CONFIG_OF_FLATTREE.
>
OK, I'll try that. Thanks.
>>
>> Fixes: 7480e0aabd5f ("sh: add device tree support and generic board using device tree")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Frank Rowand <frowand.list@gmail.com>
>> Cc: devicetree@vger.kernel.org
>> Cc: Rich Felker <dalias@libc.org>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> ---
>> include/linux/of_fdt.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- a/include/linux/of_fdt.h
>> +++ b/include/linux/of_fdt.h
>> @@ -85,6 +85,7 @@ extern void early_init_devtree(void *);
>> extern void early_get_first_memblock_info(void *, phys_addr_t *);
>> #else /* CONFIG_OF_EARLY_FLATTREE */
>> static inline void early_init_dt_check_for_usable_mem_range(void) {}
>> +static inline bool early_init_dt_scan(void *params) { return false; }
>> static inline int early_init_dt_scan_chosen_stdout(void) { return -ENODEV; }
>> static inline void early_init_fdt_scan_reserved_mem(void) {}
>> static inline void early_init_fdt_reserve_self(void) {}
>>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-06 19:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 3:11 [PATCH] of: fdt: add stub for early_init_dt_scan() Randy Dunlap
2022-10-06 19:38 ` Rob Herring
2022-10-06 19:43 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).