From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: omap: n900: drop enable-gpios from LED nodes
Date: Fri, 25 Nov 2022 18:36:02 +0100 [thread overview]
Message-ID: <20221125173602.cnipos5oo4ncxsac@mercury.elektranox.org> (raw)
In-Reply-To: <20221125144150.477290-2-krzysztof.kozlowski@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
Hi,
On Fri, Nov 25, 2022 at 03:41:50PM +0100, Krzysztof Kozlowski wrote:
> LP5523 LED controller does not take enable-gpios property:
>
> omap3-n900.dtb: lp5523@32: 'enable-gpios' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
The drivers uses it via devm_gpiod_get_optional() and the binding has this:
grep -A3 enable-gpio Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
enable-gpio:
maxItems: 1
description: |
GPIO attached to the chip's enable pin
-- Sebastian
> arch/arm/boot/dts/omap3-n900.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index ba35cff5b01e..5e78dc990725 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -636,7 +636,6 @@ lp5523: lp5523@32 {
> compatible = "national,lp5523";
> reg = <0x32>;
> clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */
> - enable-gpios = <&gpio2 9 GPIO_ACTIVE_HIGH>; /* 41 */
>
> led@0 {
> reg = <0>;
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-25 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 14:41 [PATCH 1/2] ARM: dts: omap: align LED node names with dtschema Krzysztof Kozlowski
2022-11-25 14:41 ` [PATCH 2/2] ARM: dts: omap: n900: drop enable-gpios from LED nodes Krzysztof Kozlowski
2022-11-25 17:36 ` Sebastian Reichel [this message]
2022-11-26 14:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125173602.cnipos5oo4ncxsac@mercury.elektranox.org \
--to=sebastian.reichel@collabora.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).