From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: omap: n900: drop enable-gpios from LED nodes
Date: Sat, 26 Nov 2022 15:21:10 +0100 [thread overview]
Message-ID: <bdfa865b-ce2c-ad8a-375f-9e3114ef9597@linaro.org> (raw)
In-Reply-To: <20221125173602.cnipos5oo4ncxsac@mercury.elektranox.org>
On 25/11/2022 18:36, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Nov 25, 2022 at 03:41:50PM +0100, Krzysztof Kozlowski wrote:
>> LP5523 LED controller does not take enable-gpios property:
>>
>> omap3-n900.dtb: lp5523@32: 'enable-gpios' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>
> The drivers uses it via devm_gpiod_get_optional() and the binding has this:
>
> grep -A3 enable-gpio Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> enable-gpio:
> maxItems: 1
> description: |
> GPIO attached to the chip's enable pin
>
> -- Sebastian
Oh, thanks, I am pretty sure i was checking it but maybe I looked at
wrong driver :(.
I'll fix it in different way.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-26 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 14:41 [PATCH 1/2] ARM: dts: omap: align LED node names with dtschema Krzysztof Kozlowski
2022-11-25 14:41 ` [PATCH 2/2] ARM: dts: omap: n900: drop enable-gpios from LED nodes Krzysztof Kozlowski
2022-11-25 17:36 ` Sebastian Reichel
2022-11-26 14:21 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdfa865b-ce2c-ad8a-375f-9e3114ef9597@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).