From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Suman Anna <s-anna@ti.com>,
Roger Quadros <rogerq@kernel.org>,
"Andrew F . Davis" <afd@ti.com>,
nm@ti.com, vigneshr@ti.com, srk@ti.com,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v13 2/6] remoteproc: pru: Add enum for PRU Core Identifiers.
Date: Thu, 5 Jan 2023 13:23:56 -0700 [thread overview]
Message-ID: <20230105202356.GA2281956@p14s> (raw)
In-Reply-To: <20230105092149.686201-3-danishanwar@ti.com>
On Thu, Jan 05, 2023 at 02:51:45PM +0530, MD Danish Anwar wrote:
> Introducing enum pruss_pru_id for PRU Core Identifiers.
> PRUSS_PRU0 indicates PRU Core 0.
> PRUSS_PRU1 indicates PRU Core 1.
> PRUSS_NUM_PRUS indicates the total number of PRU Cores.
>
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> ---
> drivers/remoteproc/pru_rproc.c | 7 ++++---
> include/linux/pruss.h | 31 +++++++++++++++++++++++++++++++
Please add this under include/linux/remoteproc/ to avoid adding an orphan file
under include/linux/.
Thanks,
Mathieu
> 2 files changed, 35 insertions(+), 3 deletions(-)
> create mode 100644 include/linux/pruss.h
>
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index 128bf9912f2c..a1a208b31846 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -16,6 +16,7 @@
> #include <linux/module.h>
> #include <linux/of_device.h>
> #include <linux/of_irq.h>
> +#include <linux/pruss.h>
> #include <linux/pruss_driver.h>
> #include <linux/remoteproc.h>
>
> @@ -438,7 +439,7 @@ static void *pru_d_da_to_va(struct pru_rproc *pru, u32 da, size_t len)
> dram0 = pruss->mem_regions[PRUSS_MEM_DRAM0];
> dram1 = pruss->mem_regions[PRUSS_MEM_DRAM1];
> /* PRU1 has its local RAM addresses reversed */
> - if (pru->id == 1)
> + if (pru->id == PRUSS_PRU1)
> swap(dram0, dram1);
> shrd_ram = pruss->mem_regions[PRUSS_MEM_SHRD_RAM2];
>
> @@ -747,14 +748,14 @@ static int pru_rproc_set_id(struct pru_rproc *pru)
> case RTU0_IRAM_ADDR_MASK:
> fallthrough;
> case PRU0_IRAM_ADDR_MASK:
> - pru->id = 0;
> + pru->id = PRUSS_PRU0;
> break;
> case TX_PRU1_IRAM_ADDR_MASK:
> fallthrough;
> case RTU1_IRAM_ADDR_MASK:
> fallthrough;
> case PRU1_IRAM_ADDR_MASK:
> - pru->id = 1;
> + pru->id = PRUSS_PRU1;
> break;
> default:
> ret = -EINVAL;
> diff --git a/include/linux/pruss.h b/include/linux/pruss.h
> new file mode 100644
> index 000000000000..e94a81e97a4c
> --- /dev/null
> +++ b/include/linux/pruss.h
> @@ -0,0 +1,31 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/**
> + * PRU-ICSS Subsystem user interfaces
> + *
> + * Copyright (C) 2015-2022 Texas Instruments Incorporated - http://www.ti.com
> + * Suman Anna <s-anna@ti.com>
> + */
> +
> +#ifndef __LINUX_PRUSS_H
> +#define __LINUX_PRUSS_H
> +
> +#include <linux/device.h>
> +#include <linux/types.h>
> +
> +#define PRU_RPROC_DRVNAME "pru-rproc"
> +
> +/**
> + * enum pruss_pru_id - PRU core identifiers
> + * @PRUSS_PRU0: PRU Core 0.
> + * @PRUSS_PRU1: PRU Core 1.
> + * @PRUSS_NUM_PRUS: Total number of PRU Cores available.
> + *
> + */
> +
> +enum pruss_pru_id {
> + PRUSS_PRU0 = 0,
> + PRUSS_PRU1,
> + PRUSS_NUM_PRUS,
> +};
> +
> +#endif /* __LINUX_PRUSS_H */
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-01-05 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 9:21 [PATCH v13 0/6] Introduce PRU remoteproc consumer API MD Danish Anwar
2023-01-05 9:21 ` [PATCH v13 1/6] dt-bindings: remoteproc: Add PRU consumer bindings MD Danish Anwar
2023-01-05 9:21 ` [PATCH v13 2/6] remoteproc: pru: Add enum for PRU Core Identifiers MD Danish Anwar
2023-01-05 20:23 ` Mathieu Poirier [this message]
2023-01-06 12:02 ` [EXTERNAL] " Md Danish Anwar
2023-01-05 9:21 ` [PATCH v13 3/6] remoteproc: pru: Add APIs to get and put the PRU cores MD Danish Anwar
2023-01-05 9:21 ` [PATCH v13 4/6] remoteproc: pru: Make sysfs entries read-only for PRU client driven boots MD Danish Anwar
2023-01-05 9:21 ` [PATCH v13 5/6] remoteproc: pru: Add pru_rproc_set_ctable() function MD Danish Anwar
2023-01-05 9:21 ` [PATCH v13 6/6] remoteproc: pru: Configure firmware based on client setup MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105202356.GA2281956@p14s \
--to=mathieu.poirier@linaro.org \
--cc=afd@ti.com \
--cc=danishanwar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=s-anna@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).