* [PATCH] apalis_t30: fix can2
@ 2018-06-25 7:59 Marcel Ziswiler
2018-07-23 8:16 ` Marc Kleine-Budde
0 siblings, 1 reply; 3+ messages in thread
From: Marcel Ziswiler @ 2018-06-25 7:59 UTC (permalink / raw)
To: linux-tegra, linux-can
Cc: Marcel Ziswiler, devicetree, Thierry Reding, Jonathan Hunter,
linux-kernel, Rob Herring, Mark Rutland
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
CAN2 currently fails on probe as follows:
mcp251x spi1.1: Probe failed, err=19
Fix this by enabling input on pin mux of resp. SPI4 pins.
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
arch/arm/boot/dts/tegra30-apalis.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
index d1d21ec2a844..9ff6aafd72b3 100644
--- a/arch/arm/boot/dts/tegra30-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
@@ -118,6 +118,7 @@
nvidia,function = "spi4";
nvidia,pull = <TEGRA_PIN_PULL_NONE>;
nvidia,tristate = <TEGRA_PIN_DISABLE>;
+ nvidia,enable-input = <TEGRA_PIN_ENABLE>;
};
/* CAN_INT2 */
spi2_cs2_n_pw3 {
--
2.14.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] apalis_t30: fix can2
2018-06-25 7:59 [PATCH] apalis_t30: fix can2 Marcel Ziswiler
@ 2018-07-23 8:16 ` Marc Kleine-Budde
2018-07-23 10:18 ` Marc Kleine-Budde
0 siblings, 1 reply; 3+ messages in thread
From: Marc Kleine-Budde @ 2018-07-23 8:16 UTC (permalink / raw)
To: Marcel Ziswiler, linux-tegra, linux-can
Cc: Marcel Ziswiler, devicetree, Thierry Reding, Jonathan Hunter,
linux-kernel, Rob Herring, Mark Rutland
[-- Attachment #1.1: Type: text/plain, Size: 1282 bytes --]
On 06/25/2018 09:59 AM, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> CAN2 currently fails on probe as follows:
>
> mcp251x spi1.1: Probe failed, err=19
>
> Fix this by enabling input on pin mux of resp. SPI4 pins.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
I can take this via the linux-can tree. Any acks from the DT people?
Marc
>
> ---
>
> arch/arm/boot/dts/tegra30-apalis.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
> index d1d21ec2a844..9ff6aafd72b3 100644
> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
> @@ -118,6 +118,7 @@
> nvidia,function = "spi4";
> nvidia,pull = <TEGRA_PIN_PULL_NONE>;
> nvidia,tristate = <TEGRA_PIN_DISABLE>;
> + nvidia,enable-input = <TEGRA_PIN_ENABLE>;
> };
> /* CAN_INT2 */
> spi2_cs2_n_pw3 {
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] apalis_t30: fix can2
2018-07-23 8:16 ` Marc Kleine-Budde
@ 2018-07-23 10:18 ` Marc Kleine-Budde
0 siblings, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2018-07-23 10:18 UTC (permalink / raw)
To: Marcel Ziswiler, linux-tegra, linux-can
Cc: Marcel Ziswiler, devicetree, Thierry Reding, Jonathan Hunter,
linux-kernel, Rob Herring, Mark Rutland
[-- Attachment #1.1: Type: text/plain, Size: 883 bytes --]
On 07/23/2018 10:16 AM, Marc Kleine-Budde wrote:
> On 06/25/2018 09:59 AM, Marcel Ziswiler wrote:
>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>
>> CAN2 currently fails on probe as follows:
>>
>> mcp251x spi1.1: Probe failed, err=19
>>
>> Fix this by enabling input on pin mux of resp. SPI4 pins.
>>
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> I can take this via the linux-can tree. Any acks from the DT people?
Never mind - it has been applied by Thierry menawhile:
> Applied to for-4.19/arm/dt, thanks.
>
> Thierry
sorry for the noise.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-23 10:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-25 7:59 [PATCH] apalis_t30: fix can2 Marcel Ziswiler
2018-07-23 8:16 ` Marc Kleine-Budde
2018-07-23 10:18 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).