From: Michal Simek <michal.simek@xilinx.com>
To: Michael Tretter <m.tretter@pengutronix.de>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<dmaengine@vger.kernel.org>
Cc: <robh+dt@kernel.org>, <michal.simek@xilinx.com>, <kernel@pengutronix.de>
Subject: Re: [PATCH 2/3] arm64: zynqmp: Add missing #dma-cells property
Date: Mon, 24 Jan 2022 13:18:06 +0100 [thread overview]
Message-ID: <31b2312c-ce95-a1c3-6d52-710a28af2741@xilinx.com> (raw)
In-Reply-To: <20220112151541.1328732-3-m.tretter@pengutronix.de>
On 1/12/22 16:15, Michael Tretter wrote:
> Requesting the dma controllers fails if #dma-cells is not defined. Add
> the missing property.
>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 493719f71fb5..6d96b6b99f84 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -261,6 +261,7 @@ fpd_dma_chan1: dma@fd500000 {
> interrupt-parent = <&gic>;
> interrupts = <0 124 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <128>;
> iommus = <&smmu 0x14e8>;
> power-domains = <&zynqmp_firmware PD_GDMA>;
> @@ -273,6 +274,7 @@ fpd_dma_chan2: dma@fd510000 {
> interrupt-parent = <&gic>;
> interrupts = <0 125 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <128>;
> iommus = <&smmu 0x14e9>;
> power-domains = <&zynqmp_firmware PD_GDMA>;
> @@ -285,6 +287,7 @@ fpd_dma_chan3: dma@fd520000 {
> interrupt-parent = <&gic>;
> interrupts = <0 126 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <128>;
> iommus = <&smmu 0x14ea>;
> power-domains = <&zynqmp_firmware PD_GDMA>;
> @@ -297,6 +300,7 @@ fpd_dma_chan4: dma@fd530000 {
> interrupt-parent = <&gic>;
> interrupts = <0 127 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <128>;
> iommus = <&smmu 0x14eb>;
> power-domains = <&zynqmp_firmware PD_GDMA>;
> @@ -309,6 +313,7 @@ fpd_dma_chan5: dma@fd540000 {
> interrupt-parent = <&gic>;
> interrupts = <0 128 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <128>;
> iommus = <&smmu 0x14ec>;
> power-domains = <&zynqmp_firmware PD_GDMA>;
> @@ -321,6 +326,7 @@ fpd_dma_chan6: dma@fd550000 {
> interrupt-parent = <&gic>;
> interrupts = <0 129 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <128>;
> iommus = <&smmu 0x14ed>;
> power-domains = <&zynqmp_firmware PD_GDMA>;
> @@ -333,6 +339,7 @@ fpd_dma_chan7: dma@fd560000 {
> interrupt-parent = <&gic>;
> interrupts = <0 130 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <128>;
> iommus = <&smmu 0x14ee>;
> power-domains = <&zynqmp_firmware PD_GDMA>;
> @@ -345,6 +352,7 @@ fpd_dma_chan8: dma@fd570000 {
> interrupt-parent = <&gic>;
> interrupts = <0 131 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <128>;
> iommus = <&smmu 0x14ef>;
> power-domains = <&zynqmp_firmware PD_GDMA>;
> @@ -374,6 +382,7 @@ lpd_dma_chan1: dma@ffa80000 {
> interrupt-parent = <&gic>;
> interrupts = <0 77 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <64>;
> iommus = <&smmu 0x868>;
> power-domains = <&zynqmp_firmware PD_ADMA>;
> @@ -386,6 +395,7 @@ lpd_dma_chan2: dma@ffa90000 {
> interrupt-parent = <&gic>;
> interrupts = <0 78 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <64>;
> iommus = <&smmu 0x869>;
> power-domains = <&zynqmp_firmware PD_ADMA>;
> @@ -398,6 +408,7 @@ lpd_dma_chan3: dma@ffaa0000 {
> interrupt-parent = <&gic>;
> interrupts = <0 79 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <64>;
> iommus = <&smmu 0x86a>;
> power-domains = <&zynqmp_firmware PD_ADMA>;
> @@ -410,6 +421,7 @@ lpd_dma_chan4: dma@ffab0000 {
> interrupt-parent = <&gic>;
> interrupts = <0 80 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <64>;
> iommus = <&smmu 0x86b>;
> power-domains = <&zynqmp_firmware PD_ADMA>;
> @@ -422,6 +434,7 @@ lpd_dma_chan5: dma@ffac0000 {
> interrupt-parent = <&gic>;
> interrupts = <0 81 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <64>;
> iommus = <&smmu 0x86c>;
> power-domains = <&zynqmp_firmware PD_ADMA>;
> @@ -434,6 +447,7 @@ lpd_dma_chan6: dma@ffad0000 {
> interrupt-parent = <&gic>;
> interrupts = <0 82 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <64>;
> iommus = <&smmu 0x86d>;
> power-domains = <&zynqmp_firmware PD_ADMA>;
> @@ -446,6 +460,7 @@ lpd_dma_chan7: dma@ffae0000 {
> interrupt-parent = <&gic>;
> interrupts = <0 83 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <64>;
> iommus = <&smmu 0x86e>;
> power-domains = <&zynqmp_firmware PD_ADMA>;
> @@ -458,6 +473,7 @@ lpd_dma_chan8: dma@ffaf0000 {
> interrupt-parent = <&gic>;
> interrupts = <0 84 4>;
> clock-names = "clk_main", "clk_apb";
> + #dma-cells = <1>;
> xlnx,bus-width = <64>;
> iommus = <&smmu 0x86f>;
> power-domains = <&zynqmp_firmware PD_ADMA>;
Applied.
M
next prev parent reply other threads:[~2022-01-24 12:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 15:15 [PATCH 0/3] dt-bindings: dmaengine: zynqmp_dma: Convert binding to YAML Michael Tretter
2022-01-12 15:15 ` [PATCH 1/3] dt-bindings: dmaengine: zynqmp_dma: convert to yaml Michael Tretter
2022-01-22 0:59 ` Rob Herring
2022-01-12 15:15 ` [PATCH 2/3] arm64: zynqmp: Add missing #dma-cells property Michael Tretter
2022-01-24 12:18 ` Michal Simek [this message]
2022-01-12 15:15 ` [PATCH 3/3] arm64: zynqmp: Rename dma to dma-controller Michael Tretter
2022-01-24 12:18 ` Michal Simek
2022-01-21 10:16 ` [PATCH 0/3] dt-bindings: dmaengine: zynqmp_dma: Convert binding to YAML Harini Katakam
2022-01-21 11:58 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31b2312c-ce95-a1c3-6d52-710a28af2741@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=m.tretter@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).