From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Adamski <krzysztof.adamski@nokia.com>,
Jean Delvare <jdelvare@suse.com>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 8/8] dt-bindings: hwmon: allow specifying channels for tmp421
Date: Tue, 7 Sep 2021 08:46:53 -0700 [thread overview]
Message-ID: <3743f9f4-f8c5-acd5-2422-2bbdb2dd7d72@roeck-us.net> (raw)
In-Reply-To: <12984255aac11a3edfc0e6278e1a1cac70ce97ec.1631021349.git.krzysztof.adamski@nokia.com>
On 9/7/21 6:46 AM, Krzysztof Adamski wrote:
> Add binding description for the per temperature channel configuration
> like labels and n-factor.
>
> Signed-off-by: Krzysztof Adamski <krzysztof.adamski@nokia.com>
Up to Rob to decide, but it seems to me that can be squashed with the other
dt patch in the series (which on its own doesn't really add much value).
Guenter
> ---
> .../devicetree/bindings/hwmon/tmp421.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/tmp421.yaml b/Documentation/devicetree/bindings/hwmon/tmp421.yaml
> index 53940e146ee6..56085fdf1b57 100644
> --- a/Documentation/devicetree/bindings/hwmon/tmp421.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/tmp421.yaml
> @@ -24,12 +24,49 @@ properties:
> reg:
> maxItems: 1
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> required:
> - compatible
> - reg
>
> additionalProperties: false
>
> +patternProperties:
> + "^input@([0-4])$":
> + type: object
> + description: |
> + Represents channels of the device and their specific configuration.
> +
> + properties:
> + reg:
> + description: |
> + The channel number. 0 is local channel, 1-4 are remote channels
> + items:
> + minimum: 0
> + maximum: 4
> +
> + label:
> + description: |
> + A descriptive name for this channel, like "ambient" or "psu".
> +
> + n-factor:
> + description: |
> + The value (two's complement) to be programmed in the channel specific N correction register.
> + For remote channels only.
> + items:
> + minimum: 0
> + maximum: 1
> +
> + required:
> + - reg
> +
> + additionalProperties: false
> +
> examples:
> - |
> i2c {
> @@ -41,3 +78,32 @@ examples:
> reg = <0x4c>;
> };
> };
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sensor@4c {
> + compatible = "ti,tmp422";
> + reg = <0x4c>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + input@0 {
> + reg = <0x0>;
> + n-factor = <0x1>;
> + label = "local";
> + };
> +
> + input@1 {
> + reg = <0x1>;
> + n-factor = <0x0>;
> + label = "somelabel";
> + };
> +
> + input@2 {
> + reg = <0x2>;
> + status = "disabled";
> + };
> + };
> + };
>
next prev parent reply other threads:[~2021-09-07 15:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 13:41 [PATCH 0/8] Add per channel properies support in tmp421 Krzysztof Adamski
2021-09-07 13:42 ` [PATCH 1/8] dt-bindings: hwmon: add missing tmp421 binding Krzysztof Adamski
2021-09-20 22:21 ` Rob Herring
2021-09-07 13:42 ` [PATCH 2/8] hwmon: (tmp421) introduce MAX_CHANNELS define Krzysztof Adamski
2021-09-07 13:43 ` [PATCH 3/8] hwmon: (tmp421) introduce a channel struct Krzysztof Adamski
2021-09-07 13:43 ` [PATCH 4/8] hwmon: (tmp421) add support for defining labels from DT Krzysztof Adamski
2021-09-07 15:46 ` Guenter Roeck
2021-09-07 17:49 ` Krzysztof Adamski
2021-09-07 17:55 ` Guenter Roeck
2021-09-07 18:08 ` Krzysztof Adamski
2021-09-07 18:28 ` kernel test robot
2021-09-09 17:29 ` kernel test robot
2021-09-09 17:29 ` [RFC PATCH] hwmon: tmp421_probe_child_from_dt() can be static kernel test robot
2021-09-07 13:43 ` [PATCH 5/8] hwmon: (tmp421) support disabling channels from DT Krzysztof Adamski
2021-09-07 15:33 ` Guenter Roeck
2021-09-07 13:45 ` [PATCH 6/8] hwmon: (tmp421) support specifying n-factor via DT Krzysztof Adamski
2021-09-07 15:42 ` Guenter Roeck
2021-09-07 13:46 ` [PATCH 7/8] hwmon: (tmp421) really disable channels Krzysztof Adamski
2021-09-07 15:37 ` Guenter Roeck
2021-09-07 19:52 ` kernel test robot
2021-09-09 20:40 ` kernel test robot
2021-09-09 20:40 ` [RFC PATCH] hwmon: tmp421_disable_channels() can be static kernel test robot
2021-09-07 13:46 ` [PATCH 8/8] dt-bindings: hwmon: allow specifying channels for tmp421 Krzysztof Adamski
2021-09-07 15:46 ` Guenter Roeck [this message]
2021-09-07 18:04 ` Krzysztof Adamski
2021-09-20 22:24 ` Rob Herring
2021-09-21 12:58 ` Guenter Roeck
2021-09-21 19:06 ` Rob Herring
2021-09-21 20:52 ` Guenter Roeck
2021-09-21 21:21 ` Oskar Senft
2021-09-21 22:03 ` Oskar Senft
2021-09-23 15:30 ` Rob Herring
2021-09-24 0:29 ` Guenter Roeck
2021-09-24 7:53 ` Krzysztof Adamski
2021-09-24 11:46 ` Guenter Roeck
2021-09-24 15:37 ` Oskar Senft
2021-09-25 13:26 ` Guenter Roeck
2021-10-08 12:55 ` Oskar Senft
2021-10-08 13:11 ` Guenter Roeck
2021-09-22 7:22 ` Krzysztof Adamski
2021-09-22 12:39 ` Guenter Roeck
2021-09-22 18:32 ` Krzysztof Adamski
2021-09-23 0:38 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3743f9f4-f8c5-acd5-2422-2bbdb2dd7d72@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.adamski@nokia.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).