From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: PCI schema accepts unevaluated properties
Date: Sat, 23 Apr 2022 12:46:39 +0200 [thread overview]
Message-ID: <42fbcb55-b6ef-906f-7584-62a6097a8639@linaro.org> (raw)
Hi Rob,
Dmitry pointed out interesting issue when writing PCI schema. Consider
the patch for Exynos PCI schema (which includes SNPS schema and
unevaluatedProperties:false):
https://pastebin.ubuntu.com/p/4SzxVP4N3j/
This passes `make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/pci/` without a
problem. It should not. The property is nowhere described, so
unevaluatedProperties should scream.
Other bindings using unevaluated:false and some ref, also has this
issue. The additionalProperties:false (when there is no ref for other
schema) works correct.
DT schema v2022.3.2.
Best regards,
Krzysztof
next reply other threads:[~2022-04-23 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 10:46 Krzysztof Kozlowski [this message]
2022-04-27 2:36 ` PCI schema accepts unevaluated properties Rob Herring
2022-04-27 6:29 ` Krzysztof Kozlowski
2022-04-27 14:53 ` Rob Herring
2022-04-27 15:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42fbcb55-b6ef-906f-7584-62a6097a8639@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).