devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: PCI schema accepts unevaluated properties
Date: Wed, 27 Apr 2022 17:04:33 +0200	[thread overview]
Message-ID: <fedb56be-f275-aabb-cdf5-dbd394b8a7bd@linaro.org> (raw)
In-Reply-To: <CAL_Jsq+d-RHNnTyy+mrs2L7Zycjwq07vENCH8+SHZBuZGCuq=A@mail.gmail.com>

On 27/04/2022 16:53, Rob Herring wrote:
>> I'll fix the power-domains, but dma-channels/dma-requests should not
>> fail. This should be accepted through:
>> arm,pl330.yaml -> dma-controller.yaml -> dma-common.yaml
> 
> Except that the standard property names are 'dma-channels' and
> 'dma-requests' without the '#'.
> 
> Thanks for the fixes. Unfortunately, it looks like NAND needs the same
> parent/child schema split that was done for SPI.

Oh, few drivers indeed parse '#dma-xxx' variant. For pl330 schema it was
introduced with 42cf20980cde ("ARM: dts: pl330: Add #dma-cells for
generic dma binding support")
 which clearly defines something different than uses in example. I can
imagine that editor added '#' automatically after pressing <enter> when
editing the example.

This wrong variant spread all over and in practice was not detected
because pl330 driver does not parse this field.

I'll fix it.

Best regards,
Krzysztof

      reply	other threads:[~2022-04-27 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-23 10:46 PCI schema accepts unevaluated properties Krzysztof Kozlowski
2022-04-27  2:36 ` Rob Herring
2022-04-27  6:29   ` Krzysztof Kozlowski
2022-04-27 14:53     ` Rob Herring
2022-04-27 15:04       ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fedb56be-f275-aabb-cdf5-dbd394b8a7bd@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).