From: Yunus Bas <Y.Bas@phytec.de>
To: "shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH 1/3] ARM: dts: imx6qdl: phytec: Add support for optional PEB-EVAL-01 board
Date: Mon, 13 Dec 2021 11:34:22 +0000 [thread overview]
Message-ID: <4b8ee4ab7ca758ea20ff535689665e96db9d012e.camel@phytec.de> (raw)
In-Reply-To: <20211206024433.GW4216@dragon>
Hi Shawn,
Sorry for the late response. I was sick for the whole week.
Am Montag, dem 06.12.2021 um 10:44 +0800 schrieb Shawn Guo:
> On Tue, Nov 30, 2021 at 09:53:53AM +0100, Yunus Bas wrote:
> > The PHYTEC PEV-EVAL-01 expansion board adds support for additional
> > gpio-triggered user-leds and gpio-key support.
> >
> > Signed-off-by: Yunus Bas <y.bas@phytec.de>
> > ---
> > .../boot/dts/imx6dl-phytec-mira-rdk-nand.dts | 1 +
> > .../boot/dts/imx6q-phytec-mira-rdk-emmc.dts | 1 +
> > .../boot/dts/imx6q-phytec-mira-rdk-nand.dts | 1 +
> > .../dts/imx6qdl-phytec-mira-peb-eval-01.dtsi | 71
> > +++++++++++++++++++
> > .../boot/dts/imx6qp-phytec-mira-rdk-nand.dts | 1 +
> > 5 files changed, 75 insertions(+)
> > create mode 100644 arch/arm/boot/dts/imx6qdl-phytec-mira-peb-eval-
> > 01.dtsi
> >
> > diff --git a/arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dts
> > b/arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dts
> > index 9f7f9f98139d..b057fa664a6b 100644
> > --- a/arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dts
> > +++ b/arch/arm/boot/dts/imx6dl-phytec-mira-rdk-nand.dts
> > @@ -8,6 +8,7 @@
> > #include "imx6dl.dtsi"
> > #include "imx6qdl-phytec-phycore-som.dtsi"
> > #include "imx6qdl-phytec-mira.dtsi"
> > +#include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
> >
> > / {
> > model = "PHYTEC phyBOARD-Mira DualLite/Solo Carrier-Board
> > with NAND";
> > diff --git a/arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dts
> > b/arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dts
> > index 2e70ea5623c6..db6e2cc36759 100644
> > --- a/arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dts
> > +++ b/arch/arm/boot/dts/imx6q-phytec-mira-rdk-emmc.dts
> > @@ -8,6 +8,7 @@
> > #include "imx6q.dtsi"
> > #include "imx6qdl-phytec-phycore-som.dtsi"
> > #include "imx6qdl-phytec-mira.dtsi"
> > +#include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
> >
> > / {
> > model = "PHYTEC phyBOARD-Mira Quad Carrier-Board with
> > eMMC";
> > diff --git a/arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dts
> > b/arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dts
> > index 65d2e483c136..51ff601b1aec 100644
> > --- a/arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dts
> > +++ b/arch/arm/boot/dts/imx6q-phytec-mira-rdk-nand.dts
> > @@ -8,6 +8,7 @@
> > #include "imx6q.dtsi"
> > #include "imx6qdl-phytec-phycore-som.dtsi"
> > #include "imx6qdl-phytec-mira.dtsi"
> > +#include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
> >
> > / {
> > model = "PHYTEC phyBOARD-Mira Quad Carrier-Board with
> > NAND";
> > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-mira-peb-eval-01.dtsi
> > b/arch/arm/boot/dts/imx6qdl-phytec-mira-peb-eval-01.dtsi
> > new file mode 100644
> > index 000000000000..3bcad402d3ec
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6qdl-phytec-mira-peb-eval-01.dtsi
> > @@ -0,0 +1,71 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (C) 2018 PHYTEC Messtechnik
> > + * Author: Christian Hemp <c.hemp@phytec.de>
> > + */
> > +
> > +#include <dt-bindings/input/input.h>
> > +
> > +/ {
> > + gpio-keys {
> > + compatible = "gpio-keys";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_gpio_keys>;
> > + status = "disabled";
> > +
> > + home {
> > + label = "Home";
> > + gpios = <&gpio6 18 GPIO_ACTIVE_LOW>;
> > + linux,code = <KEY_SLEEP>;
>
> KEY_SLEEP for Home?
I'll change the node name and label in v2
>
> Shawn
>
> > + };
> > +
> > + power {
> > + label = "Power Button";
> > + gpios = <&gpio5 28 GPIO_ACTIVE_LOW>;
> > + linux,code = <KEY_WAKEUP>;
> > + wakeup-source;
> > + };
> > + };
> > +
> > + user_leds: user-leds {
> > + compatible = "gpio-leds";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_user_leds>;
> > + status = "disabled";
> > +
> > + user-led1 {
> > + gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
> > + linux,default-trigger = "gpio";
> > + default-state = "on";
> > + };
> > +
> > + user-led2 {
> > + gpios = <&gpio7 0 GPIO_ACTIVE_HIGH>;
> > + linux,default-trigger = "gpio";
> > + default-state = "on";
> > + };
> > +
> > + user-led3 {
> > + gpios = <&gpio5 29 GPIO_ACTIVE_HIGH>;
> > + linux,default-trigger = "gpio";
> > + default-state = "on";
> > + };
> > + };
> > +};
> > +
> > +&iomuxc {
> > + pinctrl_gpio_keys: gpiokeysgrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_SD3_DAT6__GPIO6_IO18 0x1
> > b0b0
> > + MX6QDL_PAD_CSI0_DAT10__GPIO5_IO28 0x1
> > b0b0
> > + >;
> > + };
> > +
> > + pinctrl_user_leds: userledsgrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x1
> > b0b0
> > + MX6QDL_PAD_SD3_DAT5__GPIO7_IO00 0x1
> > b0b0
> > + MX6QDL_PAD_CSI0_DAT11__GPIO5_IO29 0x1
> > b0b0
> > + >;
> > + };
> > +};
> > diff --git a/arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dts
> > b/arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dts
> > index f27d7ab42626..06fe0c5315fc 100644
> > --- a/arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dts
> > +++ b/arch/arm/boot/dts/imx6qp-phytec-mira-rdk-nand.dts
> > @@ -8,6 +8,7 @@
> > #include "imx6qp.dtsi"
> > #include "imx6qdl-phytec-phycore-som.dtsi"
> > #include "imx6qdl-phytec-mira.dtsi"
> > +#include "imx6qdl-phytec-mira-peb-eval-01.dtsi"
> >
> > / {
> > model = "PHYTEC phyBOARD-Mira QuadPlus Carrier-Board with
> > NAND";
> > --
> > 2.25.1
> >
prev parent reply other threads:[~2021-12-13 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 8:53 [PATCH 1/3] ARM: dts: imx6qdl: phytec: Add support for optional PEB-EVAL-01 board Yunus Bas
2021-11-30 8:53 ` [PATCH 2/3] ARM: dts: imx6qdl: phytec: Add support for optional PEB-AV-02 LCD adapter Yunus Bas
2021-12-06 2:49 ` Shawn Guo
2021-12-13 11:40 ` Yunus Bas
2021-11-30 8:53 ` [PATCH 3/3] ARM: dts: imx6: phytec: Add PEB-WLBT-05 support Yunus Bas
2021-12-06 2:57 ` Shawn Guo
2021-12-13 12:21 ` Yunus Bas
2021-12-06 2:44 ` [PATCH 1/3] ARM: dts: imx6qdl: phytec: Add support for optional PEB-EVAL-01 board Shawn Guo
2021-12-13 11:34 ` Yunus Bas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b8ee4ab7ca758ea20ff535689665e96db9d012e.camel@phytec.de \
--to=y.bas@phytec.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).