* [PATCH net] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC
@ 2020-11-01 13:19 Michael Walle
2020-11-01 13:43 ` Michael Walle
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Michael Walle @ 2020-11-01 13:19 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Jakub Kicinski, Claudiu Manoil,
Ioana Ciornei, Michael Walle, Vladimir Oltean
Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the
network port of the Kontron sl28 board is broken. After the migration to
phylink the device tree has to specify the in-band-mode property. Add
it.
Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index f46eb47cfa4d..8161dd237971 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -75,6 +75,7 @@
&enetc_port0 {
phy-handle = <&phy0>;
phy-connection-type = "sgmii";
+ managed = "in-band-status";
status = "okay";
mdio {
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC
2020-11-01 13:19 [PATCH net] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC Michael Walle
@ 2020-11-01 13:43 ` Michael Walle
2020-11-01 16:32 ` Vladimir Oltean
2020-11-08 18:00 ` Michael Walle
2 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2020-11-01 13:43 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Jakub Kicinski, Claudiu Manoil,
Vladimir Oltean, Ioana Ciornei, Ioana Ciornei
[+Ioana; the reference commit has a typo in her email address]
Am 2020-11-01 14:19, schrieb Michael Walle:
> Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> the
> network port of the Kontron sl28 board is broken. After the migration
> to
> phylink the device tree has to specify the in-band-mode property. Add
> it.
>
> Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index f46eb47cfa4d..8161dd237971 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -75,6 +75,7 @@
> &enetc_port0 {
> phy-handle = <&phy0>;
> phy-connection-type = "sgmii";
> + managed = "in-band-status";
> status = "okay";
>
> mdio {
--
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC
2020-11-01 13:19 [PATCH net] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC Michael Walle
2020-11-01 13:43 ` Michael Walle
@ 2020-11-01 16:32 ` Vladimir Oltean
2020-11-08 18:00 ` Michael Walle
2 siblings, 0 replies; 6+ messages in thread
From: Vladimir Oltean @ 2020-11-01 16:32 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Shawn Guo, Leo Li,
Jakub Kicinski, Claudiu Manoil, Ioana Ciornei
On Sun, Nov 01, 2020 at 02:19:05PM +0100, Michael Walle wrote:
> Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the
> network port of the Kontron sl28 board is broken. After the migration to
> phylink the device tree has to specify the in-band-mode property. Add
> it.
>
> Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index f46eb47cfa4d..8161dd237971 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -75,6 +75,7 @@
> &enetc_port0 {
> phy-handle = <&phy0>;
> phy-connection-type = "sgmii";
> + managed = "in-band-status";
> status = "okay";
>
> mdio {
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC
2020-11-01 13:19 [PATCH net] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC Michael Walle
2020-11-01 13:43 ` Michael Walle
2020-11-01 16:32 ` Vladimir Oltean
@ 2020-11-08 18:00 ` Michael Walle
2020-11-09 10:46 ` Vladimir Oltean
2 siblings, 1 reply; 6+ messages in thread
From: Michael Walle @ 2020-11-08 18:00 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Jakub Kicinski, Claudiu Manoil,
Ioana Ciornei, Vladimir Oltean
Hi,
Am 2020-11-01 14:19, schrieb Michael Walle:
> Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> the
> network port of the Kontron sl28 board is broken. After the migration
> to
> phylink the device tree has to specify the in-band-mode property. Add
> it.
>
> Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
Ping. will this go through the net queue or Shawn's queue. In any case,
it should make it into a fixes queue, because this board is currently
broken in 5.10-rc2.
Thanks,
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC
2020-11-08 18:00 ` Michael Walle
@ 2020-11-09 10:46 ` Vladimir Oltean
2020-11-09 10:48 ` Michael Walle
0 siblings, 1 reply; 6+ messages in thread
From: Vladimir Oltean @ 2020-11-09 10:46 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Shawn Guo, Leo Li,
Jakub Kicinski, Claudiu Manoil, Ioana Ciornei
On Sun, Nov 08, 2020 at 07:00:46PM +0100, Michael Walle wrote:
> Hi,
>
> Am 2020-11-01 14:19, schrieb Michael Walle:
> > Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the
> > network port of the Kontron sl28 board is broken. After the migration to
> > phylink the device tree has to specify the in-band-mode property. Add
> > it.
> >
> > Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
> > Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > Signed-off-by: Michael Walle <michael@walle.cc>
>
> Ping. will this go through the net queue or Shawn's queue. In any case,
> it should make it into a fixes queue, because this board is currently
> broken in 5.10-rc2.
Michael, this cannot go through the net queue, since you didn't copy
netdev@vger.kernel.org to the email. It's not in Jakub's patchwork. My
advice would be to resend it.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC
2020-11-09 10:46 ` Vladimir Oltean
@ 2020-11-09 10:48 ` Michael Walle
0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2020-11-09 10:48 UTC (permalink / raw)
To: Vladimir Oltean
Cc: linux-arm-kernel, devicetree, linux-kernel, Shawn Guo, Leo Li,
Jakub Kicinski, Claudiu Manoil, Ioana Ciornei
Am 2020-11-09 11:46, schrieb Vladimir Oltean:
> On Sun, Nov 08, 2020 at 07:00:46PM +0100, Michael Walle wrote:
>> Hi,
>>
>> Am 2020-11-01 14:19, schrieb Michael Walle:
>> > Since commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX") the
>> > network port of the Kontron sl28 board is broken. After the migration to
>> > phylink the device tree has to specify the in-band-mode property. Add
>> > it.
>> >
>> > Fixes: 71b77a7a27a3 ("enetc: Migrate to PHYLINK and PCS_LYNX")
>> > Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>> > Signed-off-by: Michael Walle <michael@walle.cc>
>>
>> Ping. will this go through the net queue or Shawn's queue. In any
>> case,
>> it should make it into a fixes queue, because this board is currently
>> broken in 5.10-rc2.
>
> Michael, this cannot go through the net queue, since you didn't copy
> netdev@vger.kernel.org to the email. It's not in Jakub's patchwork. My
> advice would be to resend it.
Oh damn. Thanks!
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-09 10:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-01 13:19 [PATCH net] arm64: dts: fsl-ls1028a-kontron-sl28: specify in-band mode for ENETC Michael Walle
2020-11-01 13:43 ` Michael Walle
2020-11-01 16:32 ` Vladimir Oltean
2020-11-08 18:00 ` Michael Walle
2020-11-09 10:46 ` Vladimir Oltean
2020-11-09 10:48 ` Michael Walle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).