devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Libin <huawei.libin@huawei.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH v3 03/21] dt-bindings: arm: hisilicon: convert Hisilicon board/soc bindings to json-schema
Date: Mon, 28 Sep 2020 20:14:51 +0800	[thread overview]
Message-ID: <4f743027-9495-9ac7-af85-f5e084ae8fca@huawei.com> (raw)
In-Reply-To: <5F71D192.8070105@hisilicon.com>



On 2020/9/28 20:05, Wei Xu wrote:
> Hi Zhen Lei,
> 
> Thanks!
> 
> On 2020/9/27 14:21, Zhen Lei wrote:
>> Convert Hisilicon SoC bindings to DT schema format using json-schema.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  .../bindings/arm/hisilicon/hisilicon.txt           | 57 ----------------
>>  .../bindings/arm/hisilicon/hisilicon.yaml          | 77 ++++++++++++++++++++++
>>  2 files changed, 77 insertions(+), 57 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>>  create mode 100644 Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>> deleted file mode 100644
>> index f7e52476f5f2f3c..000000000000000
>> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
>> +++ /dev/null
>> @@ -1,57 +0,0 @@
>> -Hisilicon Platforms Device Tree Bindings
>> -----------------------------------------------------
>> -Hi3660 SoC
>> -Required root node properties:
>> -	- compatible = "hisilicon,hi3660";
>> -
>> -HiKey960 Board
>> -Required root node properties:
>> -	- compatible = "hisilicon,hi3660-hikey960", "hisilicon,hi3660";
>> -
>> -Hi3670 SoC
>> -Required root node properties:
>> -	- compatible = "hisilicon,hi3670";
>> -
>> -HiKey970 Board
>> -Required root node properties:
>> -	- compatible = "hisilicon,hi3670-hikey970", "hisilicon,hi3670";
>> -
>> -Hi3798cv200 SoC
>> -Required root node properties:
>> -	- compatible = "hisilicon,hi3798cv200";
>> -
>> -Hi3798cv200 Poplar Board
>> -Required root node properties:
>> -	- compatible = "hisilicon,hi3798cv200-poplar", "hisilicon,hi3798cv200";
>> -
>> -Hi4511 Board
>> -Required root node properties:
>> -	- compatible = "hisilicon,hi3620-hi4511";
>> -
>> -Hi6220 SoC
>> -Required root node properties:
>> -	- compatible = "hisilicon,hi6220";
>> -
>> -HiKey Board
>> -Required root node properties:
>> -	- compatible = "hisilicon,hi6220-hikey", "hisilicon,hi6220";
>> -
>> -HiP01 ca9x2 Board
>> -Required root node properties:
>> -	- compatible = "hisilicon,hip01-ca9x2";
>> -
>> -HiP04 D01 Board
>> -Required root node properties:
>> -	- compatible = "hisilicon,hip04-d01";
>> -
>> -HiP05 D02 Board
>> -Required root node properties:
>> -	- compatible = "hisilicon,hip05-d02";
>> -
>> -HiP06 D03 Board
>> -Required root node properties:
>> -	- compatible = "hisilicon,hip06-d03";
>> -
>> -HiP07 D05 Board
>> -Required root node properties:
>> -	- compatible = "hisilicon,hip07-d05";
>> \ No newline at end of file
>> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml
>> new file mode 100644
>> index 000000000000000..362decf3b85c6fb
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.yaml
>> @@ -0,0 +1,77 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/hisilicon/hisilicon.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Hisilicon Platforms Device Tree Bindings
>> +
>> +maintainers:
>> +  - Wei Xu <xuwei5@hisilicon.com>
>> +
>> +properties:
>> +  $nodename:
>> +    const: '/'
>> +
>> +  compatible:
>> +    oneOf:
>> +      - description: Hi3660 SoC
>> +        items:
>> +          - const: hisilicon,hi3660
>> +
>> +      - description: HiKey960 Board
>> +        items:
>> +          - const: hisilicon,hi3660-hikey960
>> +          - const: hisilicon,hi3660
> 
> How about to use the boards with SoC to reduce some duplication like following?
> 
>          - description: Boards with the Hisilicon hi3660 SoC
>            items:
>              - enum:
>                  - hisilicon,hi3660-hikey960
>              - const: hisilicon,hi3660
> 
Looks like a good idea. I will do it.

> And in this case, there is no need to remove the "hisilicon,hip01" as the first patch.

OK, I will add "hisilicon,hip01" into yaml, and discard patch 1.

> 
> Best Regards,
> Wei
> 
>> +
>> +      - description: Hi3670 SoC
>> +        items:
>> +          - const: hisilicon,hi3670
>> +
>> +      - description: HiKey970 Board
>> +        items:
>> +          - const: hisilicon,hi3670-hikey970
>> +          - const: hisilicon,hi3670
>> +
>> +      - description: Hi3798cv200 SoC
>> +        items:
>> +          - const: hisilicon,hi3798cv200
>> +
>> +      - description: Hi3798cv200 Poplar Board
>> +        items:
>> +          - const: hisilicon,hi3798cv200-poplar
>> +          - const: hisilicon,hi3798cv200
>> +
>> +      - description: Hi4511 Board
>> +        items:
>> +          - const: hisilicon,hi3620-hi4511
>> +
>> +      - description: Hi6220 SoC
>> +        items:
>> +          - const: hisilicon,hi6220
>> +
>> +      - description: HiKey Board
>> +        items:
>> +          - const: hisilicon,hi6220-hikey
>> +          - const: hisilicon,hi6220
>> +
>> +      - description: HiP01 ca9x2 Board
>> +        items:
>> +          - const: hisilicon,hip01-ca9x2
>> +
>> +      - description: HiP04 D01 Board
>> +        items:
>> +          - const: hisilicon,hip04-d01
>> +
>> +      - description: HiP05 D02 Board
>> +        items:
>> +          - const: hisilicon,hip05-d02
>> +
>> +      - description: HiP06 D03 Board
>> +        items:
>> +          - const: hisilicon,hip06-d03
>> +
>> +      - description: HiP07 D05 Board
>> +        items:
>> +          - const: hisilicon,hip07-d05
>> +...
>> 	
> 
> .
> 


  reply	other threads:[~2020-09-28 12:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-27  6:21 [PATCH v3 00/21] add support for Hisilicon SD5203 SoC Zhen Lei
2020-09-27  6:21 ` [PATCH v3 01/21] ARM: dts: remove a unused compatible name in hip01-ca9x2.dts Zhen Lei
2020-09-27  6:21 ` [PATCH v3 02/21] dt-bindings: arm: hisilicon: split the dt-bindings of each controller into a separate file Zhen Lei
2020-09-28 12:37   ` Wei Xu
2020-09-28 12:51     ` Leizhen (ThunderTown)
2020-09-27  6:21 ` [PATCH v3 03/21] dt-bindings: arm: hisilicon: convert Hisilicon board/soc bindings to json-schema Zhen Lei
2020-09-28 12:05   ` Wei Xu
2020-09-28 12:14     ` Leizhen (ThunderTown) [this message]
2020-09-27  6:21 ` [PATCH v3 04/21] dt-bindings: arm: hisilicon: add binding for SD5203 SoC Zhen Lei
2020-09-27  6:21 ` [PATCH v3 05/21] ARM: hisi: add support " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 06/21] ARM: debug: add UART early console support for SD5203 Zhen Lei
2020-09-27  6:21 ` [PATCH v3 07/21] ARM: dts: add SD5203 dts Zhen Lei
2020-09-27  6:21 ` [PATCH v3 08/21] dt-bindings: arm: hisilicon: convert system controller bindings to json-schema Zhen Lei
2020-09-28  9:44   ` Jonathan Cameron
2020-09-28 10:59     ` Leizhen (ThunderTown)
2020-09-27  6:21 ` [PATCH v3 09/21] dt-bindings: arm: hisilicon: convert hisilicon,peri-subctrl " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 10/21] dt-bindings: arm: hisilicon: convert hisilicon,pcie-sas-subctrl " Zhen Lei
2020-09-28  9:46   ` [PATCH v3 10/21] dt-bindings: arm: hisilicon: convert hisilicon, pcie-sas-subctrl " Jonathan Cameron
2020-09-28 11:16     ` Leizhen (ThunderTown)
2020-09-27  6:21 ` [PATCH v3 11/21] dt-bindings: arm: hisilicon: convert hisilicon,cpuctrl " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 12/21] dt-bindings: arm: hisilicon: convert hisilicon,pctrl " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 13/21] dt-bindings: arm: hisilicon: convert hisilicon,hi3798cv200-perictrl " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 14/21] dt-bindings: arm: hisilicon: convert hisilicon,dsa-subctrl " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 15/21] dt-bindings: arm: hisilicon: convert hisilicon,hip04-fabric " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 16/21] dt-bindings: arm: hisilicon: convert hisilicon,hip04-bootwrapper " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 17/21] dt-bindings: arm: hisilicon: convert hisilicon,hi6220-aoctrl " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 18/21] dt-bindings: arm: hisilicon: convert hisilicon,hi6220-mediactrl " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 19/21] dt-bindings: arm: hisilicon: convert hisilicon,hi6220-pmctrl " Zhen Lei
2020-09-27  6:21 ` [PATCH v3 20/21] dt-bindings: arm: hisilicon: convert hisilicon,hi6220-sramctrl " Zhen Lei
2020-09-28  9:50   ` [PATCH v3 20/21] dt-bindings: arm: hisilicon: convert hisilicon, hi6220-sramctrl " Jonathan Cameron
2020-09-28 11:16     ` Leizhen (ThunderTown)
2020-09-27  6:21 ` [PATCH v3 21/21] dt-bindings: arm: hisilicon: convert LPC controller " Zhen Lei
2020-09-28  9:52   ` Jonathan Cameron
2020-09-28 11:19     ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f743027-9495-9ac7-af85-f5e084ae8fca@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=huawei.libin@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).