* [PATCH v2] dt-bindings: power: Fix dt_binding_check error
@ 2020-03-02 15:54 Jianxin Pan
2020-03-02 16:31 ` Kevin Hilman
2020-03-02 20:15 ` Rob Herring
0 siblings, 2 replies; 7+ messages in thread
From: Jianxin Pan @ 2020-03-02 15:54 UTC (permalink / raw)
To: Kevin Hilman, linux-amlogic
Cc: Jianxin Pan, SoC Team, Stephen Rothwell, Rob Herring, devicetree,
Neil Armstrong, Jerome Brunet, Martin Blumenstingl, linux-pm,
linux-kernel, linux-arm-kernel
Missing ';' in the end of secure-monitor example node.
Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
---
Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
index af32209..bc4e037 100644
--- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
+++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
@@ -36,5 +36,5 @@ examples:
compatible = "amlogic,meson-a1-pwrc";
#power-domain-cells = <1>;
};
- }
+ };
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: power: Fix dt_binding_check error
2020-03-02 15:54 [PATCH v2] dt-bindings: power: Fix dt_binding_check error Jianxin Pan
@ 2020-03-02 16:31 ` Kevin Hilman
[not found] ` <CAL_JsqJAxfL_Q3HYHk_8VeefdXnhYT7kcPe3F5Gzk1Vfj+xtww@mail.gmail.com>
2020-03-02 20:15 ` Rob Herring
1 sibling, 1 reply; 7+ messages in thread
From: Kevin Hilman @ 2020-03-02 16:31 UTC (permalink / raw)
To: Jianxin Pan, linux-amlogic
Cc: Jianxin Pan, SoC Team, Stephen Rothwell, Rob Herring, devicetree,
Neil Armstrong, Jerome Brunet, Martin Blumenstingl, linux-pm,
linux-kernel, linux-arm-kernel
Hi Jianxin,
Jianxin Pan <jianxin.pan@amlogic.com> writes:
> Missing ';' in the end of secure-monitor example node.
>
> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
> ---
> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> index af32209..bc4e037 100644
> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> @@ -36,5 +36,5 @@ examples:
> compatible = "amlogic,meson-a1-pwrc";
> #power-domain-cells = <1>;
> };
> - }
> + };
Thanks for the fix. Queued for v5.7.
@Arnd, @Olof: you can ignore this one. I requested Jianxin to send to
you thinking this was a fix for something you already queued, but it's
not. I'll handle it.
Kevin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: power: Fix dt_binding_check error
2020-03-02 15:54 [PATCH v2] dt-bindings: power: Fix dt_binding_check error Jianxin Pan
2020-03-02 16:31 ` Kevin Hilman
@ 2020-03-02 20:15 ` Rob Herring
2020-03-03 8:43 ` Kevin Hilman
2020-03-04 16:34 ` Jianxin Pan
1 sibling, 2 replies; 7+ messages in thread
From: Rob Herring @ 2020-03-02 20:15 UTC (permalink / raw)
To: Jianxin Pan
Cc: Kevin Hilman, linux-amlogic, Jianxin Pan, SoC Team,
Stephen Rothwell, devicetree, Neil Armstrong, Jerome Brunet,
Martin Blumenstingl, linux-pm, linux-kernel, linux-arm-kernel
On Mon, 2 Mar 2020 23:54:08 +0800, Jianxin Pan wrote:
> Missing ';' in the end of secure-monitor example node.
>
> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
> ---
> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: power: Fix dt_binding_check error
2020-03-02 20:15 ` Rob Herring
@ 2020-03-03 8:43 ` Kevin Hilman
2020-03-04 16:35 ` Jianxin Pan
2020-03-04 16:34 ` Jianxin Pan
1 sibling, 1 reply; 7+ messages in thread
From: Kevin Hilman @ 2020-03-03 8:43 UTC (permalink / raw)
To: Rob Herring, Jianxin Pan
Cc: linux-amlogic, Jianxin Pan, SoC Team, Stephen Rothwell,
devicetree, Neil Armstrong, Jerome Brunet, Martin Blumenstingl,
linux-pm, linux-kernel, linux-arm-kernel
Rob Herring <robh@kernel.org> writes:
> On Mon, 2 Mar 2020 23:54:08 +0800, Jianxin Pan wrote:
>> Missing ';' in the end of secure-monitor example node.
>>
>> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
>> Reported-by: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
>> ---
>> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
I've (re)added these tags:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Rob Herring <robh@kernel.org>
when applying this time.
Jianxin, please collect the tags in the future and add when you send
follow-up versions.
Thanks,
Kevin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: power: Fix dt_binding_check error
2020-03-02 20:15 ` Rob Herring
2020-03-03 8:43 ` Kevin Hilman
@ 2020-03-04 16:34 ` Jianxin Pan
1 sibling, 0 replies; 7+ messages in thread
From: Jianxin Pan @ 2020-03-04 16:34 UTC (permalink / raw)
To: Rob Herring
Cc: Kevin Hilman, linux-amlogic, SoC Team, Stephen Rothwell,
devicetree, Neil Armstrong, Jerome Brunet, Martin Blumenstingl,
linux-pm, linux-kernel, linux-arm-kernel
Hi Rob,
On 2020/3/3 4:15, Rob Herring wrote:
> On Mon, 2 Mar 2020 23:54:08 +0800, Jianxin Pan wrote:
>> Missing ';' in the end of secure-monitor example node.
>>
>> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
>> Reported-by: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
>> ---
>> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
Sorry to forget the tag, Kevin has added it for me, and I will keep it in mind next time.
> If a tag was not added on purpose, please state why and what changed.
>
> .
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: power: Fix dt_binding_check error
2020-03-03 8:43 ` Kevin Hilman
@ 2020-03-04 16:35 ` Jianxin Pan
0 siblings, 0 replies; 7+ messages in thread
From: Jianxin Pan @ 2020-03-04 16:35 UTC (permalink / raw)
To: Kevin Hilman, Rob Herring
Cc: linux-amlogic, SoC Team, Stephen Rothwell, devicetree,
Neil Armstrong, Jerome Brunet, Martin Blumenstingl, linux-pm,
linux-kernel, linux-arm-kernel
On 2020/3/3 16:43, Kevin Hilman wrote:
> Rob Herring <robh@kernel.org> writes:
>
>> On Mon, 2 Mar 2020 23:54:08 +0800, Jianxin Pan wrote:
>>> Missing ';' in the end of secure-monitor example node.
>>>
>>> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
>>> Reported-by: Rob Herring <robh+dt@kernel.org>
>>> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
>>> ---
>>> Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>
>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>> there's no need to repost patches *only* to add the tags. The upstream
>> maintainer will do that for acks received on the version they apply.
>>
>> If a tag was not added on purpose, please state why and what changed.
>
> I've (re)added these tags:
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> Acked-by: Rob Herring <robh@kernel.org>
>
> when applying this time.
>
> Jianxin, please collect the tags in the future and add when you send
> follow-up versions.
OK, I will do it next time, thanks for your time.
>
> Thanks,
>
> Kevin
>
> .
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: power: Fix dt_binding_check error
[not found] ` <CAL_JsqJAxfL_Q3HYHk_8VeefdXnhYT7kcPe3F5Gzk1Vfj+xtww@mail.gmail.com>
@ 2020-03-10 22:03 ` Kevin Hilman
0 siblings, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2020-03-10 22:03 UTC (permalink / raw)
To: Rob Herring
Cc: Jianxin Pan, open list:ARM/Amlogic Meson...,
SoC Team, Stephen Rothwell, devicetree, Neil Armstrong,
Jerome Brunet, Martin Blumenstingl, open list:THERMAL,
linux-kernel,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Rob Herring <robh+dt@kernel.org> writes:
> On Mon, Mar 2, 2020 at 10:31 AM Kevin Hilman <khilman@baylibre.com> wrote:
>>
>> Hi Jianxin,
>>
>> Jianxin Pan <jianxin.pan@amlogic.com> writes:
>>
>> > Missing ';' in the end of secure-monitor example node.
>> >
>> > Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
>> > Reported-by: Rob Herring <robh+dt@kernel.org>
>> > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
>> > ---
>> > Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> > index af32209..bc4e037 100644
>> > --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> > +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> > @@ -36,5 +36,5 @@ examples:
>> > compatible = "amlogic,meson-a1-pwrc";
>> > #power-domain-cells = <1>;
>> > };
>> > - }
>> > + };
>>
>> Thanks for the fix. Queued for v5.7.
>>
>> @Arnd, @Olof: you can ignore this one. I requested Jianxin to send to
>> you thinking this was a fix for something you already queued, but it's
>> not. I'll handle it.
>
> Someone has what needs fixing queued in linux-next, but this fix is
> still not there. Somehow it seems like features show up in linux-next
> faster than fixes for SoC tree...
The fix (this patch) is queued in my 'for-next' branch which I pushed
yesterday. I guess it missed next-20200310 but should be in tomorrow.
Kevin
[1] https://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git/log/?h=for-next
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-10 22:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-02 15:54 [PATCH v2] dt-bindings: power: Fix dt_binding_check error Jianxin Pan
2020-03-02 16:31 ` Kevin Hilman
[not found] ` <CAL_JsqJAxfL_Q3HYHk_8VeefdXnhYT7kcPe3F5Gzk1Vfj+xtww@mail.gmail.com>
2020-03-10 22:03 ` Kevin Hilman
2020-03-02 20:15 ` Rob Herring
2020-03-03 8:43 ` Kevin Hilman
2020-03-04 16:35 ` Jianxin Pan
2020-03-04 16:34 ` Jianxin Pan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).