From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints
Date: Thu, 17 May 2018 12:02:28 +0300 [thread overview]
Message-ID: <53a2030d-32de-6887-4527-56f885e9f845@cogentembedded.com> (raw)
In-Reply-To: <20180516233212.30931-1-niklas.soderlund+renesas@ragnatech.se>
On 5/17/2018 2:32 AM, Niklas Söderlund wrote:
> The style for referring to ports and endpoint are wrong. Refer to them
> using lowercase and a unit address, port@x and endpoint@x.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
More typos, yay! :-)
> ---
> .../devicetree/bindings/media/rcar_vin.txt | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index c2c57dcf73f4851b..a574b9c037c05a3c 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -45,23 +45,23 @@ The per-board settings Gen2 platforms:
> The per-board settings Gen3 platforms:
>
> Gen3 platforms can support both a single connected parallel input source
> -from external SoC pins (port0) and/or multiple parallel input sources
> -from local SoC CSI-2 receivers (port1) depending on SoC.
> +from external SoC pins (port@0) and/or multiple parallel input sources
> +from local SoC CSI-2 receivers (port@1) depending on SoC.
>
> - renesas,id - ID number of the VIN, VINx in the documentation.
> - ports
> - - port 0 - sub-node describing a single endpoint connected to the VIN
> + - port@0 - sub-node describing a single endpoint connected to the VIN
> from external SoC pins described in video-interfaces.txt[1].
> - Describing more then one endpoint in port 0 is invalid. Only VIN
> - instances that are connected to external pins should have port 0.
> - - port 1 - sub-nodes describing one or more endpoints connected to
> + Describing more then one endpoint in port@0 is invalid. Only VIN
s/then/than/.
> + instances that are connected to external pins should have port@0.
> + - port@1 - sub-nodes describing one or more endpoints connected to
> the VIN from local SoC CSI-2 receivers. The endpoint numbers must
> use the following schema.
[...]
MBR, Sergei
next prev parent reply other threads:[~2018-05-17 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 23:32 [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints Niklas Söderlund
2018-05-17 9:02 ` Sergei Shtylyov [this message]
2018-05-23 16:42 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53a2030d-32de-6887-4527-56f885e9f845@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).