* [PATCH v3 26/26] dts: bindings: coresight: ETM system register access only units
[not found] <20201028220945.3826358-1-suzuki.poulose@arm.com>
@ 2020-10-28 22:09 ` Suzuki K Poulose
2020-11-02 15:31 ` Rob Herring
2020-11-09 20:50 ` Mathieu Poirier
0 siblings, 2 replies; 4+ messages in thread
From: Suzuki K Poulose @ 2020-10-28 22:09 UTC (permalink / raw)
To: linux-arm-kernel
Cc: mathieu.poirier, mike.leach, coresight, linux-kernel,
Suzuki K Poulose, devicetree, Rob Herring
Document the bindings for ETMs with system register accesses.
Cc: devicetree@vger.kernel.org
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
Documentation/devicetree/bindings/arm/coresight.txt | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
index d711676b4a51..bff96a550102 100644
--- a/Documentation/devicetree/bindings/arm/coresight.txt
+++ b/Documentation/devicetree/bindings/arm/coresight.txt
@@ -34,9 +34,12 @@ its hardware characteristcs.
Program Flow Trace Macrocell:
"arm,coresight-etm3x", "arm,primecell";
- - Embedded Trace Macrocell (version 4.x):
+ - Embedded Trace Macrocell (version 4.x), with memory mapped access.
"arm,coresight-etm4x", "arm,primecell";
+ - Embedded Trace Macrocell with system register access only.
+ "arm,coresight-etm-sysreg";
+
- Coresight programmable Replicator :
"arm,coresight-dynamic-replicator", "arm,primecell";
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 26/26] dts: bindings: coresight: ETM system register access only units
2020-10-28 22:09 ` [PATCH v3 26/26] dts: bindings: coresight: ETM system register access only units Suzuki K Poulose
@ 2020-11-02 15:31 ` Rob Herring
2020-11-09 20:50 ` Mathieu Poirier
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-11-02 15:31 UTC (permalink / raw)
To: Suzuki K Poulose
Cc: linux-kernel, coresight, devicetree, mike.leach,
linux-arm-kernel, mathieu.poirier
On Wed, 28 Oct 2020 22:09:45 +0000, Suzuki K Poulose wrote:
> Document the bindings for ETMs with system register accesses.
>
> Cc: devicetree@vger.kernel.org
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> Documentation/devicetree/bindings/arm/coresight.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 26/26] dts: bindings: coresight: ETM system register access only units
2020-10-28 22:09 ` [PATCH v3 26/26] dts: bindings: coresight: ETM system register access only units Suzuki K Poulose
2020-11-02 15:31 ` Rob Herring
@ 2020-11-09 20:50 ` Mathieu Poirier
2020-11-10 10:51 ` Suzuki K Poulose
1 sibling, 1 reply; 4+ messages in thread
From: Mathieu Poirier @ 2020-11-09 20:50 UTC (permalink / raw)
To: Suzuki K Poulose
Cc: linux-arm-kernel, mike.leach, coresight, linux-kernel,
devicetree, Rob Herring
On Wed, Oct 28, 2020 at 10:09:45PM +0000, Suzuki K Poulose wrote:
> Document the bindings for ETMs with system register accesses.
>
> Cc: devicetree@vger.kernel.org
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> Documentation/devicetree/bindings/arm/coresight.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index d711676b4a51..bff96a550102 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -34,9 +34,12 @@ its hardware characteristcs.
> Program Flow Trace Macrocell:
> "arm,coresight-etm3x", "arm,primecell";
>
> - - Embedded Trace Macrocell (version 4.x):
> + - Embedded Trace Macrocell (version 4.x), with memory mapped access.
> "arm,coresight-etm4x", "arm,primecell";
>
> + - Embedded Trace Macrocell with system register access only.
> + "arm,coresight-etm-sysreg";
Please make this "arm,coresight-etm4x-sysreg". Up to now all reference of
"etm" without a version related to ETMv3/PTM1.1. If we start mixing things it
will be come insanely confusing.
Thanks,
Mathieu
> +
> - Coresight programmable Replicator :
> "arm,coresight-dynamic-replicator", "arm,primecell";
>
> --
> 2.24.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 26/26] dts: bindings: coresight: ETM system register access only units
2020-11-09 20:50 ` Mathieu Poirier
@ 2020-11-10 10:51 ` Suzuki K Poulose
0 siblings, 0 replies; 4+ messages in thread
From: Suzuki K Poulose @ 2020-11-10 10:51 UTC (permalink / raw)
To: Mathieu Poirier
Cc: linux-arm-kernel, mike.leach, coresight, linux-kernel,
devicetree, Rob Herring
On 11/9/20 8:50 PM, Mathieu Poirier wrote:
> On Wed, Oct 28, 2020 at 10:09:45PM +0000, Suzuki K Poulose wrote:
>> Document the bindings for ETMs with system register accesses.
>>
>> Cc: devicetree@vger.kernel.org
>> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
>> Cc: Mike Leach <mike.leach@linaro.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>> ---
>> Documentation/devicetree/bindings/arm/coresight.txt | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
>> index d711676b4a51..bff96a550102 100644
>> --- a/Documentation/devicetree/bindings/arm/coresight.txt
>> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
>> @@ -34,9 +34,12 @@ its hardware characteristcs.
>> Program Flow Trace Macrocell:
>> "arm,coresight-etm3x", "arm,primecell";
>>
>> - - Embedded Trace Macrocell (version 4.x):
>> + - Embedded Trace Macrocell (version 4.x), with memory mapped access.
>> "arm,coresight-etm4x", "arm,primecell";
>>
>> + - Embedded Trace Macrocell with system register access only.
>> + "arm,coresight-etm-sysreg";
>
> Please make this "arm,coresight-etm4x-sysreg". Up to now all reference of
> "etm" without a version related to ETMv3/PTM1.1. If we start mixing things it
> will be come insanely confusing.
Agreed. will rename it.
Suzuki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-10 10:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201028220945.3826358-1-suzuki.poulose@arm.com>
2020-10-28 22:09 ` [PATCH v3 26/26] dts: bindings: coresight: ETM system register access only units Suzuki K Poulose
2020-11-02 15:31 ` Rob Herring
2020-11-09 20:50 ` Mathieu Poirier
2020-11-10 10:51 ` Suzuki K Poulose
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).