From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Paweł Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Markus Pargmann" <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Stephen Warren"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"Thierry Reding"
<treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Benoit Parrot" <bparrot-l0cyMroinI0@public.gmane.org>,
"Alexandre Courbot"
<acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed
Date: Wed, 13 Apr 2016 18:24:06 +0530 [thread overview]
Message-ID: <570E416E.1000608@nvidia.com> (raw)
In-Reply-To: <CACRpkdbLKWDGvhqtwoogNNgQjG86g9HmpceLLVwKW+94dJk63A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wednesday 13 April 2016 06:13 PM, Linus Walleij wrote:
> On Fri, Mar 11, 2016 at 2:43 PM, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
>
>> If GPIO hog configuration failed while adding OF based
>> gpiochip() then return the error instead of ignoring it.
>>
>> This helps of properly handling the gpio driver dependency.
>>
>> When adding the gpio hog nodes for NVIDIA's Tegra210 platforms,
>> the gpio_hogd() fails with EPROBE_DEFER because pinctrl is not
>> ready at this time and gpio_request() for Tegra GPIO driver
>> returns error. The error was not causing the Tegra GPIO driver
>> to fail as the error was getting ignored.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> Cc: Benoit Parrot <bparrot-l0cyMroinI0@public.gmane.org>
>> Cc: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> Reviewed-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Rebased and applied this patch FWIW.
> This is a fair and square bug fix so need to go in
> no matter what happens with the hog patches.
>
Thank you very much for accepting the patch.
I think 1/5 and 2/5 is also fine as there is no more comment on this.
However, 4/5 and 5/5 needs further discussion.
Please let me know if I need to send 1/5 and 2/5 here.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-13 12:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 13:43 [PATCH V2 0/5] gpio: of: Add error handling and support for multiple gpio in gpio-hog Laxman Dewangan
2016-03-11 13:43 ` [PATCH V2 1/5] gpio: of: Scan available child node for gpio-hog Laxman Dewangan
2016-03-15 14:09 ` Linus Walleij
[not found] ` <1457703804-3016-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-11 13:43 ` [PATCH V2 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan
[not found] ` <1457703804-3016-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-15 14:11 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed Laxman Dewangan
2016-03-15 14:12 ` Linus Walleij
[not found] ` <CACRpkdbsu+yfFvCR2=vKO3+S46+GHSy+3wu+5uwMmsu0_mfP-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-16 11:10 ` Laxman Dewangan
[not found] ` <1457703804-3016-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-13 12:43 ` Linus Walleij
[not found] ` <CACRpkdbLKWDGvhqtwoogNNgQjG86g9HmpceLLVwKW+94dJk63A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-13 12:54 ` Laxman Dewangan [this message]
2016-04-14 12:52 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 4/5] gpio: DT: Rephrase "gpios" of hog node to support multiple gpios Laxman Dewangan
[not found] ` <1457703804-3016-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-14 16:31 ` Stephen Warren
[not found] ` <56E6E753.1020505-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-03-15 6:37 ` Laxman Dewangan
[not found] ` <56E7ADA5.7000502-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-15 15:40 ` Stephen Warren
2016-03-15 14:16 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 5/5] gpio: of: Add support to have multiple gpios in gpio-hog Laxman Dewangan
2016-03-15 14:21 ` Linus Walleij
[not found] ` <CACRpkdaoKeKAJX1mOD2v1rG_5ZVjAo66agoZrs6E606syUDLSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-16 11:18 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E416E.1000608@nvidia.com \
--to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=bparrot-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).