From: Linus Walleij <linus.walleij@linaro.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Paweł Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Markus Pargmann" <mpa@pengutronix.de>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Thierry Reding" <treding@nvidia.com>,
"Benoit Parrot" <bparrot@ti.com>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed
Date: Tue, 15 Mar 2016 15:12:59 +0100 [thread overview]
Message-ID: <CACRpkdbsu+yfFvCR2=vKO3+S46+GHSy+3wu+5uwMmsu0_mfP-Q@mail.gmail.com> (raw)
In-Reply-To: <1457703804-3016-4-git-send-email-ldewangan@nvidia.com>
On Fri, Mar 11, 2016 at 2:43 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> If GPIO hog configuration failed while adding OF based
> gpiochip() then return the error instead of ignoring it.
>
> This helps of properly handling the gpio driver dependency.
>
> When adding the gpio hog nodes for NVIDIA's Tegra210 platforms,
> the gpio_hogd() fails with EPROBE_DEFER because pinctrl is not
> ready at this time and gpio_request() for Tegra GPIO driver
> returns error. The error was not causing the Tegra GPIO driver
> to fail as the error was getting ignored.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Benoit Parrot <bparrot@ti.com>
> Cc: Alexandre Courbot <acourbot@nvidia.com>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
Oops is this something I should apply for fixes and tag
for stable?
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-03-15 14:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 13:43 [PATCH V2 0/5] gpio: of: Add error handling and support for multiple gpio in gpio-hog Laxman Dewangan
2016-03-11 13:43 ` [PATCH V2 1/5] gpio: of: Scan available child node for gpio-hog Laxman Dewangan
2016-03-15 14:09 ` Linus Walleij
[not found] ` <1457703804-3016-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-11 13:43 ` [PATCH V2 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan
[not found] ` <1457703804-3016-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-15 14:11 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed Laxman Dewangan
2016-03-15 14:12 ` Linus Walleij [this message]
[not found] ` <CACRpkdbsu+yfFvCR2=vKO3+S46+GHSy+3wu+5uwMmsu0_mfP-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-16 11:10 ` Laxman Dewangan
[not found] ` <1457703804-3016-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-13 12:43 ` Linus Walleij
[not found] ` <CACRpkdbLKWDGvhqtwoogNNgQjG86g9HmpceLLVwKW+94dJk63A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-13 12:54 ` Laxman Dewangan
2016-04-14 12:52 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 4/5] gpio: DT: Rephrase "gpios" of hog node to support multiple gpios Laxman Dewangan
[not found] ` <1457703804-3016-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-14 16:31 ` Stephen Warren
[not found] ` <56E6E753.1020505-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-03-15 6:37 ` Laxman Dewangan
[not found] ` <56E7ADA5.7000502-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-15 15:40 ` Stephen Warren
2016-03-15 14:16 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 5/5] gpio: of: Add support to have multiple gpios in gpio-hog Laxman Dewangan
2016-03-15 14:21 ` Linus Walleij
[not found] ` <CACRpkdaoKeKAJX1mOD2v1rG_5ZVjAo66agoZrs6E606syUDLSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-16 11:18 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbsu+yfFvCR2=vKO3+S46+GHSy+3wu+5uwMmsu0_mfP-Q@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=acourbot@nvidia.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mpa@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).