From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Bresticker
<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM64: boot: dts: Add regulators for Tegra210 Smaug
Date: Mon, 6 Jun 2016 12:09:41 +0530 [thread overview]
Message-ID: <57551AAD.2020805@nvidia.com> (raw)
In-Reply-To: <1464985365-11612-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Saturday 04 June 2016 01:52 AM, Rhyland Klein wrote:
> +
> + max77620_default: pinmux@0 {
> + pin_gpio {
> + pins = "gpio0", "gpio1", "gpio2", "gpio5",
> + "gpio6", "gpio7";
gpio5 and gpio6 are already there in below nodes and hence it is not
needed here.
> + function = "gpio";
> + };
> +
> + /*
> + * GPIO3 is used to en_pp3300, and it is part of power
> + * sequence, So it must be sequenced up (automatically
> + * set by OTP) and down properly.
> + */
> + pin_gpio3 {
> + pins = "gpio3";
> + function = "fps-out";
> + drive-open-drain = <1>;
> + maxim,active-fps-source = <MAX77620_FPS_SRC_0>;
> + maxim,active-fps-power-up-slot = <4>;
> + maxim,active-fps-power-down-slot = <2>;
> + };
> +
> + pin_gpio5_6_7 {
node name should be gpio5_6 as there is no gpio7 inside this node.
> +
> + regulators {
> + in-ldo0-1-supply = <&pp1350>;
> + in-ldo2-supply = <&pp3300>;
> + in-ldo3-5-supply = <&pp3300>;
> + in-ldo7-8-supply = <&pp1350>;
> +
> + ppvar_soc: sd0 {
> + regulator-name = "PPVAR_SOC";
> + regulator-min-microvolt = <825000>;
> + regulator-max-microvolt = <1125000>;
> + regulator-enable-ramp-delay = <146>;
> + regulator-disable-ramp-delay = <4080>;
> + regulator-ramp-delay = <27500>;
> + regulator-ramp-delay-scale = <300>;
There is no disable-ramp-delay in mainline.
Please use the correct value for property as:
regulator-ramp-delay = <9000>;
maxim,ramp-rate-setting = <27500>;
instead of regulator-ramp-delay and regulator-ramp-delay-scale.
The property differs from downstream.
regulator-ramp-delay is what you see in platform and
maxim,ramp-rate-setting is what you want in register.
next prev parent reply other threads:[~2016-06-06 6:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 20:22 [PATCH] ARM64: boot: dts: Add regulators for Tegra210 Smaug Rhyland Klein
[not found] ` <1464985365-11612-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-06-06 6:39 ` Laxman Dewangan [this message]
2016-06-06 21:52 ` Rhyland Klein
[not found] ` <b28b44d9-7f3e-c1bb-7df8-238191ab1941-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-06-07 11:35 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57551AAD.2020805@nvidia.com \
--to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).