[PATCH v5] phy-sun4i-usb: Fix irq free conditions to match request conditions

[PATCH v5] phy-sun4i-usb: Fix irq free conditions to match request conditions

[Hans de Goede]

commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe")
changed the condition under which irqs are requested, but omitted matching
changes to sun4i_usb_phy_remove(). This commit fixes this.

Fixes: commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe")
Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 drivers/phy/phy-sun4i-usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
index 8c2570d..8c7eb33 100644
--- a/drivers/phy/phy-sun4i-usb.c
+++ b/drivers/phy/phy-sun4i-usb.c
@@ -548,9 +548,9 @@ static int sun4i_usb_phy_remove(struct platform_device *pdev)
 
 	if (data->vbus_power_nb_registered)
 		power_supply_unreg_notifier(&data->vbus_power_nb);
-	if (data->id_det_irq >= 0)
+	if (data->id_det_irq > 0)
 		devm_free_irq(dev, data->id_det_irq, data);
-	if (data->vbus_det_irq >= 0)
+	if (data->vbus_det_irq > 0)
 		devm_free_irq(dev, data->vbus_det_irq, data);
 
 	cancel_delayed_work_sync(&data->detect);
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5] phy-sun4i-usb: Fix irq free conditions to match request conditions

[Sergei Shtylyov]

On 6/18/2016 12:31 PM, Hans de Goede wrote:

> commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe")
> changed the condition under which irqs are requested, but omitted matching
> changes to sun4i_usb_phy_remove(). This commit fixes this.
>
> Fixes: commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe")

    "Commit" not needed here, this tag has a standardized format.

> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5] phy-sun4i-usb: Fix irq free conditions to match request conditions

[Kishon Vijay Abraham I]

Hi,

On Saturday 18 June 2016 05:03 PM, Sergei Shtylyov wrote:
> On 6/18/2016 12:31 PM, Hans de Goede wrote:
> 
>> commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing probe")
>> changed the condition under which irqs are requested, but omitted matching
>> changes to sun4i_usb_phy_remove(). This commit fixes this.
>>
>> Fixes: commit 5cf700ac9d50("phy: phy-sun4i-usb: Fix optional gpios failing
>> probe")
> 
>    "Commit" not needed here, this tag has a standardized format.

Fixed it myself and applied.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html