From: Hector Martin <marcan@marcan.st>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-arm-kernel@lists.infradead.org
Cc: Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Arnd Bergmann <arnd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
Philipp Zabel <p.zabel@pengutronix.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: arm: apple: Add apple,pmgr binding
Date: Thu, 7 Oct 2021 00:26:02 +0900 [thread overview]
Message-ID: <57991dac-196e-a76d-831a-d4ac166bfe29@marcan.st> (raw)
In-Reply-To: <18818eff-87d7-6a53-a4fd-7f3cbf625a0e@canonical.com>
On 06/10/2021 15.56, Krzysztof Kozlowski wrote:
>> diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
>> new file mode 100644
>> index 000000000000..0304164e4140
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
>> @@ -0,0 +1,74 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/apple/apple,pmgr.yaml#
>
> Please don't store all Apple-related bindings in bindings/arm/apple, but
> instead group per device type like in most of other bindings. In this
> case - this looks like something close to power domain controller, so it
> should be in bindings/power/
This is a controller that, right now, is only used to instantiate device
power management controls, but the controller itself is just a generic
syscon device. Depending on the register range, it could conceivably
encompass other register types (e.g. clock selects) within it, though
I'm not sure I want to do that right now. Apple calls several of these
different register sets as a whole a "PMGR". So I'm not sure if it
really qualifies as "just" a power domain controller. If we want to
restrict this to the power state portion of PMGR, then it might make
sense to call it something more specific...
See arm/rockchip/pmu.yaml for the setup this is modeled after.
> No power-domain-cells? Why? What exactly this device is going to do?
> Maybe I'll check the driver first.... :)
It's a syscon, it does nothing on its own. All the work is done by the
child nodes and the driver that binds to those.
>> +additionalProperties: true
>
> additionalProperties: false
Fixed for v2.
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
next prev parent reply other threads:[~2021-10-06 15:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 15:59 [PATCH 0/7] Apple SoC PMGR device power states driver Hector Martin
2021-10-05 15:59 ` [PATCH 1/7] dt-bindings: arm: apple: Add apple,pmgr binding Hector Martin
2021-10-05 20:09 ` Mark Kettenis
2021-10-05 22:45 ` Rob Herring
2021-10-06 15:17 ` Hector Martin
2021-10-06 6:56 ` Krzysztof Kozlowski
2021-10-06 7:30 ` Krzysztof Kozlowski
2021-10-06 15:21 ` Hector Martin
2021-10-06 15:26 ` Hector Martin [this message]
2021-10-07 13:10 ` Krzysztof Kozlowski
2021-10-05 15:59 ` [PATCH 2/7] dt-bindings: power: Add apple,pmgr-pwrstate binding Hector Martin
2021-10-05 20:16 ` Mark Kettenis
2021-10-06 15:27 ` Hector Martin
2021-10-06 0:58 ` Rob Herring
2021-10-06 15:52 ` Hector Martin
2021-10-06 15:55 ` Hector Martin
2021-10-08 7:50 ` Krzysztof Kozlowski
2021-10-11 5:17 ` Hector Martin
2021-10-06 7:05 ` Krzysztof Kozlowski
2021-10-06 15:59 ` Hector Martin
2021-10-07 13:12 ` Krzysztof Kozlowski
2021-10-11 4:42 ` Hector Martin
2021-10-05 15:59 ` [PATCH 3/7] soc: apple: Add driver for Apple PMGR power state controls Hector Martin
2021-10-05 16:08 ` Linus Walleij
2021-10-05 16:15 ` Hector Martin
2021-10-05 19:49 ` Linus Walleij
2021-10-05 20:21 ` Mark Kettenis
2021-10-06 16:00 ` Hector Martin
2021-10-06 7:28 ` Krzysztof Kozlowski
2021-10-06 16:08 ` Hector Martin
2021-10-06 9:24 ` Philipp Zabel
2021-10-06 16:11 ` Hector Martin
2021-10-05 15:59 ` [PATCH 4/7] arm64: dts: apple: t8103: Rename clk24 to clkref Hector Martin
2021-10-05 20:22 ` Mark Kettenis
2021-10-05 15:59 ` [PATCH 5/7] arm64: dts: apple: t8103: Add the UART PMGR tree Hector Martin
2021-10-05 20:25 ` Mark Kettenis
2021-10-05 15:59 ` [PATCH 6/7] tty: serial: samsung_tty: Support runtime PM Hector Martin
2021-10-06 7:43 ` Krzysztof Kozlowski
2021-10-06 13:25 ` Rafael J. Wysocki
2021-10-06 13:29 ` Krzysztof Kozlowski
2021-10-11 5:32 ` Hector Martin
2021-10-11 6:48 ` Krzysztof Kozlowski
2021-10-11 8:27 ` Johan Hovold
2021-10-05 15:59 ` [PATCH 7/7] arm64: dts: apple: t8103: Add UART2 Hector Martin
2021-10-05 20:26 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57991dac-196e-a76d-831a-d4ac166bfe29@marcan.st \
--to=marcan@marcan.st \
--cc=alyssa@rosenzweig.io \
--cc=arnd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.kettenis@xs4all.nl \
--cc=maz@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).