* [PATCH] dt-bindings: net: wireless: Add sg parameters dts parsing @ 2017-12-11 8:11 Chi-Hsien Lin [not found] ` <20171211081144.GA140567-Oa2joqsrgCQFtx9iUY/I1CAzFfycyo/qAL8bYrjMMd8@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Chi-Hsien Lin @ 2017-12-11 8:11 UTC (permalink / raw) To: devicetree-u79uwXL29TY76Z2rM5mHXA Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA, brcm80211-dev-list, brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w, Arend van Spriel, Kalle Valo broken_sg_support, sd_head_align, and sd_sgentry_align are used in brcmfmac code but not configurable in dts file. Add the parsing logic. Now they can be configured like below in dts: brcm,broken_sg_support; brcm,sd_head_align = <4>; brcm,sd_sgentry_align = <4>; Signed-off-by: Chi-hsien Lin <chi-hsien.lin-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org> --- .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt index 86602f2..4d42f0d 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt @@ -17,6 +17,11 @@ Optional properties: When not specified the device will use in-band SDIO interrupts. - interrupt-names : name of the out-of-band interrupt, which must be set to "host-wake". + - broken_sg_support : flag for broken sg list support of SDIO host controller. + Set this to true if the SDIO host controller has higher align + requirement than 32 bytes for each scatterlist item. + - sg_head_align : alignment requirement for start of data buffer. + - sg_sgentry_align : length alignment requirement for each sg entry. Example: @@ -36,5 +41,8 @@ mmc3: mmc@1c12000 { interrupt-parent = <&pio>; interrupts = <10 8>; /* PH10 / EINT10 */ interrupt-names = "host-wake"; + brcm,broken_sg_support; + brcm,sd_head_align = <4>; + brcm,sd_sgentry_align = <4>; }; }; -- 2.1.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <20171211081144.GA140567-Oa2joqsrgCQFtx9iUY/I1CAzFfycyo/qAL8bYrjMMd8@public.gmane.org>]
* Re: [PATCH] dt-bindings: net: wireless: Add sg parameters dts parsing [not found] ` <20171211081144.GA140567-Oa2joqsrgCQFtx9iUY/I1CAzFfycyo/qAL8bYrjMMd8@public.gmane.org> @ 2017-12-11 9:55 ` Arend van Spriel [not found] ` <5A2E5606.8010707-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Arend van Spriel @ 2017-12-11 9:55 UTC (permalink / raw) To: Chi-Hsien Lin, devicetree-u79uwXL29TY76Z2rM5mHXA Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA, brcm80211-dev-list, brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w, Kalle Valo On 12/11/2017 9:11 AM, Chi-Hsien Lin wrote: > broken_sg_support, sd_head_align, and sd_sgentry_align are used in > brcmfmac code but not configurable in dts file. Add the parsing logic. > Now they can be configured like below in dts: > brcm,broken_sg_support; > brcm,sd_head_align = <4>; > brcm,sd_sgentry_align = <4>; > > Signed-off-by: Chi-hsien Lin <chi-hsien.lin-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org> > --- > .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > index 86602f2..4d42f0d 100644 > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > @@ -17,6 +17,11 @@ Optional properties: > When not specified the device will use in-band SDIO interrupts. > - interrupt-names : name of the out-of-band interrupt, which must be set > to "host-wake". > + - broken_sg_support : flag for broken sg list support of SDIO host controller. > + Set this to true if the SDIO host controller has higher align > + requirement than 32 bytes for each scatterlist item. In DT context, this does not characterize the device but as described it is about the SDIO host controller. I think the same applies to the properties below, but not entirely sure about that. > + - sg_head_align : alignment requirement for start of data buffer. > + - sg_sgentry_align : length alignment requirement for each sg entry. Regards, Arend -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <5A2E5606.8010707-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH] dt-bindings: net: wireless: Add sg parameters dts parsing [not found] ` <5A2E5606.8010707-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> @ 2017-12-15 21:46 ` Rob Herring 0 siblings, 0 replies; 3+ messages in thread From: Rob Herring @ 2017-12-15 21:46 UTC (permalink / raw) To: Arend van Spriel, Chi-Hsien Lin Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-wireless-u79uwXL29TY76Z2rM5mHXA, brcm80211-dev-list, brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w, Kalle Valo On Mon, Dec 11, 2017 at 10:55:18AM +0100, Arend van Spriel wrote: > On 12/11/2017 9:11 AM, Chi-Hsien Lin wrote: > > broken_sg_support, sd_head_align, and sd_sgentry_align are used in > > brcmfmac code but not configurable in dts file. Add the parsing logic. > > Now they can be configured like below in dts: > > brcm,broken_sg_support; > > brcm,sd_head_align = <4>; > > brcm,sd_sgentry_align = <4>; > > > > Signed-off-by: Chi-hsien Lin <chi-hsien.lin-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org> > > --- > > .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > > index 86602f2..4d42f0d 100644 > > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > > @@ -17,6 +17,11 @@ Optional properties: > > When not specified the device will use in-band SDIO interrupts. > > - interrupt-names : name of the out-of-band interrupt, which must be set > > to "host-wake". > > + - broken_sg_support : flag for broken sg list support of SDIO host controller. > > + Set this to true if the SDIO host controller has higher align > > + requirement than 32 bytes for each scatterlist item. > > In DT context, this does not characterize the device but as described it is > about the SDIO host controller. I think the same applies to the properties > below, but not entirely sure about that. Yes. However, all of this should be implied by the host controller's compatible property. For future reference, don't use '_' in property names either. Rob ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-15 21:46 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-11 8:11 [PATCH] dt-bindings: net: wireless: Add sg parameters dts parsing Chi-Hsien Lin [not found] ` <20171211081144.GA140567-Oa2joqsrgCQFtx9iUY/I1CAzFfycyo/qAL8bYrjMMd8@public.gmane.org> 2017-12-11 9:55 ` Arend van Spriel [not found] ` <5A2E5606.8010707-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> 2017-12-15 21:46 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).