From: Marcel Holtmann <marcel@holtmann.org>
To: Rocky Liao <rjliao@codeaurora.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Johan Hedberg <johan.hedberg@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org,
linux-bluetooth-owner@vger.kernel.org
Subject: Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390
Date: Fri, 13 Dec 2019 08:37:17 +0100 [thread overview]
Message-ID: <5F24A10B-D0DB-4FE7-8EB1-1028671599FB@holtmann.org> (raw)
In-Reply-To: <ab0557bcacdae61027b775f440145b05@codeaurora.org>
Hi Rocky,
>>> Add compatible string for the Qualcomm QCA6390 Bluetooth controller
>>> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
>>> ---
>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> index 68b67d9db63a..87b7f9d22414 100644
>>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> @@ -10,6 +10,7 @@ device the slave device is attached to.
>>> Required properties:
>>> - compatible: should contain one of the following:
>>> * "qcom,qca6174-bt"
>>> + * "qcom,qca6390-bt"
>>> * "qcom,wcn3990-bt"
>>> * "qcom,wcn3998-bt"
>> now I am confused. Is this a DT platform or ACPI or both?
> We need to support both, should I update ACPI part in this doc as well?
this patch is fine the, but the other one would be better if you split it in DT and ACPI support.
Regards
Marcel
next prev parent reply other threads:[~2019-12-13 7:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0101016ef8b923bc-5760b40c-1968-4992-9186-8e3965207236-000000@us-west-2.amazonses.com>
2019-12-12 10:33 ` [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390 Marcel Holtmann
2019-12-13 3:35 ` rjliao
2019-12-13 7:37 ` Marcel Holtmann [this message]
2019-12-12 6:08 Rocky Liao
2019-12-19 23:07 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F24A10B-D0DB-4FE7-8EB1-1028671599FB@holtmann.org \
--to=marcel@holtmann.org \
--cc=bgodavar@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth-owner@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rjliao@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).